Bump eslint-config-expensify version in E/App by blazejkustra · Pull Request #36849 · Expensify/App

blazejkustra · 2024-02-20T09:08:25Z

Details

Affected rules:

Fixed no-loss-of-precision - Eslint explanation
Fixed no-promise-executor-return - Eslint explanation
Fixed no-import-assign - Disallows assignment to imported bindings ('no-import-assign': 'off' added to tests).
Fixed no-unsafe-optional-chaining - Disallows optional chaining expressions at potentially unsafe positions.
Fixed react/jsx-no-useless-fragment - Disallow unnecessary React fragments.
Turned off prefer-regex-literals - Suggests to use regex literals instead of new RegExp().
Fixed import/no-relative-packages - Forbidden any requires that come for a package inside itself
Fixed react/no-unused-class-component-methods - Prevent definitions of unused class methods
Fixed import/no-import-module-exports/ - Don't mix require/ES6 imports and module.export
Fixed react/no-unstable-nested-components - Prevents creating unstable components inside components
Fixed react/sort-comp - Enforces a sort order for methods and properties
Fixed default-param-last - Enforces default parameters to be the last in the function definition

Fixed Issues

$ #36718
PROPOSAL: N/A

Tests

Verify that desktop app works
Test that requesting money (scan receipt, distance and manual request) work as expected
Verify that Share QRCode works as usual
Verify that PDFViewer works as usual
Test reimbursement form (mainly that labels display as usual)

Offline tests

N/A

QA Steps

Same as tests

PR Author Checklist

Screenshots/Videos

Android: Native

android.webm

Android: mWeb Chrome

adnroid-web.webm

iOS: Native

ios.mp4

iOS: mWeb Safari

ios-web.mp4

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

melvin-bot · 2024-02-20T12:27:37Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

melvin-bot · 2024-02-20T13:06:37Z

@jjcoffee Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

blazejkustra · 2024-02-20T13:10:08Z

@@ -1,4 +1,5 @@
 **/node_modules/*
 **/dist/*
+android/**/build/*


This fixes npm run lint bug that I reported two weeks ago here

jjcoffee · 2024-02-20T13:22:55Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android-native.mp4

Android: mWeb Chrome

android-chrome-2024-02-26_17.39.03.mp4

iOS: Native

ios-native-2024-02-26_17.08.25.mp4

iOS: mWeb Safari

ios-safari-2024-02-26_17.12.47.mp4

MacOS: Chrome / Safari

desktop-chrome-2024-02-26_16.35.43.mp4

MacOS: Desktop

desktop-app-2024-02-26_17.02.29.mp4

blazejkustra · 2024-02-20T14:07:18Z

I recommend reviewing this PR commit by commit, to understand the changes better cc @roryabraham @jjcoffee

jjcoffee · 2024-02-23T16:44:00Z

@jjcoffee I think we definitely need a C+ review on this one

@roryabraham Gotcha! Thanks for confirming, I'll review on Monday.

blazejkustra · 2024-02-26T11:43:04Z

This PR keeps getting conflicts, @jjcoffee merged the newest main for you, please have a look today

jjcoffee · 2024-02-26T15:11:59Z

@blazejkustra Would you mind fixing conflicts so I can get a clean test pass in?

blazejkustra · 2024-02-26T15:27:09Z

Done @jjcoffee

jjcoffee · 2024-02-26T17:17:44Z

@blazejkustra I'm getting a crash on Android Native when opening any attachment (AttachmentCarousel):

Couldn't replicate on latest main.

blazejkustra · 2024-02-27T08:05:22Z

Fixed in the last commit, I'm surprised that it wasn't detected by my IDE.

jjcoffee

Tests well and LGTM!

OSBotify · 2024-02-27T20:07:33Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

situchan · 2024-02-28T20:37:25Z

+            <Avatar
+                containerStyles={styles.avatarXLarge}
+                imageStyles={[styles.avatarXLarge, styles.alignSelfCenter]}
+                source={policy?.avatar ?? ReportUtils.getDefaultWorkspaceAvatar(policyName)}


This caused regression. policy.avatar can be empty string

Here's the link to the issue: #37465. It's now blocker btw

OSBotify · 2024-02-29T00:07:01Z

🚀 Deployed to staging by https://github.com/roryabraham in version: 1.4.45-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-02-29T23:31:29Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.45-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

blazejkustra added 16 commits February 20, 2024 08:58

Bump eslint and temporarly turn off new rules

40366b7

Fix eslint running on files in a build catalog

0631318

Fix no-loss-of-precision

3cc326e

Fix no-promise-executor-return

b105c6c

Turn off no-import-assign rule in tests

472878f

Fix no-unsafe-optional-chaining

9c54cb9

Fix react/jsx-no-useless-fragment

5519dba

Remove eslint-plugin-react-hooks

6f53d0d

Turn off prefer-regex-literals

b7f3554

fix import/no-relative-packages and add desktop import path

67aadf2

Fix react/no-unused-class-component-methods

6cc0b0e

Disable import/no-import-module-exports in one file

5b249d2

Fix default-param-last

3e5295f

Fix sort-comp

d6919aa

Disable default-param-last

9aadd40

Fix react/no-unstable-nested-components

8375325

blazejkustra changed the title ~~Bump eslint-config-expensify~~ Bump eslint-config-expensify version in E/App Feb 20, 2024

Add @desktop to webpack.common.js

f954f5e

blazejkustra marked this pull request as ready for review February 20, 2024 13:06

blazejkustra requested a review from a team as a code owner February 20, 2024 13:06

melvin-bot Bot requested review from jjcoffee and removed request for a team February 20, 2024 13:06

blazejkustra mentioned this pull request Feb 20, 2024

[HOLD for payment 2024-03-07] Bump eslint-config-expensify version in E/App #36718

Closed

blazejkustra commented Feb 20, 2024

View reviewed changes

kowczarz reviewed Feb 20, 2024

View reviewed changes

Fix webpack config

bbb4f41

blazejkustra added 3 commits February 23, 2024 11:51

Merge branch 'main' into chore/bump-eslint-config

871f559

alphabetize imports

259d23b

Extract styles to a separate variable

4ad944b

blazejkustra added 2 commits February 26, 2024 10:15

Merge branch 'main' into chore/bump-eslint-config

9dc38b9

Fix new fragment errors

9723519

Merge branch 'main' into chore/bump-eslint-config

1d46123

blazejkustra commented Feb 26, 2024

View reviewed changes

Comment thread src/components/Attachments/AttachmentCarousel/index.native.js

jjcoffee reviewed Feb 26, 2024

View reviewed changes

Comment thread src/libs/ReportUtils.ts

Use string literals in favor of string concatenation

7907c17

Merge branch 'main' into chore/bump-eslint-config

746780f

blazejkustra added 2 commits February 27, 2024 08:46

Merge branch 'main' into chore/bump-eslint-config

542d1de

Remove ';' that crashes the app

7264c60

jjcoffee approved these changes Feb 27, 2024

View reviewed changes

melvin-bot Bot requested a review from roryabraham February 27, 2024 10:16

Merge branch 'main' into chore/bump-eslint-config

f691cfd

roryabraham approved these changes Feb 27, 2024

View reviewed changes

roryabraham merged commit e35876f into Expensify:main Feb 27, 2024

situchan reviewed Feb 28, 2024

View reviewed changes

github-actions Bot mentioned this pull request Feb 28, 2024

Deploy Checklist: New Expensify 2024-02-28 #37459

Closed

91 tasks

hungvu193 mentioned this pull request Feb 29, 2024

[$500] [HOLD for payment 2024-03-11] [HOLD for payment 2024-03-07] Workspace - Workspace avatar is missing in Profile page #37465

Closed

6 tasks

blazejkustra mentioned this pull request Mar 26, 2024

[Snyk] Upgrade eslint-config-expensify from 2.0.16 to 2.0.44 Expensify/expensify-common#667

Merged

Uh oh!

Conversation

blazejkustra commented Feb 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Feb 20, 2024

Uh oh!

melvin-bot Bot commented Feb 20, 2024

Uh oh!

blazejkustra Feb 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jjcoffee commented Feb 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

blazejkustra commented Feb 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jjcoffee commented Feb 23, 2024

Uh oh!

blazejkustra commented Feb 26, 2024

Uh oh!

Uh oh!

Uh oh!

jjcoffee commented Feb 26, 2024

Uh oh!

blazejkustra commented Feb 26, 2024

Uh oh!

jjcoffee commented Feb 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

blazejkustra commented Feb 27, 2024

Uh oh!

jjcoffee left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Feb 27, 2024

Uh oh!

situchan Feb 28, 2024

Choose a reason for hiding this comment

Uh oh!

hungvu193 Feb 29, 2024

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Feb 29, 2024

Uh oh!

OSBotify commented Feb 29, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

blazejkustra commented Feb 20, 2024 •

edited

Loading

blazejkustra Feb 20, 2024 •

edited

Loading

jjcoffee commented Feb 20, 2024 •

edited

Loading

blazejkustra commented Feb 20, 2024 •

edited

Loading

jjcoffee commented Feb 26, 2024 •

edited

Loading