Set default category for distance request by tienifr · Pull Request #34012 · Expensify/App

tienifr · 2024-01-05T09:19:51Z

Details

This PR retrieves and sets default category for distance request.

Fixed Issues

$ #33388
PROPOSAL: #33388 (comment)

Tests

In OD policy editor, go to Workspace >> Expenses >> Distance
Set a Default Distance Category

Navigate to the workspace chat in ND
Create a new distance request without an explicit category, follow the steps until the confirmation screen
Verify that the category field is set with the default category from step 2

Verify that no errors appear in the JS console

Offline tests

NA

QA Steps

In OD policy editor, go to Workspace >> Expenses >> Distance
Set a Default Distance Category

Navigate to the workspace chat in ND
Create a new distance request without an explicit category, follow the steps until the confirmation screen
Verify that the category field is set with the default category from step 2

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2024-01-05.at.16.20.37-compressed.mov

MacOS: Desktop

Screen.Recording.2024-01-05.at.16.20.37-compressed.mov

melvin-bot · 2024-01-08T02:06:06Z

@situchan Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

dylanexpensify · 2024-01-10T16:22:14Z

bump @situchan

situchan · 2024-01-18T16:44:16Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

mchrome.mov

iOS: Native

ios.mov

iOS: mWeb Safari

msafari.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

situchan · 2024-01-18T16:51:05Z

+        '',
+    );
+    useEffect(() => {
+        IOU.setMoneyRequestCategory_temporaryForRefactor(transactionID, defaultCategory);


This always resets category to default one while in money request flow.
This should be happen only when unset

Screen.Recording.2024-01-18.at.10.49.15.PM.mov

tienifr · 2024-01-22T19:05:46Z

@situchan This needs your re-approval.

dylanexpensify · 2024-01-26T11:51:31Z

bump @situchan

situchan · 2024-01-29T08:12:22Z

@dylanexpensify default category should be set only for distance request or for all requests including manual?

tienifr · 2024-02-01T07:49:13Z

@dylanexpensify Can you take a look at ^ ?

situchan · 2024-02-01T18:12:17Z

@tienifr after internal discussion, Default Distance Category should be applied to distance request only. So no need to set default category in other types of requests.
Please update code accordingly

situchan

OSBotify · 2024-02-07T10:09:09Z

🚀 Deployed to staging by https://github.com/yuwenmemon in version: 1.4.38-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-02-07T10:25:42Z

🚀 Deployed to staging by https://github.com/yuwenmemon in version: 1.4.38-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-02-08T18:21:00Z

🚀 Deployed to production by https://github.com/marcaaron in version: 1.4.38-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

aimane-chnaif · 2024-02-18T11:40:25Z

+            return;
+        }
+        IOU.setMoneyRequestCategory_temporaryForRefactor(transactionID, defaultCategory);
+    }, [transactionID, transaction.category, requestType, defaultCategory]);


Adding transaction.category as dependency here caused #36139.
So category was always reset to default on unselect.

tienifr added 2 commits January 5, 2024 16:13

set default category for distance request

4d9d193

use lodashGet instead

62f1fb1

tienifr marked this pull request as ready for review January 8, 2024 02:06

tienifr requested a review from a team as a code owner January 8, 2024 02:06

melvin-bot Bot requested review from situchan and removed request for a team January 8, 2024 02:06

tienifr mentioned this pull request Jan 8, 2024

[HOLD for payment 2024-02-15] [$500] New Distance Requests Should Default to the "Default Distance Category" #33388

Closed

6 tasks

dukenv0307 mentioned this pull request Jan 18, 2024

[$500] Default category set for distance expense in a policy does not auto populate when creating expense #34448

Closed

6 tasks

situchan reviewed Jan 18, 2024

View reviewed changes

tienifr added 4 commits January 19, 2024 01:16

Merge branch 'main' of https://github.com/tienifr/App into fix/33388

9eb8901

set default category only when unset

556b831

Merge branch 'main' of https://github.com/tienifr/App into fix/33388

663671a

fix lint

c7925f5

tienifr added 3 commits February 2, 2024 16:56

set default category for distance request only

1296790

Merge branch 'main' of https://github.com/tienifr/App into fix/33388

63d2dfc

fix lint

cbbc7a3

situchan approved these changes Feb 6, 2024

View reviewed changes

melvin-bot Bot requested a review from yuwenmemon February 6, 2024 07:13

yuwenmemon approved these changes Feb 6, 2024

View reviewed changes

yuwenmemon merged commit a068ac5 into Expensify:main Feb 6, 2024

github-actions Bot mentioned this pull request Feb 7, 2024

Deploy Checklist: New Expensify 2024-02-07 #35983

Closed

49 tasks

aimane-chnaif reviewed Feb 18, 2024

View reviewed changes

aimane-chnaif mentioned this pull request Feb 18, 2024

[C+ Checklist Needs Completion] [$500] Distance - Unable to unselect default category from confirmation page #36139

Closed

6 tasks

Uh oh!

Conversation

tienifr commented Jan 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jan 8, 2024

Uh oh!

dylanexpensify commented Jan 10, 2024

Uh oh!

situchan commented Jan 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

situchan Jan 18, 2024

Choose a reason for hiding this comment

Uh oh!

tienifr Jan 18, 2024

Choose a reason for hiding this comment

Uh oh!

tienifr commented Jan 22, 2024

Uh oh!

dylanexpensify commented Jan 26, 2024

Uh oh!

situchan commented Jan 29, 2024

Uh oh!

tienifr commented Feb 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

situchan commented Feb 1, 2024

Uh oh!

situchan left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Feb 7, 2024

Uh oh!

OSBotify commented Feb 7, 2024

Uh oh!

OSBotify commented Feb 8, 2024

Uh oh!

aimane-chnaif Feb 18, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

tienifr commented Jan 5, 2024 •

edited

Loading

situchan commented Jan 18, 2024 •

edited

Loading

tienifr commented Feb 1, 2024 •

edited

Loading