[HOLD for payment 2024-02-15] [$500] New Distance Requests Should Default to the "Default Distance Category"

[yuwenmemon]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v1.4.14-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): yuwen@expensify.com
Logs: N/A
Expensify/Expensify Issue URL: N/A
Issue reported by: @yuwenmemon
Slack conversation: https://expensify.slack.com/archives/C05DWUDHVK7/p1702928915733459

Action Performed:

Break down in numbered steps

1. In the OldDot policy editor, navigate to Workspace -> Expenses -> Distance
2. Set a Default Distance Category:

1(a). Alternatively, if you done have access to your Workspace in OldDot, set a default category for the distance unit via JS on OldDot:

const p = Policy.getByID('<workspace ID>');
p.policy.customUnits[0].defaultCategory = 'Advertising'; // check the index though
p.save();

3. As a submitter, Navigate to the Workspace Chat in NewDot
4. Create a new distance request without an explicit category. Follow the steps all the way until the confirmation step:
   

Expected Result:

The distance request should have the default category filled in by default

Actual Result:

The category field is blank

Workaround:

The default category will be set in the back end via https://github.com/Expensify/Auth/pull/9488, but we should still have this set for users in the front-end so the setting does not come as a suprise.

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Kapture.2023-12-20.at.16.03.24.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d091e9e76b7055e0
• Upwork Job ID: 1737625066164363264
• Last Price Increase: 2023-12-28

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01d091e9e76b7055e0

[melvin-bot]

Triggered auto assignment to @peterdbarkerUK (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The category field is blank

What is the root cause of that problem?

This is new feature.

What changes do you think we should make in order to solve the problem?

When creating distance request in the confirmation step

• Look for defaultCategory in the policy.customUnits data (find the customUnit that has name Distance similar to in here, and get it's defaultCategory)
• Prefill the category field with defaultCategory by setting in Onyx IOU/transaction data, we can do that in an useEffect

What alternative solutions did you explore? (Optional)

We can do the above right when initiating the distance request transaction rather than when reaching confirmation list.

[melvin-bot]

@yuwenmemon, @peterdbarkerUK, @situchan Eep! 4 days overdue now. Issues have feelings too...