Move location bias calculation to hook and use it on edit by aldo-expensify · Pull Request #33887 · Expensify/App

aldo-expensify · 2024-01-03T17:54:58Z

Details

Fixed Issues

$ #33877
PROPOSAL: #33877 (comment)

Tests

Create a workspace and go to your workspace expense chat
Create a distance request and allow the browser to give your location
Type an a in the first waypoint and confirm that the locations offered are biased by your real location
Choose two waypoints not too far from you and finish creating the distance request
Go to the distance request transaction and edit the "Distance" field
Edit the first waypoint and replace its content by an a
Verify that the suggested addresses are biased by your location
Open an incognito window and login in the same account
Create a distance request and this time DON'T allow the browser to give your location
Type an a in the first waypoint and confirm that the locations offered are not biased by your real location and that the page doesn't crash
Choose two waypoints not too far from you and finish creating the distance request
Go to the distance request transaction and edit the "Distance" field
Edit the first waypoint and replace its content by an a
Verify that the suggested addresses are biased by the locations you chose previously

Verify that no errors appear in the JS console

Offline tests

QA Steps

Create a workspace and go to your workspace expense chat
Create a distance request and allow the browser to give your location
Type an a in the first waypoint and confirm that the locations offered are biased by your real location
Choose two waypoints not too far from you and finish creating the distance request
Go to the distance request transaction and edit the "Distance" field
Edit the first waypoint and replace its content by an a
Verify that the suggested addresses are biased by your location
Open an incognito window and login in the same account
Create a distance request and this time DON'T allow the browser to give your location
Type an a in the first waypoint and confirm that the locations offered are not biased by your real location and that the page doesn't crash
Choose two waypoints not too far from you and finish creating the distance request
Go to the distance request transaction and edit the "Distance" field
Edit the first waypoint and replace its content by an a
Verify that the suggested addresses are biased by the locations you chose previously

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2024-01-03.at.3.04.05.PM.mov

MacOS: Desktop

melvin-bot · 2024-01-03T17:55:03Z

@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

aldo-expensify · 2024-01-03T18:05:19Z

@mananjadhav are you around to review this?

allroundexperts · 2024-01-03T18:11:14Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-01-04.at.12.44.23.AM.mov

Android: mWeb Chrome

Screen.Recording.2024-01-04.at.12.15.39.AM.mov

iOS: Native

Screen.Recording.2024-01-04.at.12.12.49.AM.mov

iOS: mWeb Safari

Screen.Recording.2024-01-03.at.11.55.55.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-01-03.at.11.48.05.PM.mp4

MacOS: Desktop

Screen.Recording.2024-01-03.at.11.53.00.PM.mov

allroundexperts · 2024-01-03T19:25:52Z

Probably not related to this PR, but the iOS app is crashing once I open the newly created distance request:

Screen.Recording.2024-01-04.at.12.24.20.AM.mov

aldo-expensify · 2024-01-03T19:32:27Z

Probably not related to this PR, but the iOS app is crashing once I open the newly created distance request:

Hmm, looks unrelated by looking at the crash line. Maybe we should still confirm if the crash happens in main.

allroundexperts · 2024-01-03T19:48:56Z

Happens on main as well!

allroundexperts

Looks good!

melvin-bot · 2024-01-03T19:49:52Z

@yuwenmemon Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

aldo-expensify · 2024-01-03T19:53:14Z

Happens on main as well!

Thanks for confirming and for the quick review!

OSBotify · 2024-01-03T22:06:12Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

…-edit Move location bias calculation to hook and use it on edit (cherry picked from commit 1037c94)

OSBotify · 2024-01-04T00:03:54Z

🚀 Cherry-picked to staging by https://github.com/marcaaron in version: 1.4.21-3 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2024-01-04T01:17:01Z

🚀 Cherry-picked to staging by https://github.com/marcaaron in version: 1.4.21-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2024-01-04T01:44:16Z

🚀 Cherry-picked to staging by https://github.com/marcaaron in version: 1.4.21-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

aldo-expensify · 2024-01-04T03:10:16Z

QA pass

Screen.Recording.2024-01-04.at.12.04.19.AM.mov

OSBotify · 2024-01-04T18:55:40Z

🚀 Deployed to production by https://github.com/marcaaron in version: 1.4.21-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2024-01-04T19:20:30Z

🚀 Deployed to production by https://github.com/marcaaron in version: 1.4.21-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2024-01-04T20:17:57Z

🚀 Deployed to production by https://github.com/marcaaron in version: 1.4.21-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

Move location bias calculation to hook and use it on edit

d4ef6ca

aldo-expensify self-assigned this Jan 3, 2024

aldo-expensify requested a review from a team as a code owner January 3, 2024 17:54

melvin-bot Bot requested review from mananjadhav and removed request for a team January 3, 2024 17:55

Remove console.log

b36f281

Style

9985659

aldo-expensify requested review from allroundexperts and removed request for mananjadhav January 3, 2024 18:10

allroundexperts approved these changes Jan 3, 2024

View reviewed changes

melvin-bot Bot requested a review from yuwenmemon January 3, 2024 19:49

yuwenmemon approved these changes Jan 3, 2024

View reviewed changes

aldo-expensify merged commit 1037c94 into main Jan 3, 2024

aldo-expensify deleted the aldo_enable-location-bias-on-edit branch January 3, 2024 22:01

OSBotify pushed a commit that referenced this pull request Jan 3, 2024

Merge pull request #33887 from Expensify/aldo_enable-location-bias-on…

741f3ff

…-edit Move location bias calculation to hook and use it on edit (cherry picked from commit 1037c94)

github-actions Bot mentioned this pull request Jan 3, 2024

Deploy Checklist: New Expensify 2024-01-02 #33855

Closed

58 tasks

aldo-expensify mentioned this pull request Jan 4, 2024

[HOLD for payment 2024-01-11] Distance - Location search results in distance request editor are not location-biased #33877

Closed

6 tasks

kbecciv mentioned this pull request Jan 4, 2024

Distance - Countries, which begin with entered letter are displayed next to suggested places #33941

Closed

6 tasks

Uh oh!

Conversation

aldo-expensify commented Jan 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jan 3, 2024

Uh oh!

aldo-expensify commented Jan 3, 2024

Uh oh!

allroundexperts commented Jan 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

allroundexperts commented Jan 3, 2024

Uh oh!

aldo-expensify commented Jan 3, 2024

Uh oh!

allroundexperts commented Jan 3, 2024

Uh oh!

allroundexperts left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented Jan 3, 2024

Uh oh!

aldo-expensify commented Jan 3, 2024

Uh oh!

OSBotify commented Jan 3, 2024

Uh oh!

OSBotify commented Jan 4, 2024

Uh oh!

OSBotify commented Jan 4, 2024

Uh oh!

OSBotify commented Jan 4, 2024

Uh oh!

aldo-expensify commented Jan 4, 2024

Uh oh!

OSBotify commented Jan 4, 2024

Uh oh!

OSBotify commented Jan 4, 2024

Uh oh!

OSBotify commented Jan 4, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

aldo-expensify commented Jan 3, 2024 •

edited

Loading

allroundexperts commented Jan 3, 2024 •

edited

Loading