[HOLD for payment 2024-01-11] Distance - Location search results in distance request editor are not location-biased

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.21-1
Reproducible in staging?: y
Reproducible in production?: new feature
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #33334

Action Performed:

1. Go to workspace chat > + > Request money > Distance.
2. Enter Start, Finish and Stop addresses.
3. Note that the search results show the locations close to the user location or the selected address.
4. Create the distance request.
5. Go to distance request page.
6. Click Distance.
7. Click any waypoint and enter any location.

Expected Result:

The search results are location-biased (it does not show location close to the selected address).

Actual Result:

The search results are not location-biased. It shows the results from the US.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6331395_1704296437333.bandicam_2024-01-03_20-19-04-689.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @allroundexperts

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @aldo-expensify (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[paultsimura]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When editing waypoints, the search results are not location-biased.

What is the root cause of that problem?

When creating a new request, we pass the locationBias parameter to the AddressSearch:

App/src/pages/iou/request/step/IOURequestStepWaypoint.js

Lines 284 to 309 in b8b675d

	<InputWrapperWithRef
	InputComponent={AddressSearch}
	locationBias={locationBias}
	canUseCurrentLocation
	inputID={`waypoint${pageIndex}`}
	ref={(e) => (textInput.current = e)}
	hint={!isOffline ? 'distance.errors.selectSuggestedAddress' : ''}
	containerStyles={[styles.mt4]}
	label={translate('distance.address')}
	defaultValue={waypointAddress}
	onPress={selectWaypoint}
	maxInputLength={CONST.FORM_CHARACTER_LIMIT}
	renamedInputKeys={{
	address: `waypoint${pageIndex}`,
	city: null,
	country: null,
	street: null,
	street2: null,
	zipCode: null,
	lat: null,
	lng: null,
	state: null,
	}}
	predefinedPlaces={recentWaypoints}
	resultTypes=""
	/>

But when editing, we do not:

App/src/pages/iou/WaypointEditor.js

Lines 222 to 246 in fd71747

	<InputWrapper
	InputComponent={AddressSearch}
	canUseCurrentLocation
	inputID={`waypoint${waypointIndex}`}
	ref={(e) => (textInput.current = e)}
	hint={!isOffline ? 'distance.errors.selectSuggestedAddress' : ''}
	containerStyles={[styles.mt3]}
	label={translate('distance.address')}
	defaultValue={waypointAddress}
	onPress={selectWaypoint}
	maxInputLength={CONST.FORM_CHARACTER_LIMIT}
	renamedInputKeys={{
	address: `waypoint${waypointIndex}`,
	city: null,
	country: null,
	street: null,
	street2: null,
	zipCode: null,
	lat: null,
	lng: null,
	state: null,
	}}
	predefinedPlaces={recentWaypoints}
	resultTypes=""
	/>

This was probably missed in the #33334 that added this new feature.

What changes do you think we should make in order to solve the problem?

We should build and pass the locationBias on the WaypointEditor page as well.

What alternative solutions did you explore? (Optional)

[aldo-expensify]

Thanks @paultsimura I think you are right, testing...