Update all selectors to use new format for selected participant by dukenv0307 · Pull Request #31648 · Expensify/App

dukenv0307 · 2023-11-21T17:07:54Z

Details

Update all selectors to use a new format for selected participant

Fixed Issues

$ #29916
PROPOSAL: #29916 (comment)

Tests

Go to a room/WS and open the Memember page
Click Invite and choose some users
Verify that you see them at the top
Start searching for a user and verify the selected participants are gone
Search for a user that you have selected and verify they show up in the search results

Verify that no errors appear in the JS console

Offline tests

QA Steps

Go to a room/WS and open the Memember page
Click Invite and choose some users
Verify that you see them at the top
Start searching for a user and verify the selected participants are gone
Search for a user that you have selected and verify they show up in the search results

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android-resize.mov

Android: mWeb Chrome

chrome-resize.mov

iOS: Native

ios-resize.mov

iOS: mWeb Safari

safari-resize.mov

MacOS: Chrome / Safari

web-resize.mov

MacOS: Desktop

desktop-resize.mov

melvin-bot · 2023-11-22T09:16:14Z

@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

abdulrahuman5196 · 2023-11-24T09:52:35Z

@dukenv0307 selected options are not listing even if it matches the search term. Kindly check on this.

Screen.Recording.2023-11-24.at.3.20.14.PM.mov

abdulrahuman5196 · 2023-11-28T19:05:07Z

@dukenv0307 Any update on the above?

dukenv0307 · 2023-11-29T07:55:37Z

@abdulrahuman5196 Sorry for the delay, I don't know how I missed noti for this, checking on this now

dukenv0307 · 2023-11-30T09:07:55Z

@abdulrahuman5196 A question here: If we search for a new user which will be userInvite option and select it and then we just enter a part of login of new account which was selected before. Should we display it or not?

abdulrahuman5196 · 2023-12-04T19:12:13Z

@abdulrahuman5196 A question here: If we search for a new user which will be userInvite option and select it and then we just enter a part of login of new account which was selected before. Should we display it or not?

Hi @dukenv0307
From usecase perspective. When searching a email, regardless of email being selected or not, we should show it. Similar to group creation logic from start chat page.

abdulrahuman5196 · 2023-12-07T11:48:35Z

@dukenv0307 Ping on the above? Could you kindly fix and let me know once the PR is ready for review.

dukenv0307 · 2023-12-07T13:57:45Z

@abdulrahuman5196 The logic for getting the participants section is updated by the Internal team and it differs from the logic when I submit the proposal
Therefore, I need a little more time to code new logic.
Pushing new working code as soon as possible
Thanks for your patience

dukenv0307 · 2023-12-12T09:07:05Z

@abdulrahuman5196

selected options are not listing even if it matches the search term

The code was updated to fix the above issue. Kindly review it again.
Thanks for your time

abdulrahuman5196 · 2023-12-12T17:37:14Z

Sure. Let me check in my morning.

dukenv0307 · 2023-12-18T07:11:05Z

@abdulrahuman5196 Friendly bump. Please help review this PR again

abdulrahuman5196 · 2023-12-18T07:55:23Z

Hi, Sorry for the delay will review today.

abdulrahuman5196 · 2023-12-19T08:46:49Z

reviewing now

abdulrahuman5196 · 2023-12-19T08:59:38Z

        const sections = [];
        let indexOffset = 0;

+        // Filter all options that is a part of the search term or in the personal details


This filter should only happen when we have searchTerm.
For reference: https://github.com/Expensify/App/blob/main/src/libs/OptionsListUtils.js#L1697

@abdulrahuman5196
if we do not have searchTerm, then we gonna show the list of options from personalDetailsList, so I think this logic is correct.
Let me know if any concerns

The point you made is correct. But what I am suggesting is an optimization. Like when there is no searchTerm, we will always get the whole list. So it becomes a wasteful search(Correct me if wrong).
So we can filter only when we have a searchTerm,
like the below pseudo code

const filterSelectedOptions = selectedOptions if searchTerm != '' { filterSelectedOptions = filter() }

@dukenv0307

abdulrahuman5196 · 2023-12-19T08:59:47Z

        const sections = [];
        let indexOffset = 0;

+        // Filter all options that is a part of the search term or in the personal details


Same as the above

abdulrahuman5196

@dukenv0307 Kindly check on the requested changes

dukenv0307 · 2023-12-27T08:04:54Z

@abdulrahuman5196 Updated.

abdulrahuman5196 · 2023-12-28T16:35:14Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2023-12-28.at.9.15.20.PM.mp4

Android: mWeb Chrome

Screen.Recording.2023-12-28.at.9.19.44.PM.mp4

iOS: Native

Screen.Recording.2023-12-28.at.8.59.54.PM.mp4

iOS: mWeb Safari

Screen.Recording.2023-12-28.at.9.06.56.PM.mp4

MacOS: Chrome / Safari

Screen.Recording.2023-12-28.at.8.12.27.PM.mp4

MacOS: Desktop

Screen.Recording.2023-12-28.at.8.56.32.PM.mp4

abdulrahuman5196

Changes looks good and works well. Reviewers checklist is also complete.

All yours. @thienlnam

🎀 👀 🎀
C+ Reviewed

thienlnam

Great - thanks!

OSBotify · 2024-01-02T19:34:54Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-01-02T23:51:01Z

🚀 Deployed to staging by https://github.com/thienlnam in version: 1.4.21-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-01-04T18:53:37Z

🚀 Deployed to production by https://github.com/marcaaron in version: 1.4.21-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2024-01-04T19:18:27Z

🚀 Deployed to production by https://github.com/marcaaron in version: 1.4.21-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2024-01-04T20:15:54Z

🚀 Deployed to production by https://github.com/marcaaron in version: 1.4.21-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

Update all selectors to use new format for selected participant

4810696

dukenv0307 marked this pull request as ready for review November 22, 2023 09:16

dukenv0307 requested a review from a team as a code owner November 22, 2023 09:16

melvin-bot Bot requested review from abdulrahuman5196 and removed request for a team November 22, 2023 09:16

fix bug when search for selected options

76cd677

abdulrahuman5196 reviewed Dec 19, 2023

View reviewed changes

abdulrahuman5196 suggested changes Dec 19, 2023

View reviewed changes

dukenv0307 added 2 commits December 27, 2023 14:55

Merge branch 'main' into fix/29916

db34944

optimize filter

22e80a4

abdulrahuman5196 approved these changes Dec 28, 2023

View reviewed changes

melvin-bot Bot requested a review from thienlnam December 28, 2023 16:37

thienlnam approved these changes Jan 2, 2024

View reviewed changes

thienlnam merged commit e822ee5 into Expensify:main Jan 2, 2024

github-actions Bot mentioned this pull request Jan 2, 2024

Deploy Checklist: New Expensify 2024-01-02 #33855

Closed

58 tasks

melvin-bot Bot mentioned this pull request Jan 4, 2024

[HOLD for payment 2024-01-11] [$500] Update all selectors to use new format for selected participant #29916

Closed

paultsimura mentioned this pull request Jan 5, 2024

[HOLD for payment 2024-01-22] [$500] Workspace - In Workspace, trying to add a number contact & selecting it, contact disappears #34020

Closed

6 tasks

Pujan92 mentioned this pull request Feb 21, 2024

Workspace - E-mail address with space disappears when invite to Workspace #36958

Closed

6 tasks

Uh oh!

Conversation

dukenv0307 commented Nov 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Nov 22, 2023

Uh oh!

abdulrahuman5196 commented Nov 24, 2023

Uh oh!

abdulrahuman5196 commented Nov 28, 2023

Uh oh!

dukenv0307 commented Nov 29, 2023

Uh oh!

dukenv0307 commented Nov 30, 2023

Uh oh!

abdulrahuman5196 commented Dec 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

abdulrahuman5196 commented Dec 7, 2023

Uh oh!

dukenv0307 commented Dec 7, 2023

Uh oh!

dukenv0307 commented Dec 12, 2023

Uh oh!

abdulrahuman5196 commented Dec 12, 2023

Uh oh!

dukenv0307 commented Dec 18, 2023

Uh oh!

abdulrahuman5196 commented Dec 18, 2023

Uh oh!

abdulrahuman5196 commented Dec 19, 2023

Uh oh!

abdulrahuman5196 Dec 19, 2023

Choose a reason for hiding this comment

Uh oh!

dukenv0307 Dec 21, 2023

Choose a reason for hiding this comment

Uh oh!

abdulrahuman5196 Dec 26, 2023

Choose a reason for hiding this comment

Uh oh!

abdulrahuman5196 Dec 19, 2023

Choose a reason for hiding this comment

Uh oh!

abdulrahuman5196 left a comment

Choose a reason for hiding this comment

Uh oh!

dukenv0307 commented Dec 27, 2023

Uh oh!

abdulrahuman5196 commented Dec 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

abdulrahuman5196 left a comment

Choose a reason for hiding this comment

Uh oh!

thienlnam left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Jan 2, 2024

Uh oh!

OSBotify commented Jan 2, 2024

Uh oh!

OSBotify commented Jan 4, 2024

Uh oh!

OSBotify commented Jan 4, 2024

Uh oh!

OSBotify commented Jan 4, 2024

Uh oh!

Reviewers

Assignees

Labels

dukenv0307 commented Nov 21, 2023 •

edited

Loading

abdulrahuman5196 commented Dec 4, 2023 •

edited

Loading

abdulrahuman5196 commented Dec 28, 2023 •

edited

Loading