Remove error when all workspace is deleted by dukenv0307 · Pull Request #29781 · Expensify/App

dukenv0307 · 2023-10-17T14:31:36Z

Details

Remove error when all workspace is deleted

Fixed Issues

$ #29235
PROPOSAL: #29235 (comment)

Tests

Create a new workspace
Go to the workspace > Bank account
Fill in step 1 and 2 details
In step 3, fill in details and add any character in first name eg: 'test%%' (note that we are just doing this to trigger server error, it is not compulsory to trigger error only by this method)
Click on Save & Continue and notice that the error appears and the red dot appears on avatar
Close the tab and open app again
Go to Settings> Workspace
Delete all workspace
Verify that the red dot disappears

Verify that no errors appear in the JS console

Offline tests

Pre-condition: The red dot appears on the avatar that comes from ReimbursementAccount errror

Go offline
Go to Settings> Workspace
Delete all workspace
Verify that the red dot disappears

QA Steps

Create a new workspace
Go to the workspace > Bank account
Fill in step 1 and 2 details
In step 3, fill in details and add any character in first name eg: 'test%%' (note that we are just doing this to trigger server error, it is not compulsory to trigger error only by this method)
Click on Save & Continue and notice that the error appears and the red dot appears on avatar
Close the tab and open app again
Go to Settings> Workspace
Delete all workspace
Verify that the red dot disappears

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

29235.mp4

Android: mWeb Chrome

Record_2023-10-17-21-23-51.mp4

iOS: Native

Screen.Recording.2023-10-17.at.21.39.52.mov

iOS: mWeb Safari

Screen.Recording.2023-10-17.at.21.36.00.mov

MacOS: Chrome / Safari

Screencast.from.17-10-2023.21.17.01.webm

MacOS: Desktop

Screen.Recording.2023-10-17.at.21.45.47.mov

melvin-bot · 2023-10-17T14:52:20Z

@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

hoangzinh · 2023-10-18T11:01:09Z

+        {
+            onyxMethod: Onyx.METHOD.MERGE,
+            key: ONYXKEYS.REIMBURSEMENT_ACCOUNT,
+            value: oldReimbursementAccount,


I think we should restore the errors value only.

hoangzinh · 2023-10-18T11:03:09Z

 * @param {String} policyName
 */
 function deleteWorkspace(policyID, reports, policyName) {
+    const filteredPolicies = _.filter(allPolicies, (policy) => policy.id !== policyID);


please use lodash instead of underscore for the new code.

hoangzinh · 2023-10-18T11:05:48Z

 */
 function deleteWorkspace(policyID, reports, policyName) {
+    const filteredPolicies = _.filter(allPolicies, (policy) => policy.id !== policyID);
+    const hasActivePolicy = hasActiveFreePolicy(filteredPolicies);


If this var is only used 1 place, we can call it directly in the place it used to avoid headaches in naming

dukenv0307 · 2023-10-20T05:21:45Z

@hoangzinh Updated all your suggestions.

hoangzinh · 2023-10-20T11:05:30Z

hey @dukenv0307 do you have the same experience as me? the bank account's error is automatically cleared when RHN is closed.

Screen.Recording.2023-10-20.at.18.03.33.mov

dukenv0307 · 2023-10-20T11:06:45Z

@hoangzinh Yes, we should close the app and open it again to keep the error.

hoangzinh · 2023-10-20T11:07:03Z

 */
 function deleteWorkspace(policyID, reports, policyName) {
+    const filteredPolicies = filter(allPolicies, (policy) => policy.id !== policyID);
+    const oldReimbursementAccount = reimbursementAccount;


do we need to assign to a temporary var oldReimbursementAccount here?

I think we need it to store the old value. The current value can be changed after the optimisticData is merged in Onyx.

yeah, but we already built failureData below, so I think we don't need to cache the oldReimbursementAccount here. Could you help to verify it again? Don't hesitate to let me know if I'm wrong

Yes, you're right. Updated.

hoangzinh · 2023-10-20T12:53:09Z

@hoangzinh Yes, we should close the app and open it again to keep the error.

In the recording of GH issue #29235, we don't need to close the app and open it again. I think there is a recent bug/change related to this bank account form.

hoangzinh · 2023-10-23T09:58:23Z

@dukenv0307 I think it's related to this issue. Discussing in this issue #27901 (comment)

hoangzinh · 2023-11-02T09:19:59Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2023-11-02.at.22.58.45.-.android.mov

Android: mWeb Chrome

Screen.Recording.2023-11-02.at.22.53.18.-.android.chrome.mov

iOS: Native

Screen.Recording.2023-11-02.at.22.41.00.-.ios.mov

iOS: mWeb Safari

Screen.Recording.2023-11-02.at.22.33.33.-.ios.safari.mov

MacOS: Chrome / Safari

Screen.Recording.2023-11-02.at.16.41.21.-.web.mov

MacOS: Desktop

Screen.Recording.2023-11-02.at.16.44.44.-.desktop.mov

hoangzinh · 2023-11-02T09:47:40Z

@dukenv0307 because it's related to optimistic Data, I think we should include Offline test, what do you think?

hoangzinh · 2023-11-02T09:48:06Z

@dukenv0307 also please resolve conflict

dukenv0307 · 2023-11-02T09:52:12Z

@hoangzinh Because the test need to complete bank account flow, I think we need online.

hoangzinh · 2023-11-02T09:53:56Z

I think bank account is just setup steps. The main of test step is Go to Setting -> WS -> Delete a WS in offline.

dukenv0307 · 2023-11-02T09:55:44Z

OK let me add the offline step with pre condition.

hoangzinh · 2023-11-02T23:24:11Z

@dukenv0307 let me know when your PR is updated and ready for review

dukenv0307 · 2023-11-03T01:15:58Z

I updated.

hoangzinh

@dukenv0307 Thanks for update. LGTM

luacmartins

LGMT! I think we should clean up all the underscore and lodash imports in this file in a follow up

OSBotify · 2023-11-03T15:43:07Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-11-06T22:32:22Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.3.96-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-11-09T22:49:55Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.96-15 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-11-10T15:46:36Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.97-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

remove error when all workspace is deleted

d36a762

dukenv0307 marked this pull request as ready for review October 17, 2023 14:52

dukenv0307 requested a review from a team as a code owner October 17, 2023 14:52

melvin-bot Bot requested review from hoangzinh and removed request for a team October 17, 2023 14:52

hoangzinh reviewed Oct 18, 2023

View reviewed changes

dukenv0307 added 2 commits October 20, 2023 12:20

using lodash instead of underscore

1dff6dd

Merge branch 'main' into fix/29235

165308b

hoangzinh reviewed Oct 20, 2023

View reviewed changes

remove un-use variable

b8a97da

hoangzinh mentioned this pull request Oct 25, 2023

[HOLD for payment 2023-11-18] [$500] Deleting all workspaces does not remove red dot #29235

Closed

6 tasks

dukenv0307 added 2 commits November 2, 2023 16:57

merge main

9f606ed

fix lint

9b24175

hoangzinh approved these changes Nov 3, 2023

View reviewed changes

melvin-bot Bot requested a review from luacmartins November 3, 2023 05:11

luacmartins approved these changes Nov 3, 2023

View reviewed changes

luacmartins merged commit 509d352 into Expensify:main Nov 3, 2023

OSBotify mentioned this pull request Nov 6, 2023

Deploy Checklist: New Expensify 2023-11-06 #30929

Closed

OSBotify mentioned this pull request Nov 8, 2023

Deploy Checklist: New Expensify 2023-11-08 #31077

Closed

Conversation

dukenv0307 commented Oct 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Oct 17, 2023

Uh oh!

hoangzinh Oct 18, 2023

Choose a reason for hiding this comment

Uh oh!

hoangzinh Oct 18, 2023

Choose a reason for hiding this comment

Uh oh!

hoangzinh Oct 18, 2023

Choose a reason for hiding this comment

Uh oh!

dukenv0307 commented Oct 20, 2023

Uh oh!

hoangzinh commented Oct 20, 2023

Uh oh!

dukenv0307 commented Oct 20, 2023

Uh oh!

hoangzinh Oct 20, 2023

Choose a reason for hiding this comment

Uh oh!

dukenv0307 Oct 20, 2023

Choose a reason for hiding this comment

Uh oh!

hoangzinh Oct 20, 2023

Choose a reason for hiding this comment

Uh oh!

dukenv0307 Oct 24, 2023

Choose a reason for hiding this comment

Uh oh!

hoangzinh commented Oct 20, 2023

Uh oh!

hoangzinh commented Oct 23, 2023

Uh oh!

hoangzinh commented Nov 2, 2023 • edited by luacmartins Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

hoangzinh commented Nov 2, 2023

Uh oh!

hoangzinh commented Nov 2, 2023

Uh oh!

dukenv0307 commented Nov 2, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hoangzinh commented Nov 2, 2023

Uh oh!

dukenv0307 commented Nov 2, 2023

Uh oh!

hoangzinh commented Nov 2, 2023

Uh oh!

dukenv0307 commented Nov 3, 2023

Uh oh!

hoangzinh left a comment

Choose a reason for hiding this comment

Uh oh!

luacmartins left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Nov 3, 2023

Uh oh!

OSBotify commented Nov 6, 2023

Uh oh!

OSBotify commented Nov 9, 2023

Uh oh!

OSBotify commented Nov 10, 2023

Uh oh!

Reviewers

Assignees

dukenv0307 commented Oct 17, 2023 •

edited

Loading

hoangzinh commented Nov 2, 2023 •

edited by luacmartins

Loading

dukenv0307 commented Nov 2, 2023 •

edited

Loading