[HOLD for payment 2023-11-18] [$500] Deleting all workspaces does not remove red dot

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.80-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1696933257327709

Action Performed:

1. Open the app
2. Open settings->workspaces->any workspace->bank account->connect manually
3. Fill in step 1 and 2 details
4. In step 3, fill in details and add any character in first name eg: 'test%%' (note that we are just doing this to trigger server error, it is not compulsory to trigger error only by this method)
5. Click on Save & Continue and notice that it will trigger server side error
6. Exit back to home page
7. Click on settings->workspaces and delete all workspaces one by one
8. Observe that even after deleting all workspaces, red dot is displayed on profile and besides workspaces in settings

Expected Result:

App should remove red dot of workspace error if we delete all the workspaces

Actual Result:

App displays red dot of workspace error even after we delete all the workspaces, it removes the red dot on relogin

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

android.chrome.red.dot.error.not.removed.after.workspace.delete.mp4

iOS: Native

iOS: mWeb Safari

ios.safari.red.dot.not.removed.after.workspace.delete.mov

MacOS: Chrome / Safari

mac.chrome.red.dot.not.dismissed.even.on.all.workspace.delete.mov

Red.dot.mp4

MacOS: Desktop

mac.desktop.red.dot.not.dismissed.even.on.all.workspace.delete.mov

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~013278e8038908746f
• Upwork Job ID: 1711854514958786560
• Last Price Increase: 2023-10-10
• Automatic offers:
• hoangzinh | Reviewer | 27222500
• dukenv0307 | Contributor | 27222503
• dhanashree-sawant | Reporter | 27222505

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~013278e8038908746f

[melvin-bot]

Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)

[abzokhattab]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Deleting all workpsaces doesnt remove the red dot from the avatar and the settings workpsace tap

What is the root cause of that problem?

in this line we dont check if the current admin policies are empty or beside the reimbursementAccount.errors check

App/src/pages/settings/InitialSettingsPage.js

Lines 180 to 181 in 7f7b424

	const policyBrickRoadIndicator =
	!_.isEmpty(props.reimbursementAccount.errors) ||

same for the avatar indicator

App/src/components/Indicator.js

Line 82 in 0cbee22

() => !_.isEmpty(props.reimbursementAccount.errors),

What changes do you think we should make in order to solve the problem?

Get the admin typed workspaces and check if they are empty or not beside reimbursementAccount.errors check

        const adminPolicies = _.chain(props.policies)
            .filter((policy) => policy && policy.type === CONST.POLICY.TYPE.FREE && policy.role === CONST.POLICY.ROLE.ADMIN)
            .value();

change the check to:

            (!_.isEmpty(props.reimbursementAccount.errors) && !_.isEmpty(adminPolicies)) ||

also in the indicator component we do the same ..

    const adminPolicies = _.chain(cleanPolicies)
        .filter((policy) => policy && policy.type === CONST.POLICY.TYPE.FREE && policy.role === CONST.POLICY.ROLE.ADMIN)
        .value();

        () => !_.isEmpty(adminPolicies) && !_.isEmpty(props.reimbursementAccount.errors),

POC

Screen.Recording.2023-10-11.at.1.30.13.AM.mov

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App displays red dot of workspace error even after we delete all the workspaces, it removes the red dot on relogin

What is the root cause of that problem?

We're not clearing the errors from the reimbursementAccount after all workspaces are deleted.

So the red dot will still show in the "Workspaces" in settings in this condition and still show in user avatar in this condition

The reimbursementAccount 's sole purpose is for the workspaces so we shouldn't retain red dot error for reimbursement account if we don't have any workspace.

What changes do you think we should make in order to solve the problem?

In deleteWorkspace, if that's the only workspace left, we should clear the errors of the reimbursementAccount in Onyx in optimisticData (or we should clear all data in reimbursementAccount if that's also OK), and restore it in failureData. Since reimbursement account is related to workspace and it doesn't make sense to keep its errors (and data) after all workspaces are deleted.

What alternative solutions did you explore? (Optional)

NA

[abzokhattab]

forgot to mention that by making those changes, whenever we create a new workspace again after we delete all of them, the red dot will be back again, which i think is the expected behavior.

[dukenv0307]

Just IMO I'd be quite surprised if an error comes out of nowhere once I create a new workspace 😄