26558-App crashes while using distance feature by pradeepmdk · Pull Request #26622 · Expensify/App

pradeepmdk · 2023-09-03T20:10:16Z

Details

Fixed Issues

$ #26558
PROPOSAL: #26558 (comment)

Tests

Launch app

Turn off mobile data
Tap fab
Tap Request money
Tap Distance
Enter Start address and save
Enter Finish address and save ([make sure you hit save]
Turn on mobile data

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-09-04.at.1.31.54.AM.mov

Mobile Web - Chrome

WhatsApp.Video.2023-09-04.at.1.35.01.AM.mp4

Mobile Web - Safari

WhatsApp.Video.2023-09-04.at.1.35.01.AM.mp4

Desktop

Screen.Recording.2023-09-04.at.1.31.54.AM.mov

iOS

Screen.Recording.2023-09-04.at.1.38.02.AM.mov

Android

Record_2023-09-04-01-28-21.mp4

melvin-bot · 2023-09-03T20:10:21Z

@fedirjh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

fedirjh · 2023-09-03T21:28:32Z

cc @hayata-suenaga The code in this PR will give the possibility to select an invalid waypoint, Is that fine?

The create request will fails :

pradeepmdk · 2023-09-03T21:36:50Z

cc @hayata-suenaga The code in this PR will give the possibility to select an invalid waypoint, Is that fine?

The create request will fails :

in this code i am just ignoring the MarkerComponent when doesn't have the lat and lng

pradeepmdk · 2023-09-03T21:45:20Z

@fedirjh

The create request will fails :

the given address don't have the route so that its throwing the error. because when you are offline lat and lang will be fetch from backend. if no route found means it will throw the error when you come back online.

fedirjh · 2023-09-03T22:00:12Z

In this code i am just ignoring the MarkerComponent when doesn't have the lat and LNG

Aha that means we allow invalid points to be chosen online.

if no route found means it will throw the error when you come back online.

@pradeepmdk The issue is that when we create a request offline we can select any invalid point, when we go back online, we don't validate the route before creating the request (there is no call to GetRoute command) -> the backend will validate the request and throw that error after crating the request.

If you select an invalid route online it will throw an error before the creation, check the above images :

pradeepmdk · 2023-09-03T22:09:55Z

Aha that means we allow invalid points to be chosen online.

in native when coordinate: [waypoint.lng, waypoint.lat], have null so app is broken. so that we are ignore the marker here.

pradeepmdk · 2023-09-03T22:21:34Z

@fedirjh i am not understanding correctly

The issue is that when we create a request offline we can select any invalid point, when we go back online, we don't validate the route before creating the request (there is no call to GetRoute command) -> the backend will validate the request and throw that error after creating the request.

here I am not doing any validation just preventing crashes in native devices. on the web, we don't have any crashes.in native devices because of null its crashed.

so my changes doesn't any modification on the validation part

pradeepmdk · 2023-09-03T23:09:27Z

@fedirjh

there is no call to GetRoute command when offline to online

for this we have sepreate issue #26596

pradeepmdk · 2023-09-03T23:11:58Z

@fedirjh if we want fix this here let me know i already have the proposal for that as well.#26596 (comment)

fedirjh · 2023-09-03T23:31:55Z

for this we have sepreate issue #26596

Ok that sounds good

i am not understanding correctly

In online, when you try to select a non-existing searched result it will display this error :

However, In offline mode, it just selects any invalid search result and this is not consistent with the online behavior

For example:

If you search for null in online mode, -> it will display this error Please select a suggested address
If you search for null in offline mode -> it will select the invalid text -> No error is displayed

fedirjh · 2023-09-03T23:50:34Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

CleanShot.2023-09-03.at.22.21.03.mp4

Mobile Web - Chrome

CleanShot.2023-09-04.at.00.32.23.mp4

Mobile Web - Safari

CleanShot.2023-09-03.at.22.15.45.mp4

Desktop

CleanShot.2023-09-03.at.22.36.41.mp4

iOS

CleanShot.2023-09-03.at.22.11.20.mp4

Android

CleanShot.2023-09-03.at.23.13.27.mp4

fedirjh · 2023-09-03T23:52:59Z

@pradeepmdk can you update the typo in testing step , it's mobile data

Turn off mobile date

fedirjh · 2023-09-03T23:57:17Z

Since this PR fixes a crash and a deploy blocker I won't block it for this inconsistent behaviour . Let's make sure to handle it in this issue #26596 .

hayata-suenaga · 2023-09-04T04:03:56Z

This is the only item on the @fedirjh's checklist that hasn't been checked. All other items are checked, and screenshot/recordings are uploaded for all platforms. I'll assume @fedirjh forgot to check this off, and I'll check this off for them so that the PR can be merged.

OSBotify · 2023-09-04T04:09:55Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-09-04T16:50:01Z

🚀 Deployed to staging by https://github.com/hayata-suenaga in version: 1.3.63-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-09-05T18:42:36Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.63-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-09-05T19:13:02Z

🚀 Deployed to staging by https://github.com/hayata-suenaga in version: 1.3.64-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-09-06T18:55:37Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.64-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

update type safty

59b6e51

pradeepmdk requested a review from a team as a code owner September 3, 2023 20:10

melvin-bot Bot requested review from fedirjh and removed request for a team September 3, 2023 20:10

hayata-suenaga approved these changes Sep 4, 2023

View reviewed changes

hayata-suenaga merged commit f85e7ae into Expensify:main Sep 4, 2023

mountiny mentioned this pull request Sep 4, 2023

[HOLD for payment 2023-09-12] [$500] [Distance] - App crashes while using distance feature #26558

Closed

6 tasks

OSBotify mentioned this pull request Sep 4, 2023

Deploy Checklist: New Expensify 2023-09-04 #26686

Closed

35 tasks

lanitochka17 mentioned this pull request Sep 4, 2023

[$500] [Distance] - Start and Finish data does not remain when user change to Manual/Scan #26716

Closed

6 tasks

OSBotify mentioned this pull request Sep 5, 2023

Deploy Checklist: New Expensify 2023-09-05 #26820

Closed

48 tasks

Uh oh!

Conversation

pradeepmdk commented Sep 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Sep 3, 2023

Uh oh!

fedirjh commented Sep 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pradeepmdk commented Sep 3, 2023

Uh oh!

pradeepmdk commented Sep 3, 2023

Uh oh!

fedirjh commented Sep 3, 2023

Uh oh!

pradeepmdk commented Sep 3, 2023

Uh oh!

pradeepmdk commented Sep 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pradeepmdk commented Sep 3, 2023

Uh oh!

pradeepmdk commented Sep 3, 2023

Uh oh!

fedirjh commented Sep 3, 2023

Uh oh!

fedirjh commented Sep 3, 2023 • edited by hayata-suenaga Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

fedirjh commented Sep 3, 2023

Uh oh!

fedirjh commented Sep 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hayata-suenaga commented Sep 4, 2023

Uh oh!

OSBotify commented Sep 4, 2023

Uh oh!

OSBotify commented Sep 4, 2023

Uh oh!

OSBotify commented Sep 5, 2023

Uh oh!

OSBotify commented Sep 5, 2023

Uh oh!

OSBotify commented Sep 6, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

pradeepmdk commented Sep 3, 2023 •

edited

Loading

fedirjh commented Sep 3, 2023 •

edited

Loading

pradeepmdk commented Sep 3, 2023 •

edited

Loading

fedirjh commented Sep 3, 2023 •

edited by hayata-suenaga

Loading

fedirjh commented Sep 3, 2023 •

edited

Loading