[$500] [Distance] - Start and Finish data does not remain when user change to Manual/Scan

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when executing PR #26622

Action Performed:

1. Open New Expensify app
2. Tap FAB button
3. Tap Request money
4. Tap Distance
5. Enter Start address
6. Enter Finish address
7. Navigate to Scan/Manual tab
8. Turn back to Distance tab

Expected Result:

Entered Start and Finish data should remain when user change to Manual/Scan

Actual Result:

Start and Finish data does not remain when user change to Manual/Scan

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• Windows / Chrome

Version Number: 1.3.63-0

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6188324_az_recorder_20230904_204906.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~013db7c954b21603ab
• Upwork Job ID: 1698830860091473920
• Last Price Increase: 2023-09-04

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~013db7c954b21603ab

[adelekennedy]

reproduced!

[melvin-bot]

Current assignee @adelekennedy is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @narefyev91 (External)

[DylanDylann]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Distance - Start and Finish data does not remain when user change to Manual/Scan

What is the root cause of that problem?

After selecting the location (start and finish) we save it in ONYX in the transcation_{transactionID} field. But when selecting another tab we reset the field

App/src/pages/iou/MoneyRequestSelectorPage.js

Line 66 in f67bf9f

IOU.resetMoneyRequestInfo(moneyRequestID);

It causes that the transactionID field in iou will be empty. Then, when coming back the new transaction will be created

App/src/pages/iou/DistanceRequestPage.js

Lines 48 to 53 in f67bf9f

	useEffect(() => {
	if (iou.transactionID) {
	return;
	}
	IOU.createEmptyTransaction();
	}, [iou.transactionID]);

The old transaction with the old value will not be used anymore

What changes do you think we should make in order to solve the problem?

When selecting another request tab, we should keep transactionID in iou field. So that, the new transaction will be not created by this logic

App/src/pages/iou/DistanceRequestPage.js

Lines 48 to 53 in f67bf9f

	useEffect(() => {
	if (iou.transactionID) {
	return;
	}
	IOU.createEmptyTransaction();
	}, [iou.transactionID]);

To do that, in resetMoneyRequestInfo function we can define transactionID param with the default value is ''.
And in here

App/src/pages/iou/MoneyRequestSelectorPage.js

Line 66 in f67bf9f

IOU.resetMoneyRequestInfo(moneyRequestID);

we pass transactionID to this fucntion

        IOU.resetMoneyRequestInfo(moneyRequestID, lodashGet(props.iou, 'transactionID', ''));

What alternative solutions did you explore? (Optional)

We can create a new field on ONYX called draftTransaction to save the location that the user selects.

App/src/pages/iou/WaypointEditor.js

Line 156 in f67bf9f

Transaction.saveWaypoint(transactionID, waypointIndex, waypoint);

Here we will save to draftTransaction instead of transactions_{transactionID}, we only save to transactions_{transactionID} when the user clicks the Next button. This is the way we did in task page

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Distance - Start and Finish data does not remain when user change to Manual/Scan

What is the root cause of that problem?

In

App/src/pages/iou/MoneyRequestSelectorPage.js

Lines 64 to 67 in f67bf9f

	const resetMoneyRequestInfo = () => {
	const moneyRequestID = `${iouType}${reportID}`;
	IOU.resetMoneyRequestInfo(moneyRequestID);
	};

We have the logic to reset request info when users change page. Unfortunately, we don't have the logic to check shouldReset as what we did in other pages like MoneyRequestMerchantPage,...

What changes do you think we should make in order to solve the problem?

add logic check shouldReset in resetMoneyRequestInfo function like below

    const resetMoneyRequestInfo = () => {
        const moneyRequestID = `${iouType}${reportID}`;
        const shouldReset = props.iou.id !== moneyRequestID;
        if(shouldReset){
            IOU.resetMoneyRequestInfo(moneyRequestID);
        }
    };