Skip to content

Clear validate error on refresh #24513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
johnmlee101 merged 3 commits into from
Aug 17, 2023
Merged

Clear validate error on refresh #24513

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
91e17d1
fix: validate error clears on mount
WikusKriek Aug 10, 2023
bdd696b
Merge branch 'main' into 23813-error-doesn't-clear-immediately
WikusKriek Aug 17, 2023
3f1f7a6
chore: add comment
WikusKriek Aug 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/pages/settings/Profile/Contacts/ValidateCodeForm/BaseValidateCodeForm.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,12 @@ function BaseValidateCodeForm(props) {

useEffect(() => {
Session.clearAccountMessages();
if (!validateLoginError) {
return;
}
User.clearContactMethodErrors(props.contactMethod, 'validateLogin');
// contactMethod is not added as a dependency since it does not change between renders
// eslint-disable-next-line react-hooks/exhaustive-deps

@mananjadhav mananjadhav Aug 17, 2023

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question why wouldn't we want to depend on props.contactMethod?

@WikusKriek WikusKriek Aug 17, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We just want to run this on component mount and not nececarily on the contact method change. I think changing the contact method will rrequire the component to unmount and mount again anyway.

@WikusKriek WikusKriek Aug 17, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your decision here I don't think it makes a difference.

@mananjadhav mananjadhav Aug 17, 2023

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add the comment explaining this, right before the eslint ignore?

@WikusKriek WikusKriek Aug 17, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added

}, []);

useEffect(() => {
Expand Down