Clear validate error on refresh by WikusKriek · Pull Request #24513 · Expensify/App

WikusKriek · 2023-08-13T17:59:18Z

Details

Validate error is cleared on refresh and navigating away and back.

Fixed Issues

$ #23813
PROPOSAL: #23813 (comment)

Tests

Go to setting > profile > contact method
Click on add contact method
Add a new contact method
Click on this contact method to verify
Enter a random magic code to make the error appear
Reload the page and notice that the error has cleared, on native click back and on the contact method again and notice the error has cleared.

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as Test Steps

PR Author Checklist

Screenshots/Videos

Web

Web.Chrome.2023-08-13.at.19.50.58.mov

Mobile Web - Chrome

Android.chrome.2023-08-13.at.20.09.31.mov

Mobile Web - Safari

IOS.safari.2023-08-13.at.19.49.33.mov

Desktop

Desktop.2023-08-13.at.19.42.54.mov

iOS

IOS.native.2023-08-13.at.19.47.39.mov

Android

https://github.com/Expensify/App/assets/41372145/589122ef-5c72-4f3c-9002-222a0f666348

melvin-bot · 2023-08-13T17:59:23Z

@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

WikusKriek · 2023-08-17T18:45:03Z

@mananjadhav this is ready for review.

mananjadhav · 2023-08-17T18:56:44Z

+        }
+        User.clearContactMethodErrors(props.contactMethod, 'validateLogin');
+
+        // eslint-disable-next-line react-hooks/exhaustive-deps


question why wouldn't we want to depend on props.contactMethod?

We just want to run this on component mount and not nececarily on the contact method change. I think changing the contact method will rrequire the component to unmount and mount again anyway.

Your decision here I don't think it makes a difference.

Let's add the comment explaining this, right before the eslint ignore?

mananjadhav

Code change looks good to me. I'll test it now.

mananjadhav · 2023-08-17T20:02:08Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web-clear-error-message.mov

Mobile Web - Chrome

mweb-chrome-clear-error-message.mov

Mobile Web - Safari

mweb-safari-clear-error-message.mov

Desktop

desktop-clear-error-message.mov

iOS

ios-clear-error-message.mov

Android

android-clear-error-message.mov

Thanks for the quick PR @WikusKriek. Tests well. @johnmlee101 All yours.

🎀 👀 🎀 C+ reviewed.

johnmlee101 · 2023-08-17T21:08:06Z

@mananjadhav

did you review on Android native? It's blocking the reviewer checklist 😄

mananjadhav · 2023-08-17T21:09:41Z

@johnmlee101 Yes I did 🤦 . I added the screenshot but I didn't mark the item. Done now.

OSBotify · 2023-08-17T21:15:57Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-08-21T22:25:16Z

🚀 Deployed to staging by https://github.com/johnmlee101 in version: 1.3.56-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

roryabraham · 2023-08-23T20:03:55Z

#24513 - failing #23813.

@mvtglobally Applause reported this issue as a QA fail. It's not a deploy blocker but can you provide some more details?

OSBotify · 2023-08-24T03:08:17Z

🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.56-24 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

fix: validate error clears on mount

91e17d1

WikusKriek requested a review from a team as a code owner August 13, 2023 17:59

melvin-bot Bot requested review from mananjadhav and removed request for a team August 13, 2023 17:59

WikusKriek marked this pull request as draft August 13, 2023 17:59

Merge branch 'main' into 23813-error-doesn't-clear-immediately

bdd696b

WikusKriek marked this pull request as ready for review August 17, 2023 18:44

mananjadhav reviewed Aug 17, 2023

View reviewed changes

chore: add comment

3f1f7a6

mananjadhav approved these changes Aug 17, 2023

View reviewed changes

melvin-bot Bot requested a review from johnmlee101 August 17, 2023 19:22

johnmlee101 approved these changes Aug 17, 2023

View reviewed changes

johnmlee101 merged commit a6fa52d into Expensify:main Aug 17, 2023

OSBotify mentioned this pull request Aug 21, 2023

Deploy Checklist: New Expensify 2023-08-21 #25625

Closed

Uh oh!

Conversation

WikusKriek commented Aug 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Aug 13, 2023

Uh oh!

WikusKriek commented Aug 17, 2023

Uh oh!

mananjadhav Aug 17, 2023

Choose a reason for hiding this comment

Uh oh!

WikusKriek Aug 17, 2023

Choose a reason for hiding this comment

Uh oh!

WikusKriek Aug 17, 2023

Choose a reason for hiding this comment

Uh oh!

mananjadhav Aug 17, 2023

Choose a reason for hiding this comment

Uh oh!

WikusKriek Aug 17, 2023

Choose a reason for hiding this comment

Uh oh!

mananjadhav left a comment

Choose a reason for hiding this comment

Uh oh!

mananjadhav commented Aug 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

johnmlee101 commented Aug 17, 2023

Uh oh!

mananjadhav commented Aug 17, 2023

Uh oh!

OSBotify commented Aug 17, 2023

Uh oh!

OSBotify commented Aug 21, 2023

Uh oh!

roryabraham commented Aug 23, 2023

Uh oh!

OSBotify commented Aug 24, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

WikusKriek commented Aug 13, 2023 •

edited

Loading

mananjadhav commented Aug 17, 2023 •

edited

Loading