Fix bugs surrounding report name when deleting first thread comment by marcaaron · Pull Request #23514 · Expensify/App

marcaaron · 2023-07-24T21:51:27Z

Details

There are two issues being fixed here:

We are incorrectly flagging the "parent report" of a thread as having a "last message" that is a "deleted parent action" (of a thread report). We are looking to see if the report action (which is the parent action) has any visible child actions (which seems to be the logical opposite of what we really want).
Once we fix that issue - the "thread report" itself in the LHN does not update because we are not changing anything about it and there are no other data changes that would trigger an Onyx update (and for it to rerender with the updated titled generated here).

Ideally, we would subscribe to the parentReportAction for the thread report here. I couldn't find an easy way to do this as we must check to see if the report is a thread and then subscribe to just the first report action (not possible with Onyx selectors AFAICT).

Fixed Issues

$ #23401

Tests

Create a chat report between two users
Leave several comments on the chat report
On any message that is not the last message create a thread
Leave another message on the thread report
Delete the parent message (top/first) of the thread report
Verify in the LHN that:

The subtitle of the initial chat has the correct "last message"
The title of the thread chat says [Deleted message] and it's subtitle reflects the correct "last message" for the thread.
Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Full disclosure iOS sim issues prevented me from testing

Desktop

iOS

Full disclosure iOS sim issues prevented me from testing

Android

cead22 · 2023-07-24T21:59:27Z

        lastVisibleActionCreated: '',
    };
-    if (reportAction.reportActionID && reportAction.childVisibleActionCount > 0) {
+    if (reportAction.reportActionID && reportAction.childVisibleActionCount === 0) {


Do we need to check reportAction.reportActionID here?

const optimisticReportActions = { [reportActionID]: {

Doesn't this imply it's truthy? If it's still needed, can it be replaced with if (reportActionID && ...?

That's a good point. If it's not defined then something is wrong because we are about to save an object with a key of undefined. I think this was probably just overly cautious programming.

If there is a reason it should have been documented better 🤷‍♂️

cead22 · 2023-07-24T22:29:56Z

+
+            // This may appear to be unused, but we don't use this field for anything other than to trigger an
+            // update to the LHN that the report action we are deleting is the first message of a thread.
+            value: {isParentReportActionDeleted: true},


NAB but just an idea to make it more in line with the comment

Suggested change

value: {isParentReportActionDeleted: true},

value: {updateReportInLHN: true},

ah, yes, I prefer this. It solves my concern about people trying to use isParentReportActionDeleted for things when it may be unreliable.

allroundexperts · 2023-07-24T23:12:55Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-07-25.at.4.39.47.AM.mov

Mobile Web - Chrome

Screen.Recording.2023-07-25.at.4.44.21.AM.mov

Mobile Web - Safari

Screen.Recording.2023-07-25.at.4.42.52.AM.mov

Desktop

Screen.Recording.2023-07-25.at.4.48.59.AM.mov

iOS

Screen.Recording.2023-07-25.at.4.45.53.AM.mov

Android

Screen.Recording.2023-07-25.at.4.47.21.AM.mov

melvin-bot · 2023-07-24T23:25:48Z

@allroundexperts Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

allroundexperts

Tests well!

melvin-bot · 2023-07-24T23:55:08Z

@robertjchen Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Fix bugs surrounding report name when deleting first thread comment (cherry picked from commit fbfabee)

OSBotify · 2023-07-25T00:00:33Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-07-25T00:31:26Z

🚀 Deployed to staging by https://github.com/marcaaron in version: 1.3.44-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-07-25T01:23:39Z

🚀 Deployed to production by https://github.com/marcaaron in version: 1.3.44-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Fix bugs surrounding report name when deleting first thread comment

93e5812

marcaaron self-assigned this Jul 24, 2023

cead22 reviewed Jul 24, 2023

View reviewed changes

Comment thread src/libs/actions/Report.js Outdated

marcaaron added 2 commits July 24, 2023 12:24

Use isThreadFirstChat

f59e58e

Remove check for reportAction.reportActionID

f841af3

cead22 reviewed Jul 24, 2023

View reviewed changes

Improve comments and naming

e99d99a

cead22 approved these changes Jul 24, 2023

View reviewed changes

marcaaron changed the title ~~[WIP] Fix bugs surrounding report name when deleting first thread comment~~ Fix bugs surrounding report name when deleting first thread comment Jul 24, 2023

marcaaron marked this pull request as ready for review July 24, 2023 23:25

marcaaron requested a review from a team as a code owner July 24, 2023 23:25

melvin-bot Bot requested review from allroundexperts and removed request for a team July 24, 2023 23:25

allroundexperts approved these changes Jul 24, 2023

View reviewed changes

melvin-bot Bot requested a review from robertjchen July 24, 2023 23:55

marcaaron merged commit fbfabee into main Jul 24, 2023

marcaaron deleted the marcaaron-fixThreadReportName branch July 24, 2023 23:56

OSBotify pushed a commit that referenced this pull request Jul 24, 2023

Merge pull request #23514 from Expensify/marcaaron-fixThreadReportName

c6e6793

Fix bugs surrounding report name when deleting first thread comment (cherry picked from commit fbfabee)

OSBotify mentioned this pull request Jul 25, 2023

Deploy Checklist: New Expensify 2023-07-25 #23522

Closed

melvin-bot Bot mentioned this pull request Jul 25, 2023

[HOLD for payment 2023-08-02] LHN - If the first comment in a thread is deleted [Deleted message] appears in the LHN subtitle of the parent report #23401

Closed

6 tasks

dukenv0307 mentioned this pull request Jul 26, 2023

[HOLD for payment 2023-08-10] [$1000] Parent Message of thread chat on LHN doesn't updated when the parent message is updated #23424

Closed

6 tasks

blazejkustra mentioned this pull request Nov 30, 2023

[TS migration] Migrate 'Report.js' lib to TypeScript #28730

Merged

59 tasks

	value: {isParentReportActionDeleted: true},
	value: {updateReportInLHN: true},

Uh oh!

Conversation

marcaaron commented Jul 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

cead22 Jul 24, 2023

Choose a reason for hiding this comment

Uh oh!

marcaaron Jul 24, 2023

Choose a reason for hiding this comment

Uh oh!

marcaaron Jul 24, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cead22 Jul 24, 2023

Choose a reason for hiding this comment

Uh oh!

marcaaron Jul 24, 2023

Choose a reason for hiding this comment

Uh oh!

allroundexperts commented Jul 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jul 24, 2023

Uh oh!

allroundexperts left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented Jul 24, 2023

Uh oh!

OSBotify commented Jul 25, 2023

Uh oh!

OSBotify commented Jul 25, 2023

Uh oh!

OSBotify commented Jul 25, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

marcaaron commented Jul 24, 2023 •

edited

Loading

allroundexperts commented Jul 24, 2023 •

edited

Loading