[HOLD for payment 2023-08-02] LHN - If the first comment in a thread is deleted `[Deleted message]` appears in the LHN subtitle of the parent report

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to any chat, say with user X
2. Send "one", "two", "three" as separate messages
3. Thread off of "one"
4. Send a message in the thread
5. Delete "one" while inside of the thread
6. Look at the chat with user X on the LHN
7. The subtitle should say "three" but it says [message deleted] instead

Expected Result:

The subtitle should say "three"

Actual Result:

The subtitle should says [Deleted message]

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.43-7
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen_Recording_20230722_214641_Chrome.mp4

Screen.Recording.2023-07-21.at.7.00.51.PM.1.mov

RPReplay_Final1690042983.MP4

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689947132354429

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~013902117a4d0a80c3
• Upwork Job ID: 1683594961925722112
• Last Price Increase: 2023-07-24

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @cead22 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[samh-nl]

Regression from: 147ec31

Proposal

Please re-state the problem that we are trying to solve in this issue.

[Deleted message] shows in LHN when deleting the parent message of a thread.

What is the root cause of that problem?

When deleting the parent message of a thread, isLastMessageDeletedParentAction is set to true:

App/src/libs/actions/Report.js

Lines 900 to 906 in b7d17e0

	if (reportAction.reportActionID && reportAction.childVisibleActionCount > 0) {
	optimisticReport = {
	lastMessageTranslationKey: '',
	lastMessageText: '',
	isLastMessageDeletedParentAction: true,
	};
	} else {

What changes do you think we should make in order to solve the problem?

isLastMessageDeletedParentAction should only be set to true if it is the last visible message.
Secondly, this should not be exclusive to parent messages of a thread, but rather when deleting any last visible message.

What alternative solutions did you explore? (Optional)

N/A

[dukenv0307]

@chiragsalian We need to update from BE side to match new update from App repo as mentioned here

cc @rushatgabhane

[rk111]

I can check the issue

[dukenv0307]

hold #19722

[dummy-1111]

Proposal

Please re-state the problem that we are trying to solve in this issue.

[Deleted message] appears in LHN even after the last message is different

What is the root cause of that problem?

This issue is from the PR

If we delete the first message with child report, isLastMessageDeletedParentAction is set in the report.

App/src/libs/actions/Report.js

Line 904 in 48edd31

isLastMessageDeletedParentAction: true,

We set this value to null only when we add new comment. This is incorrect and is the root cause of the issue

What changes do you think we should make in order to solve the problem?

Actually, we don't need the isLastMessageDeletedParentAction property in report. And some of the changes of the backend mentioned #19722 (comment) are not needed.

All we have to do:

• Include deleted parent action that has childVisibleActionCount > 0 in the visible actions
• If last visible action is a deleted parent action, we show [Deleted message]

Doing this would fix this issue and #19722. No needs to change backend.

Details
First of all, revert all the changes made by this PR

1. Define a function to check if an anction is a visible deleted parent action(childVisibleActionCount > 0) in ReportActionUtils.js

function isVisibleDeletedParentAction(reportAction) {
    return lodashGet(reportAction, ['message', 0, 'isDeletedParentAction'], false) && lodashGet(reportAction, 'childVisibleActionCount', 0) > 0
}

2. In getLastVisibleAction, use shouldReportActionBeVisible instead of !isDeletedAction
3. In getLastVisibleMessage, add the following code

    if (isVisibleDeletedParentAction(action)) {
        return {
            lastMessageTranslationKey: 'parentReportAction.deletedMessage'
        }
    }

4. In getLastMessageTextForReport function in OptionsListUtils.js, get last action by getLastVisibleAction function

    const lastReportAction = ReportActionUtils.getLastVisibleAction(report.reportID);

and add the following

    } else if (ReportActionUtils.isVisibleDeletedParentAction(lastReportAction)) {
        lastMessageTextFromReport = `${Localize.translateLocal(report.lastMessageTranslationKey || 'parentReportAction.deletedMessage')}`;

What alternative solutions did you explore? (Optional)