changes for wording for use plus button by ishpaul777 · Pull Request #23248 · Expensify/App

ishpaul777 · 2023-07-20T09:53:09Z

Details

Fixed Issues

$ #19828
PROPOSAL

Tests

Verify that no errors appear in the JS console
Verify when preferred language is English Welcome text on Workspace Report for use plus button is "You can also use the + button below to request money or assign a task!"
Verify when preferred language is Spanish Welcome text on Workspace Report for use plus button is "¡También puedes usar el botón + de abajo para pedir dinero o asignar una tarea!"

ref video- #19828 (comment)

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

github-actions · 2023-07-20T09:53:24Z

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

melvin-bot · 2023-07-20T09:53:47Z

@luacmartins Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ishpaul777 · 2023-07-20T10:11:27Z

I have read the CLA Document and I hereby sign the CLA

ishpaul777 · 2023-07-20T10:17:59Z

@thesahindia I am not able to navigate to a Workspace chat like here to verify the changes. When i create a Workspace only 2 new rooms created # announcements and # admins, workspace chat is not in LHN

rushatgabhane · 2023-07-20T11:47:03Z

I'll be reviewing this

rushatgabhane · 2023-07-20T13:43:29Z

am not able to navigate to a Workspace chat like #19828 (comment) to verify the changes

@ishpaul777 for that you'll need to do the following step

go to search (cmd + k)
search for your workspace name

ishpaul777 · 2023-07-20T14:19:03Z

@rushatgabhane still not getting workspace only getting the rooms.

ishpaul777 · 2023-07-20T16:09:08Z

@rushatgabhane is there something i missed ?

rushatgabhane · 2023-07-20T16:38:20Z

@ishpaul777 maybe invite users to your workspace

luacmartins · 2023-07-20T16:51:45Z

I think there's a beta for this. @ishpaul777 what email are you using to test?

luacmartins

LGTM

ishpaul777 · 2023-07-20T16:53:36Z

@luacmartins
email- ishpaul207@gmail.com

luacmartins · 2023-07-20T16:53:51Z

Not sure why Melvin assigned me to this issue when @amyevans is the CME 😕

luacmartins · 2023-07-20T16:54:34Z

Ok, added you to the beta. Try again in a few minutes to an hour.

luacmartins · 2023-07-20T16:54:51Z

@ishpaul777 lint is failing. Try running npm run prettier to fix the issue.

ishpaul777 · 2023-07-20T16:57:27Z

will do it! Btw @luacmartins i dont know why my first is not signed. is there a way i can sign it now?

rushatgabhane · 2023-07-20T17:03:07Z

@ishpaul777 check this out https://stackoverflow.com/questions/63943197/signoff-previous-in-between-commits-in-git

ishpaul777 · 2023-07-21T11:36:56Z

tested in offline mode @rushatgabhane

Can you review?

Nikhil-Vats · 2023-07-21T13:45:28Z

Hey @rushatgabhane @luacmartins, I saw @ishpaul777's message on slack and since they don't have a mac and scaleway's mac services are on hold. I volunteered to help with test proofs if you two agree it's okay this one time.

rushatgabhane · 2023-07-21T13:50:24Z

@Nikhil-Vats thanks for the help! yeah that works. you can post them as a comment here

ishpaul777 · 2023-07-21T19:59:08Z

i added the screenshots @rushatgabhane except for android and mobile chrome was not able to build the app for them on scaleaway mac instance.

ishpaul777 · 2023-07-22T11:46:58Z

I am done from side @rushatgabhane. I tried reaching out on slack @Nikhil-Vats but he is not available. I am not able to get the remaing screenshots, also i have seen multiple closed PR's without screenshots, please guide me what should i do.

Nikhil-Vats · 2023-07-22T12:24:59Z

Android

Mobile Web - Chrome

ishpaul777 · 2023-07-22T12:52:16Z

@Nikhil-Vats Thank you so much! ✨

@rushatgabhane PR is ready!

ishpaul777 · 2023-07-22T19:04:38Z

@rushatgabhane @amyevans can you please update on when this should be final reviewed and merged ?

rushatgabhane · 2023-07-23T09:36:58Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

A

Mobile Web - Safari

Desktop

iOS

Android

ishpaul777 · 2023-07-24T09:53:58Z

@rushatgabhane if you have any update or concerns with the PR, please let me know?

rushatgabhane · 2023-07-24T10:40:16Z

thanks for completing the checklist @ishpaul777

I'll try to prioritise the PR

rushatgabhane

LGTM

melvin-bot · 2023-07-24T17:24:16Z

🎯 @rushatgabhane, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #23495.

OSBotify · 2023-07-24T18:16:22Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-07-25T01:43:03Z

🚀 Deployed to staging by https://github.com/amyevans in version: 1.3.45-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

mvtglobally · 2023-07-25T04:21:38Z

@rushatgabhane @luacmartins Can you pls confirm we dont need to QA this? Steps are missing

rushatgabhane · 2023-07-25T05:28:46Z

@mvtglobally QA steps -

Create a new workspace
Go to the default workspace room
Verify that Welcome text doesn't say anything about "send money"

luacmartins · 2023-07-25T16:32:32Z

Thanks for the QA steps @rushatgabhane!

OSBotify · 2023-07-26T15:52:34Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.45-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

JmillsExpensify · 2023-08-04T04:14:41Z

@luacmartins @amyevans Can I get a written confirmation from one of you that @rushatgabhane should be paid out $1,000 for his work helping review this PR?

amyevans · 2023-08-04T14:53:14Z

@JmillsExpensify He's being paid $1500 per the linked issue, he took over as C+ there

ishpaul777 requested a review from a team as a code owner July 20, 2023 09:53

melvin-bot Bot requested review from luacmartins and removed request for a team July 20, 2023 09:53

This was referenced Jul 20, 2023

[$1000] Web - Placeholders are overlapping with auto-filled text #23003

Closed

[HOLD for payment 2023-08-02][$1000] Workspace chat displays 'send money' when there are no option to send the money #19828

Closed

thesahindia reviewed Jul 20, 2023

View reviewed changes

Comment thread src/components/ReportWelcomeText.js Outdated

ishpaul777 force-pushed the ishpaul777/changed_wording_for_usePlusButton branch from 748e871 to d6b30ee Compare July 20, 2023 16:24

ishpaul777 added 2 commits July 20, 2023 16:26

changes for wording for use plus button

08ea6c4

revert unnecessary changes

4e437b7

ishpaul777 force-pushed the ishpaul777/changed_wording_for_usePlusButton branch from d6b30ee to 4e437b7 Compare July 20, 2023 16:27

luacmartins previously approved these changes Jul 20, 2023

View reviewed changes

luacmartins requested a review from rushatgabhane July 20, 2023 16:52

code linting

af184ac

ishpaul777 dismissed luacmartins’s stale review via af184ac July 20, 2023 16:59

amyevans self-requested a review July 21, 2023 14:46

permission overrirde

3a2d20a

rushatgabhane reviewed Jul 21, 2023

View reviewed changes

Comment thread src/libs/Permissions.js

permission reverted

2f5ba4a

rushatgabhane approved these changes Jul 24, 2023

View reviewed changes

melvin-bot Bot mentioned this pull request Jul 24, 2023

Payment issue for E/App PR#23248 #23495

Closed

ishpaul777 mentioned this pull request Jul 24, 2023

[$1000] Chat - Outdated message " Send money" displayed at the top of the page #22940

Closed

6 tasks

amyevans approved these changes Jul 24, 2023

View reviewed changes

amyevans merged commit 9282731 into Expensify:main Jul 24, 2023

OSBotify mentioned this pull request Jul 25, 2023

Deploy Checklist: New Expensify 2023-07-25 #23522

Closed

Uh oh!

Conversation

ishpaul777 commented Jul 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

github-actions Bot commented Jul 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

melvin-bot Bot commented Jul 20, 2023

Uh oh!

ishpaul777 commented Jul 20, 2023

Uh oh!

ishpaul777 commented Jul 20, 2023

Uh oh!

Uh oh!

rushatgabhane commented Jul 20, 2023

Uh oh!

rushatgabhane commented Jul 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ishpaul777 commented Jul 20, 2023

Uh oh!

ishpaul777 commented Jul 20, 2023

Uh oh!

rushatgabhane commented Jul 20, 2023

Uh oh!

luacmartins commented Jul 20, 2023

Uh oh!

luacmartins left a comment

Choose a reason for hiding this comment

Uh oh!

ishpaul777 commented Jul 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

luacmartins commented Jul 20, 2023

Uh oh!

luacmartins commented Jul 20, 2023

Uh oh!

luacmartins commented Jul 20, 2023

Uh oh!

ishpaul777 commented Jul 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rushatgabhane commented Jul 20, 2023

Uh oh!

ishpaul777 commented Jul 21, 2023

Uh oh!

Nikhil-Vats commented Jul 21, 2023

Uh oh!

rushatgabhane commented Jul 21, 2023

Uh oh!

Uh oh!

ishpaul777 commented Jul 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ishpaul777 commented Jul 22, 2023

Uh oh!

Nikhil-Vats commented Jul 22, 2023

Uh oh!

ishpaul777 commented Jul 22, 2023

Uh oh!

ishpaul777 commented Jul 22, 2023

Uh oh!

rushatgabhane commented Jul 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

ishpaul777 commented Jul 24, 2023

Uh oh!

rushatgabhane commented Jul 24, 2023

Uh oh!

rushatgabhane left a comment

ishpaul777 commented Jul 20, 2023 •

edited

Loading

github-actions Bot commented Jul 20, 2023 •

edited

Loading

rushatgabhane commented Jul 20, 2023 •

edited

Loading

ishpaul777 commented Jul 20, 2023 •

edited

Loading

ishpaul777 commented Jul 20, 2023 •

edited

Loading

ishpaul777 commented Jul 21, 2023 •

edited

Loading

rushatgabhane commented Jul 23, 2023 •

edited

Loading