[HOLD for payment 2023-08-02][$1000] Workspace chat displays 'send money' when there are no option to send the money

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to dev on web chrome
2. Create a new workspace
3. Go to the newly created 'Workspace chat' that has square logo
4. Notice that on the message , it displays 'You can also use the + button below to send or request money!'
5. But now , click on + icon and notice that it doesn't have options for send money and has only request money and attachment

Expected Result:

The message should not display 'Send Money' since there is no functionality to send money in the + icon

Actual Result:

Workspace chat displays 'send money even when there is no option to send the money on the + icon

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.20.1

Reproducible in staging?: yes

**Reproducible in production?:**yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

error-2023-05-27_14.14.01.mp4

Expensify/Expensify Issue URL:

Issue reported by: @priya-zya

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1685176461755199

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a1e5de861745b07c
• Upwork Job ID: 1673785766553649152
• Last Price Increase: 2023-07-12

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[hungvu193]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace chat displays 'send money' when there are no option to send the money

What is the root cause of that problem?

In ReportWelcomeMessage we are using the OR condition to show this common message for both request and send type:

                {(moneyRequestOptions.includes(CONST.IOU.MONEY_REQUEST_TYPE.SEND) || moneyRequestOptions.includes(CONST.IOU.MONEY_REQUEST_TYPE.REQUEST)) && (
                    <Text>{props.translate('reportActionsView.usePlusButton')}</Text>
                )}

What changes do you think we should make in order to solve the problem?

In case we want to separate the message we need to update the condition to show this welcome message:

// this is just script, in fact we should use translate key instead.
getWelcomeMessage () {
if ((moneyRequestOptions.includes(CONST.IOU.MONEY_REQUEST_TYPE.SEND) && moneyRequestOptions.includes(CONST.IOU.MONEY_REQUEST_TYPE.REQUEST)) {
 return "translateKeyForRequestSend"
} else if ((moneyRequestOptions.includes(CONST.IOU.MONEY_REQUEST_TYPE.SEND)) {
return "translateKeyForSend"
} else if (moneyRequestOptions.includes(CONST.IOU.MONEY_REQUEST_TYPE.REQUEST)) {
return "translateKeyForRequestRequest"
}
}

then update the Text condition

!!welcomeMessage && <Text>{props.translate('welcomeMessage')}</Text>

What alternative solutions did you explore? (Optional)

N/A

[JmillsExpensify]

You shouldn't be able to Send Money on the workspace chat so I think this is as simple as a wording change and we're done here. @luacmartins What do you think about keeping this internal and me handling the wording change?

[luacmartins]

@JmillsExpensify that sounds good to me! Looking forward to the PR :)

[luacmartins]

@JmillsExpensify any updates here?

[melvin-bot]

@JmillsExpensify Huh... This is 4 days overdue. Who can take care of this?

[JmillsExpensify]

Sorry haha I commented and now need to actually get back to this in the coming days. Will circle back!

[melvin-bot]

@JmillsExpensify Huh... This is 4 days overdue. Who can take care of this?