Upgrade the react native dependency to v0.71.2-alpha.3 by priyeshshah11 · Pull Request #15130 · Expensify/App

priyeshshah11 · 2023-02-14T16:30:31Z

Details

Updating the react native version to 0.71 :shiny:

Fixed Issues

$ #15124
PROPOSAL: #15124 (comment)

Tests

Full regression test

Verify that no errors appear in the JS console

Offline tests

Nothing specific

QA Steps

Full regression test

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

…ha.1

Santhosh-Sellavel · 2023-02-14T21:48:56Z

@priyeshshah11 If PR is ready for review please link the issue correctly in the PR description before submitting

priyeshshah11 · 2023-02-14T21:50:53Z

@priyeshshah11 If PR is ready for review please link the issue correctly in the PR description before submitting

It is not ready, thus in draft. Will check the linking.

roryabraham

Per this issue we should be able to remove this jest preset as part of this PR

roryabraham

We've now published v0.71.2-alpha.2, so this PR should be updated to use that release instead

…e-camera-roll

priyeshshah11 · 2023-02-17T22:02:48Z

@abdulrahuman5196 Could you please try building & testing this PR?

…s. Also upgraded react-native-image-picker & react-native-plaid-link-sdk

priyeshshah11 · 2023-02-18T22:57:31Z

android/app/build.gradle

-task copyDownloadableDepsToLibs(type: Copy) {
-    from configurations.implementation
-    into 'libs'
+    implementation("androidx.lifecycle:lifecycle-viewmodel-ktx:2.4.0")


added this line due to this error & SO answer https://stackoverflow.com/a/69923303/16762514

priyeshshah11 · 2023-02-18T22:59:23Z

package.json

    "prop-types": "^15.7.2",
-    "pusher-js": "^7.0.6",
-    "react": "18.1.0",
+    "pusher-js": "7.4.0",


upgraded pusher because of this issue pusher/pusher-js#654 (comment)

priyeshshah11 · 2023-02-18T23:02:08Z

package.json

    "react-native-picker-select": "git+https://github.com/Expensify/react-native-picker-select.git#77cc9d42c474a693755941b10ee4c2d6f50e5346",
-    "react-native-plaid-link-sdk": "^7.2.0",
-    "react-native-quick-sqlite": "^5.0.3",
+    "react-native-plaid-link-sdk": "https://github.com/Pedroor/react-native-plaid-link-sdk.git",


Waiting on this PR plaid/react-native-plaid-link-sdk#518 to be merged

@mountiny FYI, still waiting on this.

package.json

MelvinBot · 2023-02-18T23:36:50Z

@mountiny @Santhosh-Sellavel One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

priyeshshah11 · 2023-02-18T23:45:44Z

I was able to fix the iOS build issues with @abdulrahuman5196's help & had to update a few more libs to fix android. Now all platforms are building & working but with a few issues, @abdulrahuman5196 It is now ready for you to test.

@mountiny & @roryabraham We should now add the Ready to build label to this PR to build & test on real devices.

Some issues that I am aware of & will look into later are:

Randomly see this error in ReportActionsList when some reports are opened.
Add attachments feature isn't working on native, throws an error.
TypeError: Cannot read property 'launchImageLibrary' of null
Passing unsupported styles to RN components is showing console warnings now, not sure if this is already there in main or the version upgrade is causing it. Warning: Failed prop type: Invalid props.style key 'ellipsizeMode' supplied to 'Text'. - Do we need to fix this in this PR?

abdulrahuman5196 · 2023-02-19T17:15:09Z

@priyeshshah11 Thank you. Will start testing from my end.

Just to note:

Passing unsupported styles to RN components is showing console warnings now, not sure if this is already there in main or the version upgrade is causing it. Warning: Failed prop type: Invalid props.style key 'ellipsizeMode' supplied to 'Text'. - Do we need to fix this in this PR?

I remember seeing this issue before this PR as well, not sure though have to double check. I think its best to not include issues which is not related to this PR. I am just being cautious not to cause any regression. Correct me if wrong.

priyeshshah11 · 2023-02-20T13:09:04Z

@abdulrahuman5196 How did the testing go? I have left the testing items in the PR description for you & I think the reviewer checklist is for C+ to use.

abdulrahuman5196 · 2023-02-20T13:18:14Z

@abdulrahuman5196 How did the testing go? I have left the testing items in the PR description for you & I think the reviewer checklist is for C+ to use.

Working on testing. Will complete by tomorrow.

I will copy paste the PR description then and work on it as I can't edit it directly.

priyeshshah11 · 2023-02-20T13:19:43Z

I will copy paste the PR description then and work on it as I can't edit it directly.

Feel free to send it to me so I can edit in the og description as well

abdulrahuman5196 · 2023-02-21T14:38:21Z

Note: Will copy paste to PR description once all checklist is tested

Details

Upgrade the react native dependency to v0.71.2-alpha.1

Fixed Issues

$ #15124
PROPOSAL: #15124 (comment)

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

desktop.1.mp4

desktop.new.2.mp4

desktop.new.3.mp4

desktop.new.4.mp4

desktop.new.5.mp4

desktop.new.6.mp4

desktop.new.7.mp4

iOS

ios.1.mp4

ios.2.mp4

ios.3.mp4

ios.4.mp4

ios.5.mp4

ios.6.mp4

Android

abdulrahuman5196 · 2023-02-21T17:01:50Z

@priyeshshah11 I am facing issues building ios project with the latest commit(Attached the screenshot of the issue).
But its seems to be working fine in other platforms.

I think its related to this plaid version in the PR

-    "react-native-plaid-link-sdk": "^7.2.0",
+   "react-native-plaid-link-sdk": "https://github.com/Pedroor/react-native-plaid-link-sdk.git",

aimane-chnaif · 2023-04-11T10:41:28Z

@aimane-chnaif Could you also run through the reviewer checklist please?

sure, will do once PR is up-to-date with main

OSBotify · 2023-04-11T11:25:36Z

🧪🧪 Use the links below to test this build in android and iOS. Happy testing! 🧪🧪

android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/15130/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/15130/index.html

desktop 💻	web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/15130/NewExpensify.dmg	https://15130.pr-testing.expensify.com

…eshshah11-upgrade-rn-version

priyeshshah11 · 2023-04-11T11:34:11Z

@mountiny @aimane-chnaif resolved conflicts, will be offline today as will be on a flight.

aimane-chnaif · 2023-04-11T11:39:06Z

I tested this android release build and confirmed pill multiline issue not happening.

mountiny · 2023-04-11T12:09:26Z

@aimane-chnaif Thanks I think once you get the reviewer checklist in, we can merge this!

Comments addressed

aimane-chnaif · 2023-04-11T12:16:59Z

@priyeshshah11 please fill checklist. If not applicable, just check them off.

mountiny · 2023-04-11T12:41:46Z

@aimane-chnaif went ahead and did it given Priyesh might be travelling

aimane-chnaif

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

Latest version tests well.
There are some console errors but checking off since they're handled in follow-up issue

mountiny

Great, I think I would go ahead and merge this what do you think @roryabraham

mountiny · 2023-04-11T15:09:40Z

I think we can just go ahead and

OSBotify · 2023-04-11T15:18:23Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-04-11T21:25:58Z

🚀 Deployed to staging by https://github.com/mountiny in version: 1.2.99-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

priyeshshah11 · 2023-04-11T23:05:50Z

@aimane-chnaif went ahead and did it given Priyesh might be travelling

Thanks! 🙌 @mountiny

OSBotify · 2023-04-13T03:01:59Z

🚀 Deployed to production by https://github.com/francoisl in version: 1.2.99-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Initial changes to upgrade the react native dependency to v0.71.2-alp…

e95c79e

…ha.1

roryabraham requested changes Feb 14, 2023

View reviewed changes

upgraded react-native-onyx version to use my (priyeshshah11's) fork

1872ad1

priyeshshah11 mentioned this pull request Feb 16, 2023

Upgrade react-native to v0.71.2 Expensify/react-native-onyx#234

Closed

roryabraham previously requested changes Feb 17, 2023

View reviewed changes

priyeshshah11 added 3 commits February 17, 2023 23:41

upgraded react-native version to v0.71.2-alpha-2 & to use react-nativ…

0894618

…e-camera-roll

Resolve merge conflicts with main

9e34845

removed jest preset

42bd0d8

Updated pusher-js to v7.4.0 & updated build.gradle to fix build issue…

01360c7

…s. Also upgraded react-native-image-picker & react-native-plaid-link-sdk

priyeshshah11 commented Feb 18, 2023

View reviewed changes

package.json Outdated Show resolved Hide resolved

priyeshshah11 marked this pull request as ready for review February 18, 2023 23:36

priyeshshah11 requested a review from a team as a code owner February 18, 2023 23:36

melvin-bot bot requested review from Santhosh-Sellavel and mountiny and removed request for a team February 18, 2023 23:36

priyeshshah11 mentioned this pull request Feb 20, 2023

Upgraded react-native to v0.71.2 Expensify/react-native-onyx#235

Merged

tienifr mentioned this pull request Apr 11, 2023

[HOLD #34289] [$2000] The app crashes when the user is logged into multiple tabs and logs out of one of the tabs #15321

Closed

6 tasks

Merge branch 'main' of https://github.com/priyeshshah11/App into priy…

c1540a2

…eshshah11-upgrade-rn-version

priyeshshah11 dismissed mountiny’s stale review via c1540a2 April 11, 2023 11:33

mountiny requested review from Santhosh-Sellavel, mountiny and roryabraham April 11, 2023 12:09

aimane-chnaif approved these changes Apr 11, 2023

View reviewed changes

mountiny approved these changes Apr 11, 2023

View reviewed changes

mountiny merged commit d74cd27 into Expensify:main Apr 11, 2023

OSBotify mentioned this pull request Apr 11, 2023

Deploy Checklist: New Expensify 2023-04-11 #17298

Closed

26 tasks

roryabraham mentioned this pull request Apr 12, 2023

[HOLD setSelection refactor] [$2000] Android - Cursor is placed in wrong position after write/paste the emoji between the word Hello and nice - Reported by: @AndreasBBS #12854

Closed

s77rt mentioned this pull request Apr 12, 2023

[HOLD for facebook/react-native#40762][$2000] Left-most characters are hidden if text in line is longer than screen size #15310

Closed

1 task

aldo-expensify mentioned this pull request Apr 17, 2023

Dev: Console error on android app launch Possible Unhandled Promise Rejection Error: Not supported on Android #16999

Closed

6 tasks

bernhardoj mentioned this pull request Apr 19, 2023

[HOLD][$1000] Web- Preferences - The recent mode description is truncated in Spanish preference #17509

Closed

6 tasks

abdulrahuman5196 mentioned this pull request Apr 24, 2023

Ignoring invalid text style warnings #17908

Merged

56 tasks

Julesssss mentioned this pull request Apr 28, 2023

[HOLD for payment 2023-09-04] [$4000] Keyboard shows again briefly when clicking "Add attachment" while the composer is focused #13922

Closed

2 tasks

priyeshshah11 mentioned this pull request May 3, 2023

Disables the Button during onPress call in PressableWithFeedback #18122

Merged

57 tasks

Conversation

priyeshshah11 commented Feb 14, 2023 • edited by mountiny Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

Santhosh-Sellavel commented Feb 14, 2023

Uh oh!

priyeshshah11 commented Feb 14, 2023

Uh oh!

roryabraham left a comment

Choose a reason for hiding this comment

Uh oh!

roryabraham left a comment

Choose a reason for hiding this comment

Uh oh!

priyeshshah11 commented Feb 17, 2023

Uh oh!

priyeshshah11 Feb 18, 2023

Choose a reason for hiding this comment

Uh oh!

priyeshshah11 Feb 18, 2023

Choose a reason for hiding this comment

Uh oh!

priyeshshah11 Feb 18, 2023

Choose a reason for hiding this comment

Uh oh!

priyeshshah11 Feb 24, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

MelvinBot commented Feb 18, 2023

Uh oh!

priyeshshah11 commented Feb 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

abdulrahuman5196 commented Feb 19, 2023

Uh oh!

priyeshshah11 commented Feb 20, 2023

Uh oh!

abdulrahuman5196 commented Feb 20, 2023

Uh oh!

priyeshshah11 commented Feb 20, 2023

Uh oh!

abdulrahuman5196 commented Feb 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

abdulrahuman5196 commented Feb 21, 2023

Uh oh!

aimane-chnaif commented Apr 11, 2023

Uh oh!

OSBotify commented Apr 11, 2023

Uh oh!

priyeshshah11 commented Apr 11, 2023

Uh oh!

aimane-chnaif commented Apr 11, 2023

Uh oh!

mountiny commented Apr 11, 2023

Uh oh!

aimane-chnaif commented Apr 11, 2023

Uh oh!

mountiny commented Apr 11, 2023

Uh oh!

aimane-chnaif left a comment

Choose a reason for hiding this comment

Reviewer Checklist

Screenshots/Videos

Uh oh!

priyeshshah11 commented Feb 14, 2023 •

edited by mountiny

Loading

priyeshshah11 commented Feb 18, 2023 •

edited

Loading

abdulrahuman5196 commented Feb 21, 2023 •

edited

Loading