LHN - Chat with draft message and pending request doesn't jump to the top of the LHN

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when executing PR #12761

Action Performed:

Preconditions: Some chats with pending money requests are present in the LHN for User

1. Open the app and sign in
2. Pin a chat that's not at the top of your LHN to the top. It should appear there and stay there upon refresh/log out log back in.
3. Verify that it appears at the top of the LHN
4. Start writing a draft comment in a different chat with the pending money request
5. Verify that the chat jumps to the top of the LHN (but below the pinned chat)

Expected Result:

Chat jumps to the top of the LHN (but below the pinned chat)

Actual Result:

Chat with draft message and pending request doesn't jump to the top of the LHN

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.2.32.1

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5837469_12761_Desktop.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01aaf83e461b602c57
• Upwork Job ID: 1597558699941490688

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[allroundexperts]

Proposal

We just need to change the order of how different policy groups are displayed.

Fix

It's specifically mentioned in the comments in code that IOU outstanding chats should have a higher preference than the draft messages. So I'm not sure if this is a bug. If it is, then, the following changes:

diff --git a/src/libs/SidebarUtils.js b/src/libs/SidebarUtils.js
index 0a0f35531..da4a811e0 100644
--- a/src/libs/SidebarUtils.js
+++ b/src/libs/SidebarUtils.js
@@ -166,8 +166,8 @@ function getOrderedReportIDs(reportIDFromRoute) {
     // The order the arrays are concatenated in matters and will determine the order that the groups are displayed in the sidebar.
     return _.pluck([]
         .concat(pinnedReports)
-        .concat(outstandingIOUReports)
         .concat(draftReports)
+        .concat(outstandingIOUReports)
         .concat(nonArchivedReports)
         .concat(archivedReports), 'reportID');
 }

Result

Screen.Recording.2022-11-28.at.4.11.15.PM.mov

[melvin-bot]

Current assignee @isabelastisser is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01aaf83e461b602c57

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)