Skip to content

Support for Symfony 5 & Twig 3 #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
GwendolenLynch wants to merge 3 commits into from
Closed

Support for Symfony 5 & Twig 3 #66

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bdb559f
Update Composer constraints
GwendolenLynch Nov 28, 2019
ab87057
Add required type hints
GwendolenLynch Nov 28, 2019
c2b7342
Add 7.2, 7.3 & 7.4 to Travis build
GwendolenLynch Nov 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
language: php
php:
- '7.1'
- '7.2'
- '7.3'
- '7.4snapshot'
install: composer install
script: php vendor/bin/phpunit
10 changes: 1 addition & 9 deletions Form/TypeExtension/HTMLPurifierTextTypeExtension.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,15 +23,7 @@ public function __construct(HTMLPurifiersRegistryInterface $registry)
/**
* {@inheritdoc}
*/
public function getExtendedType()
{
return TextType::class;
}

/**
* {@inheritdoc}
*/
public static function getExtendedTypes()
public static function getExtendedTypes(): iterable
{
return [TextType::class];
}
Expand Down
2 changes: 1 addition & 1 deletion Tests/Form/TypeExtension/HTMLPurifierTextTypeExtensionTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ class HTMLPurifierTextTypeExtensionTest extends FormIntegrationTestCase
{
private $registry;

protected function setUp()
protected function setUp(): void
{
$this->registry = $this->createMock(HTMLPurifiersRegistryInterface::class);

Expand Down
12 changes: 6 additions & 6 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,16 +9,16 @@
{ "name": "contributors", "homepage": "https://github.com/Exercise/HTMLPurifierBundle/contributors" }
],
"require": {
"php": "^5.5.9|>=7.0.8",
"php": "^7.1.3",
"ezyang/htmlpurifier": "~4.0",
"symfony/dependency-injection": "~3.4.1 || ^4.0.1",
"symfony/http-kernel": "~3.4.1 || ^4.0.1",
"symfony/config": "~3.3 || ~4.0"
"symfony/dependency-injection": "^4.2 || ^5.0",
"symfony/http-kernel": "^4.2 || ^5.0",
"symfony/config": "^4.2 || ^5.0"
},
"require-dev": {
"phpunit/phpunit": "^7.2",
"symfony/form": "~3.4.1 || ^4.0.1",
"twig/twig": "^1.34.4 || ^2.4.3"
"symfony/form": "^4.2 || ^5.0",
"twig/twig": "^1.34.4 || ^2.4.3 || ^3.0"
},
"extra": {
"branch-alias": {
Expand Down