Skip to content

Support for Symfony 5 & Twig 3#66

Closed
GwendolenLynch wants to merge 3 commits intoExercise:masterfrom
GwendolenLynch:symfony-5
Closed

Support for Symfony 5 & Twig 3#66
GwendolenLynch wants to merge 3 commits intoExercise:masterfrom
GwendolenLynch:symfony-5

Conversation

@GwendolenLynch
Copy link
Copy Markdown

  • Update minimum PHP to ^7.1.3
  • Update Composer constraints
    • Drop Symfony ^3
    • Raise Symfony 4 to ^4.2
    • Add Symfony ^5.0
    • Add Twig ^3.0
  • Add required type hints
  • Add 7.2, 7.3 & 7.4 to Travis build

- Drop Symfony ^3
- Raise Symfony 4 to ^4.2
- Add Symfony ^5.0
- Add Twig ^3.0
@tyloo
Copy link
Copy Markdown

tyloo commented Nov 29, 2019

Thanks a lot @GawainLynch !

@HeahDude
Copy link
Copy Markdown
Collaborator

Hello @GawainLynch, thank you for opening this PR.

Using a minimum requirement of 7.1 should be done in a new major version, so I propose to do it as part of #52 instead, I can add type hints there because it is also a BC break .

Even then we don't need to drop support for Symfony 3.4 as long as we can keep compatibility since this is an LTS and I ensured a wide compatibility by updating both travis and the tests in #69 targeting a new 2.0 release this week-end.

So I'm closing here, thank you again and and don't hesitate to send a PR again :).

Cheers!

@HeahDude HeahDude closed this Dec 14, 2019
@GwendolenLynch GwendolenLynch deleted the symfony-5 branch January 15, 2020 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants