Support for Symfony 5 & Twig 3#66
Closed
GwendolenLynch wants to merge 3 commits intoExercise:masterfrom
Closed
Conversation
GwendolenLynch
commented
Nov 28, 2019
- Update minimum PHP to ^7.1.3
- Update Composer constraints
- Drop Symfony ^3
- Raise Symfony 4 to ^4.2
- Add Symfony ^5.0
- Add Twig ^3.0
- Add required type hints
- Add 7.2, 7.3 & 7.4 to Travis build
- Drop Symfony ^3 - Raise Symfony 4 to ^4.2 - Add Symfony ^5.0 - Add Twig ^3.0
|
Thanks a lot @GawainLynch ! |
Collaborator
|
Hello @GawainLynch, thank you for opening this PR. Using a minimum requirement of 7.1 should be done in a new major version, so I propose to do it as part of #52 instead, I can add type hints there because it is also a BC break . Even then we don't need to drop support for Symfony 3.4 as long as we can keep compatibility since this is an LTS and I ensured a wide compatibility by updating both travis and the tests in #69 targeting a new 2.0 release this week-end. So I'm closing here, thank you again and and don't hesitate to send a PR again :). Cheers! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.