Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/rust.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
- rust: nightly
env:
DUMMY: true
- rust: 1.29.0
- rust: 1.36.0
env:
PIN_VERSIONS: true
steps:
Expand Down
12 changes: 1 addition & 11 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,15 +9,5 @@ structures and network messages related to Elements


## Minimum Supported Rust Version (MSRV)
This library should always compile with any combination of features on **Rust 1.29**.

Because some dependencies have broken the build in minor/patch releases, to
compile with 1.29.0 you will need to run the following version-pinning command:
```
cargo update -p cc --precise "1.0.41" --verbose
```
In order to have serde support, the following versions also need to be pinned:
```
cargo update --package "serde" --precise "1.0.98"
cargo update --package "serde_derive" --precise "1.0.98"
```
This library should always compile with any combination of features on **Rust 1.36**.
13 changes: 0 additions & 13 deletions contrib/test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -2,19 +2,6 @@

FEATURES="serde-feature"

pin_common_verions() {
cargo generate-lockfile --verbose
cargo update -p cc --precise "1.0.41" --verbose
cargo update -p serde --precise "1.0.98" --verbose
cargo update -p serde_derive --precise "1.0.98" --verbose
}

# Pin `cc` for Rust 1.29
if [ -n "$PIN_VERSIONS" ]; then
pin_common_verions
fi


# Use toolchain if explicitly specified
if [ -n "$TOOLCHAIN" ]
then
Expand Down
4 changes: 0 additions & 4 deletions src/address.rs
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,6 @@ use std::error;
use std::fmt;
use std::str::FromStr;

// AsciiExt is needed until for Rust 1.26 but not for newer versions
#[allow(unused_imports, deprecated)]
use std::ascii::AsciiExt;

use bitcoin::bech32::{self, u5, FromBase32, ToBase32};
use bitcoin::util::base58;
use bitcoin::PublicKey;
Expand Down
4 changes: 0 additions & 4 deletions src/blech32.rs
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,6 @@

use std::fmt;

// AsciiExt is needed until for Rust 1.26 but not for newer versions
#[allow(unused_imports, deprecated)]
use std::ascii::AsciiExt;

use bitcoin::bech32::{u5, Error};

/// Encode a bech32 payload to an [fmt::Formatter].
Expand Down