upgrade MSRV to 1.36#109
Merged
stevenroose merged 1 commit intoElementsProject:masterfrom Dec 9, 2021
Merged
Conversation
Merged
Contributor
|
Hmm, it looks like GitHub is expecting a report from the old 1.29 CI job. Not sure how we can make the new 1.36 one "required" and the other one go away. I'm just going to try merge it and hope that it "learns" from that and adapts for the next MRs. |
RCasatta
added a commit
that referenced
this pull request
Dec 15, 2021
31dd6bc PSET integration test with elements_core. (Riccardo Casatta) Pull request description: ~~on top of #100, see only 488cdac (MERGED)~~ ~~on top of #109 (MERGED)~~ I would like to introduce some PSET integration testing against elements core. To do so in a easy/maintainable/isolated way, I added the elementsd crate as a dev dependency. This crate downloads the node binary if a feature is specified (or allow to specify the executable via env var) I would like to gather early feedback on this approach before implementing the other cases: blinded, issuance, reissueance, pegin. ACKs for top commit: sanket1729: code review ACK 31dd6bc Tree-SHA512: bb3fad51ac536bdb9c82c28125f4d4634c9584b7babaee75581a9b8cb5591037bfa917c4cf36e395e6b9ff44ae71cdbc6e455271ba85db1d640e182c7b5904f6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.