fix: unblinded re/issuance for non-policy asset greater than 21 million#1445
Merged
delta1 merged 6 commits intoElementsProject:masterfrom Sep 23, 2025
Merged
fix: unblinded re/issuance for non-policy asset greater than 21 million#1445delta1 merged 6 commits intoElementsProject:masterfrom
delta1 merged 6 commits intoElementsProject:masterfrom
Conversation
Member
delta1
commented
Apr 3, 2025
- test: add test for unblinded re/issuance greater than 21 million
- fix: unblinded re/issuance for greater than 21 million
Co-authored-by: Mihailo Milenkovic <mihailo.milenkovic84@gmail.com>
Co-authored-by: Mihailo Milenkovic <mihailo.milenkovic84@gmail.com>
Member
Author
|
closes #1443 |
Member
|
utACK d3502ce |
Member
|
utACK d3502ce -- though this is a hardforking change and we need to be careful about where/how we deploy it. |
Member
|
Updated to enable this with a consensus parameter ( |
Member
|
Modified to remove This is technically a hard fork, but can be released safely in advance so long as block signers apply |
883c5c9 to
fc82dbc
Compare
fc82dbc to
0c6faca
Compare
41f3833 to
2b7dd1a
Compare
tomt1664
approved these changes
Sep 22, 2025
delta1
commented
Sep 23, 2025
|
|
||
| std::vector<std::string> elements_hidden_args = {"-con_fpowallowmindifficultyblocks", "-con_fpownoretargeting", "-con_nsubsidyhalvinginterval", "-con_bip16exception", "-con_bip34height", "-con_bip65height", "-con_bip66height", "-con_npowtargettimespan", "-con_npowtargetspacing", "-con_nrulechangeactivationthreshold", "-con_nminerconfirmationwindow", "-con_powlimit", "-con_bip34hash", "-con_nminimumchainwork", "-con_defaultassumevalid", "-npruneafterheight", "-fdefaultconsistencychecks", "-fmineblocksondemand", "-fallback_fee_enabled", "-pchmessagestart"}; | ||
|
|
||
| argsman.AddArg("-acceptunlimitedissuances", strprintf("Relay and mine unblinded issuance transactions (default: %u)", DEFAULT_ACCEPT_UNLIMITED_ISSUANCES), ArgsManager::ALLOW_ANY, OptionsCategory::ELEMENTS); |
Member
Author
There was a problem hiding this comment.
Minor, can be done in followup: I think this could be slightly more descriptive
Suggested change
| argsman.AddArg("-acceptunlimitedissuances", strprintf("Relay and mine unblinded issuance transactions (default: %u)", DEFAULT_ACCEPT_UNLIMITED_ISSUANCES), ArgsManager::ALLOW_ANY, OptionsCategory::ELEMENTS); | |
| argsman.AddArg("-acceptunlimitedissuances", strprintf("Allow unblinded issuance amounts to exceed 21 million units (default: %u)", DEFAULT_ACCEPT_UNLIMITED_ISSUANCES), ArgsManager::ALLOW_ANY, OptionsCategory::ELEMENTS); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.