Fix: Issueasset tx with blind parameter false is not accepted after t…#1444
Closed
Mixa84 wants to merge 2 commits intoElementsProject:elements-23.xfrom
Closed
Fix: Issueasset tx with blind parameter false is not accepted after t…#1444Mixa84 wants to merge 2 commits intoElementsProject:elements-23.xfrom
Mixa84 wants to merge 2 commits intoElementsProject:elements-23.xfrom
Conversation
…he change for more than 21M ElementsProject#1443
Member
|
It is a bit less invasive to just get the params where we need them as in #1445 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1443
The fix is done by passing the consensus params to
CheckTxInputs(), VerifyAmounts() and VerifyIssuanceAmount()in order to have the pegged asset in the last one. I thought to pass the whole params if anything else will be needed later, but it could also be to pass pegged_asset only toVerifyAmounts() and VerifyIssuanceAmount.Adapted the test also to check for unblinded issuance and that it is working correctly.
Appreciate the review and feel free to suggest any different approach if this one is not suitable.
@delta1 @psgreco