Compare BeamlineConfiguration using derived Eq/PartialEq#91
Merged
Conversation
Instead of comparing each field individually. Adds a bit of boilerplate in terms of derives etc, but reduces need for duplicated blocks of testing code when there are multiple tests comparing configurations.
3e3bd02 to
8169916
Compare
abbiemery
approved these changes
Feb 12, 2025
abbiemery
left a comment
Contributor
There was a problem hiding this comment.
I like this, it looks much nicer now and cuts down lots of repeated code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of comparing each field individually. Adds a bit of boilerplate
in terms of derives etc, but reduces need for duplicated blocks of
testing code when there are multiple tests comparing configurations.