Standardise name of tracker_file_extension#57
Merged
Merged
Conversation
Collaborator
Author
|
This should be merged before #54 which should then be updated to also use |
254f2e2 to
97a262b
Compare
DiamondJoseph
previously approved these changes
Jan 17, 2025
DiamondJoseph
left a comment
Contributor
There was a problem hiding this comment.
from what I understand and to sign off on naming
97a262b to
307733e
Compare
Instead of using fallback_extension and extension in different places. This is the file used by the GDA numtracker and should not be confused with any extension used for the scan files generated by the service.
307733e to
fd43231
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of using fallback_extension and extension in different places. This is the file used by the GDA numtracker and should not be confused with any extension used for the scan files generated by the service.