Add fileExtension to configuration query#54
Conversation
|
More naming-is-difficult decisions. I'm not sure whether it should be Thoughts @callumforrester, @DiamondJoseph ? |
|
My concern here is that we may be dealing with systems that decide their own file extensions rather than letting us decide for them. For example a detector that can only write TIFFs, or that we're just coupling ourselves to nexus when a beamline might want multiple archive formats (I think B23 is like this?), but I may be misunderstanding. |
That's what I was worried about but I'm not sure what would make it less ambiguous. The file extension is nothing to do with data files being written. It is the extension of the number file GDA creates in its var directory, eg |
|
It's just called |
|
If it's always going to be a number then we could copy ophyd-async and AreaDetector and call it |
|
It's not going to be a number. In most cases it would be the beamline name, but occasionally it's something like |
callumforrester
left a comment
There was a problem hiding this comment.
Happy with that then, although I'm not sure I have a sufficient understanding of how GDA var works to review this properly
To avoid the method name clash between graphQL object impl and 'normal' impl, the tracker_file_extension field has been made public and accessed directly wherever it's used.
dca1b14 to
3c7afc9
Compare
Fixes #52