fix: #680 PostgreSQL statements split implemented#19
Merged
droyad merged 4 commits intoDec 10, 2024
Conversation
Co-authored-by: shokurov <egor.shokurov@gmail.com>
31cb389 to
e70e9c7
Compare
Member
|
From what I can see this is a change in behaviour (for the better). Putting this into the upcoming v6 release. We'll publish a beta of the provider once this merges that includes this change so it can be tried out. |
8 tasks
shokurov
approved these changes
Oct 8, 2024
shokurov
approved these changes
Oct 8, 2024
shokurov
left a comment
Contributor
There was a problem hiding this comment.
Seems to be accurate copy of DbUp/DbUp#750
droyad
previously approved these changes
Dec 10, 2024
# Conflicts: # src/Tests/ApprovalFiles/NoPublicApiChanges.Run.approved.cs
|
I'm surprised that both this PR #680 and DbUp/DbUp#750 do not include an acknowledgement of authorship. The SQL splitter code comes from the That's why why my PR (DbUp/DbUp#673, which both #680 and #750 are derived from) includes the npgsql license file, as legally required by the npgsql project. |
Member
|
@webcoyote Yes, you are right. #25 |
droyad
added a commit
that referenced
this pull request
Mar 3, 2025
* Add NpgsqlDataSource support to PostgresqlConnectionManager * Used new GHA workflows * Updated to dbup-core 6.0 beta, targeted netstandard2 and update Npgsql reference * Bump to the next beta of dbup-core * Merge fix * Removed stray #If * fix: #680 PostgreSQL statements split implemented (#19) * fix: #680 PostgreSQL statements split implemented Co-authored-by: shokurov <egor.shokurov@gmail.com> * Updated approval file --------- Co-authored-by: shokurov <egor.shokurov@gmail.com> Co-authored-by: Robert Wagner <robert@wagner.id.au> * Update of libs * File scoped namespaces and primary ctors * Target `net8` so we can use the latest version of Npgsql (#24) * Target net8 so we can use the latest version of Npgsql * Used new APIs * Added Npgsql licence information (#25) * fix(#26): avoid NullReferenceException when creating database (#27) * fix(#26): avoid NullReferenceException when creating database * Updated approval file --------- Co-authored-by: Robert Wagner <robert@wagner.id.au> * fix: fix delimiter parsing (#28) * Lowered Connection string printing to debug, resolves #30 --------- Co-authored-by: Sébastien Crocquesel <88554524+scrocquesel@users.noreply.github.com> Co-authored-by: Campbell Harding-Deason <campbell.harding-deason@firstaml.com> Co-authored-by: shokurov <egor.shokurov@gmail.com> Co-authored-by: nvierge-addactis <151941872+nvierge-addactis@users.noreply.github.com>
This was referenced Oct 6, 2025
This was referenced Dec 1, 2025
This was referenced Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Copied from @shokurov's PR here: DbUp/DbUp#750
Fixes #10