Skip to content

Add the default baseHref value to angular.json#1699

Merged
tdonohue merged 1 commit intoDSpace:mainfrom
atmire:add-default-basehref-to-angular-json
Jun 22, 2022
Merged

Add the default baseHref value to angular.json#1699
tdonohue merged 1 commit intoDSpace:mainfrom
atmire:add-default-basehref-to-angular-json

Conversation

@artlowel
Copy link
Copy Markdown
Member

References

Description

If you run yarn run start:dev you'll see that the baseHref in your config is automatically added to angular.json. As a result angular.json almost always have a change when you commit.

This PR adds the default baseHref of / to angular.json to ensure that change only occurs when you use a custom nameSpace in your dev config.

Checklist

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes TSLint validation using yarn run lint
  • My PR doesn't introduce circular dependencies
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • If my PR includes new, third-party dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.

@artlowel artlowel self-assigned this Jun 22, 2022
@artlowel artlowel added the 1 APPROVAL pull request only requires a single approval to merge label Jun 22, 2022
@artlowel artlowel requested review from a user, atarix83 and tdonohue June 22, 2022 14:18
@artlowel artlowel added this to the 7.3 milestone Jun 22, 2022
Copy link
Copy Markdown
Contributor

@atarix83 atarix83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @artlowel it works as expected

Copy link
Copy Markdown
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me too. Also tested in prod mode and verified that subpaths still work (i.e. #1642)

@tdonohue tdonohue merged commit 815788b into DSpace:main Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge high priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants