This repository was archived by the owner on Feb 25, 2026. It is now read-only.
BitmapIconSource extension#3334
Merged
michael-hawker merged 6 commits intoCommunityToolkit:masterfrom Jun 7, 2020
Merged
Conversation
|
Thanks Sergio0694 for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
7 tasks
michael-hawker
approved these changes
Jun 6, 2020
marcelwgn
reviewed
Jun 6, 2020
Microsoft.Toolkit.Uwp.SampleApp/SamplePages/IconExtensions/IconExtensionsXaml.bind
Show resolved
Hide resolved
Member
|
This was an oversight on a missing API for completeness found during our doc review here, which we should have gotten to a bit sooner outside of our other circumstances. I think this is a good improvement to make now vs. later, and we've got a bit more stabilization time now too. Will commit PR as we have @chingucoding's review as well, thanks for jumping in! 🦙❤ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up for #3110 and #3129
PR Type
What kind of change does this PR introduce?
What is the current behavior?
There was no extension for
BitmapIconSource.Also the
SymbolIconwere using the wrong name for theGlyphproperty.What is the new behavior?
BitmapIconSourceextensionGlyphproperty toSymbolwhen using theSymboltype. This follows the naming of the actual originalSymbolIconclass from UWP.PR Checklist
Please check if your PR fulfills the following requirements: