This repository was archived by the owner on Feb 25, 2026. It is now read-only.
Fixed wrong icon extension being used in sample#3333
Closed
Sergio0694 wants to merge 1 commit intoCommunityToolkit:masterfrom
Closed
Fixed wrong icon extension being used in sample#3333Sergio0694 wants to merge 1 commit intoCommunityToolkit:masterfrom
Sergio0694 wants to merge 1 commit intoCommunityToolkit:masterfrom
Conversation
|
Thanks Sergio0694 for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
Member
|
@Sergio0694 this is going to conflict with #3334 Can you just add this update as part of that other PR? |
Member
Author
|
I had actually forgotten about this PR and I had fixed this again in the other one already 😄 We should be good then, closing this one! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sample page fix for #3110 and #3129
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Wrong extension used in the sample page
What is the new behavior?
Not wrong extension used in sample page 😄
PR Checklist
Please check if your PR fulfills the following requirements:
Pull Request has been submitted to the documentation repository instructions. Link:Sample in sample app has been added / updated (for bug fixes / features)Icon has been created (if new sample) following the Thumbnail Style Guide and templatesTests for the changes have been added (for bug fixes / features) (if applicable)Header has been added to all new source files (run build/UpdateHeaders.bat)