Skip to content

chore: run RPC checks online/offline in parallel#6837

Merged
LesnyRumcajs merged 3 commits into
mainfrom
parallel-rpc-check
Apr 2, 2026
Merged

chore: run RPC checks online/offline in parallel#6837
LesnyRumcajs merged 3 commits into
mainfrom
parallel-rpc-check

Conversation

@LesnyRumcajs
Copy link
Copy Markdown
Member

@LesnyRumcajs LesnyRumcajs commented Apr 1, 2026

Summary of changes

the new warpbuild machines are supposed to have 32 GB RAM - this should be enough to run both checks in parallel.

Changes introduced in this pull request:

  • make RPC check job run online/offline in parallel

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

Outside contributions

  • I have read and agree to the CONTRIBUTING document.
  • I have read and agree to the AI Policy document. I understand that failure to comply with the guidelines will lead to rejection of the pull request.

Summary by CodeRabbit

  • Chores
    • Optimized service startup sequence to improve deployment efficiency.

@LesnyRumcajs LesnyRumcajs requested a review from a team as a code owner April 1, 2026 12:53
@LesnyRumcajs LesnyRumcajs requested review from akaladarshi and hanabi1224 and removed request for a team April 1, 2026 12:53
@LesnyRumcajs LesnyRumcajs added the RPC requires calibnet RPC checks to run on CI label Apr 1, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 1, 2026

Walkthrough

This PR removes the api-compare service dependency from api-serve's depends_on configuration in Docker Compose. Previously, api-serve waited for api-compare to complete successfully before starting; now it starts independently without that constraint.

Changes

Cohort / File(s) Summary
Docker Compose Configuration
scripts/tests/api_compare/docker-compose.yml
Removed api-compare service dependency with condition: service_completed_successfully from api-serve's depends_on chain, allowing api-serve to start without waiting for api-compare completion.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • fix: RPC parity test failure #6813: Updates api-compare test service configuration including .env and filter-list-gateway scripts; complements this PR's dependency wiring changes.

Suggested reviewers

  • hanabi1224
  • akaladarshi
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title indicates running RPC checks in parallel, but the actual change removes a service dependency from docker-compose.yml, which is related but not the main point.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch parallel-rpc-check
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch parallel-rpc-check

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.84%. Comparing base (d8c8417) to head (2669c7d).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

see 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8c8417...2669c7d. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@LesnyRumcajs LesnyRumcajs enabled auto-merge April 2, 2026 07:43
@LesnyRumcajs LesnyRumcajs added this pull request to the merge queue Apr 2, 2026
Merged via the queue into main with commit 48752c7 Apr 2, 2026
35 checks passed
@LesnyRumcajs LesnyRumcajs deleted the parallel-rpc-check branch April 2, 2026 08:47
@coderabbitai coderabbitai Bot mentioned this pull request Apr 3, 2026
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

RPC requires calibnet RPC checks to run on CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants