Skip to content

fix: RPC parity test failure#6813

Merged
hanabi1224 merged 1 commit intomainfrom
hm/fix-rpc-test
Mar 30, 2026
Merged

fix: RPC parity test failure#6813
hanabi1224 merged 1 commit intomainfrom
hm/fix-rpc-test

Conversation

@hanabi1224
Copy link
Copy Markdown
Contributor

@hanabi1224 hanabi1224 commented Mar 29, 2026

Summary of changes

Changes introduced in this pull request:

Reference issue to close (if applicable)

Closes #6810

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

Outside contributions

  • I have read and agree to the CONTRIBUTING document.
  • I have read and agree to the AI Policy document. I understand that failure to comply with the guidelines will lead to rejection of the pull request.

Summary by CodeRabbit

  • Chores
    • Updated Lotus test environment to use container image version 1.35.1-rc1-calibnet, upgrading from 1.35.0-calibnet for API compatibility testing.
    • Expanded the list of unsupported API methods to include StateSearchMsg and EthGetTransactionReceiptLimited in the gateway filter configuration.

@hanabi1224 hanabi1224 added the RPC requires calibnet RPC checks to run on CI label Mar 29, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 29, 2026

Walkthrough

This PR updates the RPC parity test infrastructure by bumping the Lotus container image from v1.35.0-calibnet to v1.35.1-rc1-calibnet and adding two additional RPC methods (Filecoin.StateSearchMsg and Filecoin.EthGetTransactionReceiptLimited) to the filter-list-gateway's broken-method exclusions.

Changes

Cohort / File(s) Summary
API Compare Test Configuration
scripts/tests/api_compare/.env, scripts/tests/api_compare/filter-list-gateway
Updated Lotus image version from v1.35.0-calibnet to v1.35.1-rc1-calibnet; expanded broken RPC method exclusions with Filecoin.StateSearchMsg and Filecoin.EthGetTransactionReceiptLimited (both referencing Lotus PR #13562).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related issues

Possibly related PRs

Suggested reviewers

  • LesnyRumcajs
  • sudo-shashank
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix: RPC parity test failure' directly addresses the main objective of fixing an RPC parity test failure as stated in the linked issue.
Linked Issues check ✅ Passed The PR addresses the linked issue #6810 by fixing RPC parity test failures through updating the Lotus container image version and marking additional broken RPC methods.
Out of Scope Changes check ✅ Passed All changes (Lotus image version update and broken method exclusions) are directly related to fixing the RPC parity test failure referenced in issue #6810.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch hm/fix-rpc-test
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch hm/fix-rpc-test

Comment @coderabbitai help to get the list of available commands and usage tips.

@hanabi1224 hanabi1224 marked this pull request as ready for review March 29, 2026 23:02
@hanabi1224 hanabi1224 requested a review from a team as a code owner March 29, 2026 23:02
@hanabi1224 hanabi1224 requested review from LesnyRumcajs and sudo-shashank and removed request for a team March 29, 2026 23:02
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
scripts/tests/api_compare/filter-list-gateway (1)

61-61: Consider adding a reference comment for consistency.

The newly added broken methods have PR references, but EthGetFilterLogs lacks a comment explaining why it's marked as broken. For consistency and maintainability, consider adding a reference comment.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@scripts/tests/api_compare/filter-list-gateway` at line 61, Add a one-line
reference comment explaining why the EthGetFilterLogs entry is marked broken
(matching the style used for other broken methods); locate the EthGetFilterLogs
symbol in the filter-list-gateway file and add a comment with the PR number or
issue link and a short rationale (e.g., incompatible return type, unsupported on
this chain, or failing tests) so it matches the existing broken-method
annotations and improves maintainability.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@scripts/tests/api_compare/filter-list-gateway`:
- Line 61: Add a one-line reference comment explaining why the EthGetFilterLogs
entry is marked broken (matching the style used for other broken methods);
locate the EthGetFilterLogs symbol in the filter-list-gateway file and add a
comment with the PR number or issue link and a short rationale (e.g.,
incompatible return type, unsupported on this chain, or failing tests) so it
matches the existing broken-method annotations and improves maintainability.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: b3763314-ca26-4dcb-89b7-f63c8a3998ff

📥 Commits

Reviewing files that changed from the base of the PR and between 9a1fe93 and e97e976.

📒 Files selected for processing (2)
  • scripts/tests/api_compare/.env
  • scripts/tests/api_compare/filter-list-gateway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

RPC requires calibnet RPC checks to run on CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[automated] RPC parity test failure @ 28/3/26 00:56

2 participants