fix: RPC parity test failure#6813
Conversation
WalkthroughThis PR updates the RPC parity test infrastructure by bumping the Lotus container image from v1.35.0-calibnet to v1.35.1-rc1-calibnet and adding two additional RPC methods ( Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related issues
Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
scripts/tests/api_compare/filter-list-gateway (1)
61-61: Consider adding a reference comment for consistency.The newly added broken methods have PR references, but
EthGetFilterLogslacks a comment explaining why it's marked as broken. For consistency and maintainability, consider adding a reference comment.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@scripts/tests/api_compare/filter-list-gateway` at line 61, Add a one-line reference comment explaining why the EthGetFilterLogs entry is marked broken (matching the style used for other broken methods); locate the EthGetFilterLogs symbol in the filter-list-gateway file and add a comment with the PR number or issue link and a short rationale (e.g., incompatible return type, unsupported on this chain, or failing tests) so it matches the existing broken-method annotations and improves maintainability.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@scripts/tests/api_compare/filter-list-gateway`:
- Line 61: Add a one-line reference comment explaining why the EthGetFilterLogs
entry is marked broken (matching the style used for other broken methods);
locate the EthGetFilterLogs symbol in the filter-list-gateway file and add a
comment with the PR number or issue link and a short rationale (e.g.,
incompatible return type, unsupported on this chain, or failing tests) so it
matches the existing broken-method annotations and improves maintainability.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: b3763314-ca26-4dcb-89b7-f63c8a3998ff
📒 Files selected for processing (2)
scripts/tests/api_compare/.envscripts/tests/api_compare/filter-list-gateway
Summary of changes
Changes introduced in this pull request:
Reference issue to close (if applicable)
Closes #6810
Other information and links
Change checklist
Outside contributions
Summary by CodeRabbit
StateSearchMsgandEthGetTransactionReceiptLimitedin the gateway filter configuration.