This repository was archived by the owner on Mar 20, 2023. It is now read-only.
Bug fix for GPU : Patternstim shouldn't be copied from GPU to CPU #504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- patternstim is a special mechanism whose data is not copied on gpu - when we update whole GPU data back to CPU, we should skip the patternstim fixes #503
olupton
approved these changes
Mar 4, 2021
Contributor
olupton
left a comment
There was a problem hiding this comment.
LGTM.
When we update the CoreNEURON commit in NEURON we should remove these lines: https://github.com/neuronsimulator/nrn/blob/9f77cdc21855c6ac2fb8646bfca96dce13995777/test/external/testcorenrn/CMakeLists.txt#L34-L36
Maybe this is a good time to check if this exclusion is still valid: https://github.com/neuronsimulator/nrn/blob/9f77cdc21855c6ac2fb8646bfca96dce13995777/test/external/testcorenrn/CMakeLists.txt#L72-L73 ?
iomaganaris
approved these changes
Mar 4, 2021
olupton
added a commit
to neuronsimulator/nrn
that referenced
this pull request
Mar 4, 2021
- Bump CoreNEURON to commit including BlueBrain/CoreNeuron#502 and BlueBrain/CoreNeuron#504 - Enable the tests that were fixed by these PRs.
pramodk
pushed a commit
to neuronsimulator/nrn
that referenced
this pull request
Mar 4, 2021
- Bump CoreNEURON to commit including BlueBrain/CoreNeuron#502 and BlueBrain/CoreNeuron#504 - Enable the tests that were fixed by these PRs.
alexsavulescu
pushed a commit
to neuronsimulator/nrn
that referenced
this pull request
Apr 13, 2021
- Bump CoreNEURON to commit including BlueBrain/CoreNeuron#502 and BlueBrain/CoreNeuron#504 - Enable the tests that were fixed by these PRs.
alexsavulescu
pushed a commit
to neuronsimulator/nrn
that referenced
this pull request
Apr 30, 2021
- Bump CoreNEURON to commit including BlueBrain/CoreNeuron#502 and BlueBrain/CoreNeuron#504 - Enable the tests that were fixed by these PRs.
pramodk
added a commit
to neuronsimulator/nrn
that referenced
this pull request
Nov 2, 2022
…ueBrain/CoreNeuron#504) - patternstim is a special mechanism whose data is not copied on gpu - when we update whole GPU data back to CPU, we should skip the patternstim fixes BlueBrain/CoreNeuron#503 CoreNEURON Repo SHA: BlueBrain/CoreNeuron@db1a70d
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gpu
patternstim
fixes #503
CI_BRANCHES:NEURON_BRANCH=master,