This repository was archived by the owner on Mar 20, 2023. It is now read-only.
Bug fix for copying VecPlay's IvocVect object on GPU #502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olupton
approved these changes
Mar 4, 2021
Contributor
olupton
left a comment
There was a problem hiding this comment.
LGTM.
When this is merged we should update the submodule commit in NEURON and also remove this line: https://github.com/neuronsimulator/nrn/blob/9f77cdc21855c6ac2fb8646bfca96dce13995777/test/external/testcorenrn/CMakeLists.txt#L37 to enable the test.
iomaganaris
approved these changes
Mar 4, 2021
Collaborator
Author
|
(realised that I write bad commit message with some typos and missing words; I updated it now) |
olupton
added a commit
to neuronsimulator/nrn
that referenced
this pull request
Mar 4, 2021
- Bump CoreNEURON to commit including BlueBrain/CoreNeuron#502 and BlueBrain/CoreNeuron#504 - Enable the tests that were fixed by these PRs.
pramodk
pushed a commit
to neuronsimulator/nrn
that referenced
this pull request
Mar 4, 2021
- Bump CoreNEURON to commit including BlueBrain/CoreNeuron#502 and BlueBrain/CoreNeuron#504 - Enable the tests that were fixed by these PRs.
alexsavulescu
pushed a commit
to neuronsimulator/nrn
that referenced
this pull request
Apr 13, 2021
- Bump CoreNEURON to commit including BlueBrain/CoreNeuron#502 and BlueBrain/CoreNeuron#504 - Enable the tests that were fixed by these PRs.
alexsavulescu
pushed a commit
to neuronsimulator/nrn
that referenced
this pull request
Apr 30, 2021
- Bump CoreNEURON to commit including BlueBrain/CoreNeuron#502 and BlueBrain/CoreNeuron#504 - Enable the tests that were fixed by these PRs.
pramodk
added a commit
to neuronsimulator/nrn
that referenced
this pull request
Nov 2, 2022
…euron#502) - acc_memcpy_to_device is used to copy the device pointer - so we have to use an address of the device pointer and size of pointer ie. `sizeof(IvocVect*)` - note that IvocVect is already copied by previous acc_copyin call - this issue was introduced in BlueBrain/CoreNeuron#283 fixes BlueBrain/CoreNeuron#501 CoreNEURON Repo SHA: BlueBrain/CoreNeuron@b8d9fcd
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pointer ie.
sizeof(IvocVect*)fixes #501
See #501 for how to test this
CI_BRANCHES:NEURON_BRANCH=master,