Skip to content

Install work in python3.8 #11229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SabatierBoris wants to merge 3 commits into from
Closed

Install work in python3.8 #11229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4040afe
Use distro instead of platform for getting linux_distribution
SabatierBoris Nov 14, 2019
dbd6e4b
Update virtualenv for supporting python3.8
SabatierBoris Nov 14, 2019
e6a324a
Update HISTORY.rst
SabatierBoris Nov 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions scripts/curl_install_pypi/install.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
import shutil
import subprocess
import hashlib
import distro

@haroldrandom haroldrandom Nov 18, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Don't need to add dependency requirement and update *.py3.*.txt and setup.py?
  2. According to https://pypi.org/project/distro/ , "Distro currently supports Linux and BSD based systems but Windows and OS X support is also planned." What about Windows platform?

try:
# Attempt to load python 3 module
from urllib.request import urlopen
Expand All @@ -42,10 +43,10 @@
{install_dir}/bin/python -m azure.cli "$@"
"""

VIRTUALENV_VERSION = '15.0.0'
VIRTUALENV_VERSION = '16.7.7'
VIRTUALENV_ARCHIVE = 'virtualenv-'+VIRTUALENV_VERSION+'.tar.gz'
VIRTUALENV_DOWNLOAD_URL = 'https://pypi.python.org/packages/source/v/virtualenv/'+VIRTUALENV_ARCHIVE
VIRTUALENV_ARCHIVE_SHA256 = '70d63fb7e949d07aeb37f6ecc94e8b60671edb15b890aa86dba5dfaf2225dc19'
VIRTUALENV_ARCHIVE_SHA256 = 'd257bb3773e48cac60e475a19b608996c73f4d333b3ba2e4e57d5ac6134e0136'

DEFAULT_INSTALL_DIR = os.path.expanduser(os.path.join('~', 'lib', 'azure-cli'))
DEFAULT_EXEC_DIR = os.path.expanduser(os.path.join('~', 'bin'))
Expand Down Expand Up @@ -306,7 +307,7 @@ def _native_dependencies_for_dist(verify_cmd_args, install_cmd_args, dep_list):
raise CLIInstallError('Please install the native dependencies and try again.')

def verify_native_dependencies():
distname, version, _ = platform.linux_distribution()
distname, version, _ = distro.linux_distribution()
if not distname:
# There's no distribution name so can't determine native dependencies required / or they may not be needed like on OS X
return
Expand Down
3 changes: 3 additions & 0 deletions src/azure-cli/HISTORY.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@
Release History
===============

**Install**
* Install script support python 3.8

**Azure Red Hat OpenShift**

* Add `--workspace-resource-id` flag to allow creation of Azure Red Hat Openshift cluster with monitoring
Expand Down