Skip to content

Install work in python3.8#11229

Closed
SabatierBoris wants to merge 3 commits into
Azure:devfrom
SabatierBoris:install-python3.8
Closed

Install work in python3.8#11229
SabatierBoris wants to merge 3 commits into
Azure:devfrom
SabatierBoris:install-python3.8

Conversation

@SabatierBoris
Copy link
Copy Markdown

platform.linux_distribution is removed in python 3.8 a we should use distro package instead.


This checklist is used to make sure that common guidelines for a pull request are followed.

  • The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).

  • I adhere to the Command Guidelines.

@msftclas
Copy link
Copy Markdown

msftclas commented Nov 14, 2019

CLA assistant check
All CLA requirements met.

import shutil
import subprocess
import hashlib
import distro
Copy link
Copy Markdown
Contributor

@haroldrandom haroldrandom Nov 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Don't need to add dependency requirement and update *.py3.*.txt and setup.py?
  2. According to https://pypi.org/project/distro/ , "Distro currently supports Linux and BSD based systems but Windows and OS X support is also planned." What about Windows platform?

@haroldrandom
Copy link
Copy Markdown
Contributor

haroldrandom commented Nov 20, 2019

Hey, @SabatierBoris Thanks for you contribution!

We have received a lot issues about that installation problem. And sincerely considered your suggestion. distro is a really good alternative of platform.dist() and platform.linux_distribution(). And it's recommended by Python Offical Documentation.

However, the installation script is a bit irrational, done many things and its code is not so clean. We may refine that script in the future.
Also, considering we only need a small part of the functionality. we descided not to introduce distro into azure-cli. We fix that by a small simple alternative function, PR #11322.

But It's also possible that we will bring in distro in some days.

We did get inspired by your idea. Appreciated that.

@SabatierBoris SabatierBoris deleted the install-python3.8 branch November 21, 2019 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants