Install work in python3.8#11229
Conversation
| import shutil | ||
| import subprocess | ||
| import hashlib | ||
| import distro |
There was a problem hiding this comment.
- Don't need to add dependency requirement and update *.py3.*.txt and setup.py?
- According to https://pypi.org/project/distro/ , "Distro currently supports Linux and BSD based systems but Windows and OS X support is also planned." What about Windows platform?
|
Hey, @SabatierBoris Thanks for you contribution! We have received a lot issues about that installation problem. And sincerely considered your suggestion. distro is a really good alternative of However, the installation script is a bit irrational, done many things and its code is not so clean. We may refine that script in the future. But It's also possible that we will bring in distro in some days. We did get inspired by your idea. Appreciated that. |
platform.linux_distributionis removed in python 3.8 a we should use distro package instead.This checklist is used to make sure that common guidelines for a pull request are followed.
The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).
I adhere to the Command Guidelines.