This repository was archived by the owner on Oct 4, 2023. It is now read-only.
Install react-native-tiktok with patch#2659
Merged
Merged
Conversation
sliptype
approved these changes
Jan 23, 2023
sliptype
left a comment
Contributor
There was a problem hiding this comment.
Nice! So basically pinning the nested TikTokSdk dependency in react-native-tiktok right?
sliptype
reviewed
Jan 24, 2023
|
|
||
| -COCOAPODS: 1.10.1 | ||
| +COCOAPODS: 1.11.3 | ||
|
|
Contributor
There was a problem hiding this comment.
I think this line is an extra whitespace causing the patch to fail to apply. Removing it fixed things for me locally!
nicoback2
commented
Jan 24, 2023
|
|
||
| implementation project(':react-native-google-cast') | ||
|
|
||
| implementation 'com.bytedance.ies.ugc.aweme:opensdk-oversea-external:0.2.0.2' |
Contributor
Author
There was a problem hiding this comment.
@sliptype heads up had to change this line from when i first opened the PR to get the sdk working with android
Contributor
There was a problem hiding this comment.
Ok cool, I'm still in ios land so maybe this will be merged by the time i get to android!
Contributor
Author
There was a problem hiding this comment.
sweeet yeah will merge as soon as it passes CI so hopefully v soon
8e55752 to
26481cb
Compare
Co-authored-by: Nikki Kang <kangaroo233@gmail.com>
audius-infra
pushed a commit
that referenced
this pull request
Jan 28, 2023
[47b0ed1] Fix lineups not loading in Offline Mode (C-1945, C-1882, C-1803) (#2697) nicoback2 [da8637f] Add toggle for message notifs on web + mobile (#2700) Michelle Brier [f909c82] Remove use of iso3 country code (#2719) Reed [48ce610] Change location.in_eu to is_eu (#2718) Reed [a0fa651] [DMs] Update DMs store, sagas and selectors to be optimistic (#2711) Marcus Pasell [d62bc36] Fix popup menu on nav (#2717) Marcus Pasell [5b5e5ae] [C-1969 C-1967] Don't re-favorite playlist on download (#2713) Dylan Jeffers [1c02211] Port Input Component to Typescript - InputV2 (#2714) Marcus Pasell [5e6a8b8] [DMs] Show the name of the user that reacted when hovering over a reaction (#2587) Marcus Pasell [731539d] [C-1754] Fix modal popups not closing (#2691) Marcus Pasell [9f53712] Fix incorrect type for follower group in profile (#2705) Marcus Pasell [a664ba3] Update TextAreaV2 to respect initial height when non-growing (#2703) Marcus Pasell [75e9243] [DMs] Fix plus button not appearing on own messages (#2712) Marcus Pasell [f58e3fb] Change react-native-job-queue updateInterval to 500 ms (#2710) Sebastian Klingler [6d174ed] Update PopupMenu to not have circular icons (#2704) Marcus Pasell [613d992] [C-1891] Restart app on saga error, Refactor mobile toasts (#2696) Dylan Jeffers [a1293c6] Fix profile picture crash (#2698) Raymond Jacobson [3316525] Use 2-letter country codes in buy-audio location (#2695) Reed [e773823] Improve offline mode react performance (#2694) Sebastian Klingler [34c46c2] [PAY-878] Wrap getBalance in try/catch (#2692) Reed [067f249] Fix button alignment in rewards tiles (#2693) Reed [5b11226] Performance improvements for offline mode (#2690) Andrew Mendelsohn [778640f] Revert "Make rc-staging fast-app variant (#2585)" (#2689) Raymond Jacobson [6f24d1b] [C-1907, C-1928] Update chromecast icon in NowPlayingDrawer and track name length on track list items (#2688) Kyle Shanks [ef58833] C-1932 Hide playlists in offline mode with no downloaded tracks (#2686) nicoback2 [2d5a7cd] Fix content alignment in rewards tiles (#2687) Reed [16833c7] Remove ButtonWithArrow (#2682) Reed [8d88e1d] [PAY-871] Extend reward buttons to full tile width (#2683) Reed [82f5a9b] C-1908 Show error indicator on playlists if all track downloads failed (#2681) nicoback2 [70bb4de] Fix mobile error (#2685) nicoback2 [7d8b7aa] [DMs] Set max length of the composer to 10k (#2673) Marcus Pasell [084f23d] Install react-native-tiktok with patch (#2659) nicoback2 [70598db] Add queue length checks when skipping using the track player (#2675) Kyle Shanks [284b5c7] DMs: Add compose button (#2666) Marcus Pasell [c72fbba] [DMs] Add tails to chat bubbles (#2653) Marcus Pasell [f16eeb4] [DMs] Fix pagination for chat list and chat message list (#2652) Marcus Pasell [fd84793] Fix rewards claim button for aggregate challenges (#2671) Reed [2ecb9f5] Fix artwork for now-playing and playbar (#2674) Dylan Jeffers [604566e] [C-1884] Improve top supporters fetching and loading (#2651) Dylan Jeffers [c735486] Update SDK to 1.0.42 (#2668) Marcus Pasell [2654459] [C-1854] Prevent crash on settings page (#2667) Sebastian Klingler [df5e524] Listen to add succeeded (#2669) Saliou Diallo [55c4b64] [PAY-862] Rewards UI Improvements Followups (#2662) Reed [0ae57f7] [C-1894] [C-1904] Fix tiktok verification (#2665) Sebastian Klingler [21fb1a6] Fix profile (#2664) Saliou Diallo [8b8d350] Fix playlist tile click (#2663) Saliou Diallo [0d6a949] [C-1885] Improve user socials fetching/loading (#2650) Dylan Jeffers [9213f8f] [PAY-853] Premium content fixes on web (#2642) Saliou Diallo [c204e1b] Memoize sorted challenges (#2649) Reed [f7bfce0] [C-1874] Improve lineup loading animations, add fast-image (#2648) Dylan Jeffers [b7bd8bb] [C-1669] Enable OFFLINE_MODE_ENABLED feature flag (#2658) Andrew Mendelsohn [2601207] [C-1881] Allow removing downloads while offline (#2657) Andrew Mendelsohn [3a5f98c] [C-1879] Download track when added to downloaded playlists (#2656) Andrew Mendelsohn [d3de906] [C-1875] Fix empty favorited tracks lineup on reconnect (#2655) Andrew Mendelsohn [1ca06c1] Add explicit sizing to image fetching (#2566) Sebastian Klingler [66a56ea] [C-1876] Hide download indicator on deleted tracks (#2654) Sebastian Klingler [f78d1eb] Allow fetching by permalink on client desktop (#2610) sabrina-kiam
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Patch to fix the iOS build error for react-native-tiktok package
Dragons
Is there anything the reviewer should be on the lookout for? Are there any dangerous changes?
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.
How will this change be monitored?
For features that are critical or could fail silently please describe the monitoring/alerting being added.
Feature Flags
Are all new features properly feature flagged? Describe added feature flags.