[DMs] Fix pagination for chat list and chat message list by rickyrombo · Pull Request #2652 · AudiusProject/audius-client

rickyrombo · 2023-01-21T10:47:57Z

Description

Fixes pagination for chat list and chat message list so that they can infinitely load.

Adds a new component, StickyScrollList, to help achieve the scrolling behavior desired for the ChatMessagesList component. It keeps the user scrolled to the bottom if they're at the bottom, and doesn't let them get stuck to the top when loading history.

Dragons

Is there anything the reviewer should be on the lookout for? Are there any dangerous changes?

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.

How will this change be monitored?

For features that are critical or could fail silently please describe the monitoring/alerting being added.

Feature Flags

Are all new features properly feature flagged? Describe added feature flags.

gitguardian · 2023-01-23T23:04:34Z

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request

GitGuardian id	Secret	Commit	Filename
688750	Generic High Entropy Secret	`867f68a`	packages/mobile/.env.stage	View secret
2416684	Generic High Entropy Secret	`867f68a`	packages/mobile/.env.stage	View secret

🛠 Guidelines to remediate hardcoded secrets

Understand the implications of revoking this secret by investigating where it is used in your code.
Replace and store your secrets safely. Learn here the best practices.
Revoke and rotate these secrets.
If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

following these best practices for managing and storing secrets including API keys and other credentials
install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!}

rickyrombo · 2023-01-23T23:06:18Z

+
+import { mergeRefs } from 'react-merge-refs'
+
+type StickyScrollListProps = ComponentPropsWithoutRef<'div'> & {


@piazzatron look what i made! 😁

this is great

rickyrombo · 2023-01-23T23:08:57Z

+
+        // If re-initting something that's already loaded
+        // this will make us start from the bottom again after render
+        ref.current.scrollTo({ top: ref.current.scrollHeight })


It's a little biased towards my use case, but easily generalizable if need be

audius-infra · 2023-01-23T23:35:20Z

Preview this change https://demo.audius.co/mjp-dms-pagination

sddioulde

lgtm. assuming it's tested too

[47b0ed1] Fix lineups not loading in Offline Mode (C-1945, C-1882, C-1803) (#2697) nicoback2 [da8637f] Add toggle for message notifs on web + mobile (#2700) Michelle Brier [f909c82] Remove use of iso3 country code (#2719) Reed [48ce610] Change location.in_eu to is_eu (#2718) Reed [a0fa651] [DMs] Update DMs store, sagas and selectors to be optimistic (#2711) Marcus Pasell [d62bc36] Fix popup menu on nav (#2717) Marcus Pasell [5b5e5ae] [C-1969 C-1967] Don't re-favorite playlist on download (#2713) Dylan Jeffers [1c02211] Port Input Component to Typescript - InputV2 (#2714) Marcus Pasell [5e6a8b8] [DMs] Show the name of the user that reacted when hovering over a reaction (#2587) Marcus Pasell [731539d] [C-1754] Fix modal popups not closing (#2691) Marcus Pasell [9f53712] Fix incorrect type for follower group in profile (#2705) Marcus Pasell [a664ba3] Update TextAreaV2 to respect initial height when non-growing (#2703) Marcus Pasell [75e9243] [DMs] Fix plus button not appearing on own messages (#2712) Marcus Pasell [f58e3fb] Change react-native-job-queue updateInterval to 500 ms (#2710) Sebastian Klingler [6d174ed] Update PopupMenu to not have circular icons (#2704) Marcus Pasell [613d992] [C-1891] Restart app on saga error, Refactor mobile toasts (#2696) Dylan Jeffers [a1293c6] Fix profile picture crash (#2698) Raymond Jacobson [3316525] Use 2-letter country codes in buy-audio location (#2695) Reed [e773823] Improve offline mode react performance (#2694) Sebastian Klingler [34c46c2] [PAY-878] Wrap getBalance in try/catch (#2692) Reed [067f249] Fix button alignment in rewards tiles (#2693) Reed [5b11226] Performance improvements for offline mode (#2690) Andrew Mendelsohn [778640f] Revert "Make rc-staging fast-app variant (#2585)" (#2689) Raymond Jacobson [6f24d1b] [C-1907, C-1928] Update chromecast icon in NowPlayingDrawer and track name length on track list items (#2688) Kyle Shanks [ef58833] C-1932 Hide playlists in offline mode with no downloaded tracks (#2686) nicoback2 [2d5a7cd] Fix content alignment in rewards tiles (#2687) Reed [16833c7] Remove ButtonWithArrow (#2682) Reed [8d88e1d] [PAY-871] Extend reward buttons to full tile width (#2683) Reed [82f5a9b] C-1908 Show error indicator on playlists if all track downloads failed (#2681) nicoback2 [70bb4de] Fix mobile error (#2685) nicoback2 [7d8b7aa] [DMs] Set max length of the composer to 10k (#2673) Marcus Pasell [084f23d] Install react-native-tiktok with patch (#2659) nicoback2 [70598db] Add queue length checks when skipping using the track player (#2675) Kyle Shanks [284b5c7] DMs: Add compose button (#2666) Marcus Pasell [c72fbba] [DMs] Add tails to chat bubbles (#2653) Marcus Pasell [f16eeb4] [DMs] Fix pagination for chat list and chat message list (#2652) Marcus Pasell [fd84793] Fix rewards claim button for aggregate challenges (#2671) Reed [2ecb9f5] Fix artwork for now-playing and playbar (#2674) Dylan Jeffers [604566e] [C-1884] Improve top supporters fetching and loading (#2651) Dylan Jeffers [c735486] Update SDK to 1.0.42 (#2668) Marcus Pasell [2654459] [C-1854] Prevent crash on settings page (#2667) Sebastian Klingler [df5e524] Listen to add succeeded (#2669) Saliou Diallo [55c4b64] [PAY-862] Rewards UI Improvements Followups (#2662) Reed [0ae57f7] [C-1894] [C-1904] Fix tiktok verification (#2665) Sebastian Klingler [21fb1a6] Fix profile (#2664) Saliou Diallo [8b8d350] Fix playlist tile click (#2663) Saliou Diallo [0d6a949] [C-1885] Improve user socials fetching/loading (#2650) Dylan Jeffers [9213f8f] [PAY-853] Premium content fixes on web (#2642) Saliou Diallo [c204e1b] Memoize sorted challenges (#2649) Reed [f7bfce0] [C-1874] Improve lineup loading animations, add fast-image (#2648) Dylan Jeffers [b7bd8bb] [C-1669] Enable OFFLINE_MODE_ENABLED feature flag (#2658) Andrew Mendelsohn [2601207] [C-1881] Allow removing downloads while offline (#2657) Andrew Mendelsohn [3a5f98c] [C-1879] Download track when added to downloaded playlists (#2656) Andrew Mendelsohn [d3de906] [C-1875] Fix empty favorited tracks lineup on reconnect (#2655) Andrew Mendelsohn [1ca06c1] Add explicit sizing to image fetching (#2566) Sebastian Klingler [66a56ea] [C-1876] Hide download indicator on deleted tracks (#2654) Sebastian Klingler [f78d1eb] Allow fetching by permalink on client desktop (#2610) sabrina-kiam

rickyrombo added 3 commits January 21, 2023 01:19

Update client to paginate DMs and Chats properly

5aec9d7

Convert hook to HoC

28e35a7

use new comp

69d086b

pull-request-size Bot added the size/XL label Jan 21, 2023

rickyrombo added 2 commits January 23, 2023 14:56

Merge remote-tracking branch 'origin/main' into mjp-dms-pagination

867f68a

Add react-merge-refs

60fc40e

rickyrombo requested review from piazzatron and sddioulde January 23, 2023 23:05

rickyrombo assigned dylanjeffers and dharit-tan Jan 23, 2023

rickyrombo marked this pull request as ready for review January 23, 2023 23:05

rickyrombo commented Jan 23, 2023

View reviewed changes

sddioulde approved these changes Jan 24, 2023

View reviewed changes

Comment thread packages/common/src/store/pages/chat/slice.ts Outdated

Comment thread packages/web/src/pages/chat-page/components/ChatList.tsx Outdated

Add checks

d9893ad

rickyrombo merged commit f16eeb4 into main Jan 24, 2023

rickyrombo deleted the mjp-dms-pagination branch January 24, 2023 18:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[DMs] Fix pagination for chat list and chat message list#2652

[DMs] Fix pagination for chat list and chat message list#2652
rickyrombo merged 6 commits into
mainfrom
mjp-dms-pagination

rickyrombo commented Jan 21, 2023 •

edited

Loading

Uh oh!

gitguardian Bot commented Jan 23, 2023 •

edited

Loading

Uh oh!

rickyrombo Jan 23, 2023

Uh oh!

piazzatron Jan 23, 2023

Uh oh!

piazzatron Jan 23, 2023

Uh oh!

rickyrombo Jan 23, 2023

Uh oh!

audius-infra commented Jan 23, 2023

Uh oh!

sddioulde left a comment •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants


		import { mergeRefs } from 'react-merge-refs'

		type StickyScrollListProps = ComponentPropsWithoutRef<'div'> & {

Uh oh!

Conversation

rickyrombo commented Jan 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Dragons

How Has This Been Tested?

How will this change be monitored?

Feature Flags

Uh oh!

gitguardian Bot commented Jan 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Uh oh!

rickyrombo Jan 23, 2023

Choose a reason for hiding this comment

Uh oh!

piazzatron Jan 23, 2023

Choose a reason for hiding this comment

Uh oh!

piazzatron Jan 23, 2023

Choose a reason for hiding this comment

Uh oh!

rickyrombo Jan 23, 2023

Choose a reason for hiding this comment

Uh oh!

audius-infra commented Jan 23, 2023

Uh oh!

sddioulde left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

rickyrombo commented Jan 21, 2023 •

edited

Loading

gitguardian Bot commented Jan 23, 2023 •

edited

Loading

sddioulde left a comment •

edited

Loading