[C-1317] Improve client startup tooling by raymondjacobson · Pull Request #2140 · AudiusProject/audius-client

raymondjacobson · 2022-10-13T04:58:34Z

Description

Would love to hear how folks feel about this!

Realizes this vision, from the root of audius-client:

# setup
npm i # (now will do pod install)

# run web
npm run web:dev
npm run web:stage
npm run web:prod

# run desktop
# all of these spin up a local web-client and point electron at the running port
npm run desktop:dev
npm run desktop:stage
npm run desktop:prod

# run mobile
# all of these spin up the respective mobile env
npm run ios:dev
npm run ios:stage
npm run ios:prod
npm run android:dev
npm run android:stage
npm run android:prod

Dragons

Is there anything the reviewer should be on the lookout for? Are there any dangerous changes?

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.

Ran all the commands!

How will this change be monitored?

For features that are critical or could fail silently please describe the monitoring/alerting being added.

Feature Flags

Are all new features properly feature flagged? Describe added feature flags.

gitguardian · 2022-10-13T04:58:37Z

⚠️ GitGuardian has uncovered 6 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request

GitGuardian id	Secret	Commit	Filename
688750	Generic High Entropy Secret	`e72345e`	packages/mobile/.env.dev	View secret
2416684	Generic High Entropy Secret	`e72345e`	packages/mobile/.env.dev	View secret
2416685	Generic High Entropy Secret	`e72345e`	packages/mobile/.env.dev	View secret
2416686	Generic High Entropy Secret	`e72345e`	packages/mobile/.env.dev	View secret
2858199	Generic High Entropy Secret	`e72345e`	packages/mobile/.env.dev	View secret
3939057	Generic High Entropy Secret	`e72345e`	packages/mobile/.env.dev	View secret

🛠 Guidelines to remediate hardcoded secrets

Understand the implications of revoking this secret by investigating where it is used in your code.
Replace and store your secrets safely. Learn here the best practices.
Revoke and rotate these secrets.
If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

following these best practices for managing and storing secrets including API keys and other credentials
install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!}

nicoback2

I like it!

sliptype

Awesome! This will be so useful

sddioulde

sweet!

dylanjeffers

huge fan

amendelsohn · 2022-10-14T19:33:05Z

+npm run desktop:stage
+npm run desktop:prod
+
+# mobile (append -- --device to target a physical device)


Just tried this and it didn't default to my device. Only worked when I put -- --device "my iphone". The npm run ios:device command defaulted to the phone if connected

[5cd5d68] [C-1322] Android and general performance improvements (#2149) Sebastian Klingler [f6ef033] [C-1341] Add notifications bottom tab screen (#2148) Dylan Jeffers [9ddfe72] [C-1335] Upgrade and share typescript version (#2145) Dylan Jeffers [b701102] [C-1336] Implement account drawer (#2146) Dylan Jeffers [8587b3f] Add structured data and update head (#2131) Joseph Lee [40ef3b7] [C-1317] Improve client startup tooling (#2140) Raymond Jacobson [e09c6f9] Update new tables to allow drag to add to playlist (#2134) Kyle Shanks [4633581] Bump ios (#2144) Sebastian Klingler [f331426] Slow down $AUDIO page Stripe/Coinbase button animation speed (#2143) Marcus Pasell [44916a5] [C-1291] Add base layout for navbar overhaul (#2139) Dylan Jeffers [e85955c] Prepend audius url to share url (#2142) Sebastian Klingler [068917e] Use Hermes for Android app C-1329 (#2130) nicoback2 [98f845c] [C-1327] Fix deep linking for tracks with diacritics (#2137) Sebastian Klingler [0ec460f] [PAY-685] Update Stripe button to use approved brand assets (#2138) Marcus Pasell [1b1a377] Refactor bottom-tab-bar (#2136) Dylan Jeffers [9dbb11e] fix play bar buttons target (#2135) nicoback2 [9daba05] [C-1303][C-1304] Fix misc. profile layout issues (#2129) Raymond Jacobson [04eb0c9] [C-1272] Fix Search UI jank (#2133) Sebastian Klingler [feaa6f0] Bump react-screens to 3.17.0 to avoid crash on android (#2132) Sebastian Klingler [db996e8] Remove old table components and rename new table components (#2126) Kyle Shanks [92a2c7e] [C-1319] Fix native profile collectibles (#2127) Dylan Jeffers [7a83f29] [C-1282] Remove followUser social action in profile reducer (#2121) Dylan Jeffers [26de098] [C-1309] Fix playlists/collectibles not loading (#2125) Dylan Jeffers [78dee89] Fix getState undefined when opening reopening app on android (#2123) Sebastian Klingler [ef69b70] [C-1318] Revert "[C-1184] Fetch lineups after coming back online (#2083)" (#2122) Andrew Mendelsohn [42efd1b] [PAY-457] Add Geofilter for Coinbase, Stripe (#2118) Marcus Pasell [e413d9a] Bring back unhealthySlotDiffPlays (#2119) Dylan Jeffers [fb96ea4] Fix favorites page filtering on old tables (#2120) Kyle Shanks [cf73f53] Fix android build (#2113) Sebastian Klingler [ebaa5d8] [C-1040] Remove extraneous mobile logs (#2107) Dylan Jeffers [bc7e7b0] bump libs in web and common (#2117) nicoback2 [dc16dcb] bump libs 1.0.12 (#2116) nicoback2 [c737535] Undo change to prevent cache update when no collectibles (#2114) Sebastian Klingler [b2764ba] Keep screen awake when confirming tip (#2103) nicoback2 [4b39ec1] fix pw clipping on mobile (#2102) nicoback2

[C-1317] Improve client startup tooling

e72345e

pull-request-size Bot added the size/L label Oct 13, 2022

raymondjacobson requested review from Kyle-Shanks, amendelsohn, dharit-tan, dylanjeffers, nicoback2, piazzatron, rickyrombo, sddioulde and sliptype October 13, 2022 04:59

nicoback2 approved these changes Oct 13, 2022

View reviewed changes

Comment thread package.json Outdated

sliptype approved these changes Oct 13, 2022

View reviewed changes

Comment thread package.json Outdated

Comment thread package.json Outdated

Comment thread package.json Outdated

Comment thread package.json Outdated

sddioulde approved these changes Oct 13, 2022

View reviewed changes

dharit-tan approved these changes Oct 13, 2022

View reviewed changes

rickyrombo approved these changes Oct 13, 2022

View reviewed changes

dylanjeffers approved these changes Oct 13, 2022

View reviewed changes

raymondjacobson added 2 commits October 14, 2022 00:40

Address comments

893b5c1

Merge remote-tracking branch 'origin/main' into rj-c-1317

b5490a8

raymondjacobson force-pushed the rj-c-1317 branch from 6639bdd to b5490a8 Compare October 14, 2022 07:41

raymondjacobson added 3 commits October 14, 2022 00:54

Fix pod install

8992463

Fix pod install

8ea882e

Fix pod install again

a7d2238

raymondjacobson merged commit 40ef3b7 into main Oct 14, 2022

raymondjacobson deleted the rj-c-1317 branch October 14, 2022 08:30

amendelsohn reviewed Oct 14, 2022

View reviewed changes

AudiusProject deleted a comment from linear Bot Sep 11, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[C-1317] Improve client startup tooling#2140

[C-1317] Improve client startup tooling#2140
raymondjacobson merged 6 commits into
mainfrom
rj-c-1317

raymondjacobson commented Oct 13, 2022 •

edited

Loading

Uh oh!

gitguardian Bot commented Oct 13, 2022 •

edited

Loading

Uh oh!

nicoback2 left a comment

Uh oh!

Uh oh!

sliptype left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sddioulde left a comment

Uh oh!

dylanjeffers left a comment

Uh oh!

amendelsohn Oct 14, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Conversation

raymondjacobson commented Oct 13, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Dragons

How Has This Been Tested?

How will this change be monitored?

Feature Flags

Uh oh!

gitguardian Bot commented Oct 13, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ GitGuardian has uncovered 6 secrets following the scan of your pull request.

Uh oh!

nicoback2 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sliptype left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sddioulde left a comment

Choose a reason for hiding this comment

Uh oh!

dylanjeffers left a comment

Choose a reason for hiding this comment

Uh oh!

amendelsohn Oct 14, 2022

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

raymondjacobson commented Oct 13, 2022 •

edited

Loading

gitguardian Bot commented Oct 13, 2022 •

edited

Loading