This repository was archived by the owner on Oct 4, 2023. It is now read-only.
[C-1295] Update new tables to allow drag to add to playlist#2134
Merged
Kyle-Shanks merged 1 commit intoOct 13, 2022
Merged
Conversation
dylanjeffers
left a comment
Contributor
There was a problem hiding this comment.
Knowing nothing, is it stable to use index for drag-drop vs something like a key/id?
Collaborator
|
Preview this change https://demo.audius.co/kj-Update-new-tables-to-allow-drag-track-to-playlist |
Contributor
Author
Good thought. The index here is only being used in the new code that I added for the new tables and is only used for reorder logic, which has been stable so far for all of the testing. the track id will be used for the id prop and now matches the pattern that the other drag and drop components use around the app so this should work |
audius-infra
pushed a commit
that referenced
this pull request
Oct 15, 2022
[5cd5d68] [C-1322] Android and general performance improvements (#2149) Sebastian Klingler [f6ef033] [C-1341] Add notifications bottom tab screen (#2148) Dylan Jeffers [9ddfe72] [C-1335] Upgrade and share typescript version (#2145) Dylan Jeffers [b701102] [C-1336] Implement account drawer (#2146) Dylan Jeffers [8587b3f] Add structured data and update head (#2131) Joseph Lee [40ef3b7] [C-1317] Improve client startup tooling (#2140) Raymond Jacobson [e09c6f9] Update new tables to allow drag to add to playlist (#2134) Kyle Shanks [4633581] Bump ios (#2144) Sebastian Klingler [f331426] Slow down $AUDIO page Stripe/Coinbase button animation speed (#2143) Marcus Pasell [44916a5] [C-1291] Add base layout for navbar overhaul (#2139) Dylan Jeffers [e85955c] Prepend audius url to share url (#2142) Sebastian Klingler [068917e] Use Hermes for Android app C-1329 (#2130) nicoback2 [98f845c] [C-1327] Fix deep linking for tracks with diacritics (#2137) Sebastian Klingler [0ec460f] [PAY-685] Update Stripe button to use approved brand assets (#2138) Marcus Pasell [1b1a377] Refactor bottom-tab-bar (#2136) Dylan Jeffers [9dbb11e] fix play bar buttons target (#2135) nicoback2 [9daba05] [C-1303][C-1304] Fix misc. profile layout issues (#2129) Raymond Jacobson [04eb0c9] [C-1272] Fix Search UI jank (#2133) Sebastian Klingler [feaa6f0] Bump react-screens to 3.17.0 to avoid crash on android (#2132) Sebastian Klingler [db996e8] Remove old table components and rename new table components (#2126) Kyle Shanks [92a2c7e] [C-1319] Fix native profile collectibles (#2127) Dylan Jeffers [7a83f29] [C-1282] Remove followUser social action in profile reducer (#2121) Dylan Jeffers [26de098] [C-1309] Fix playlists/collectibles not loading (#2125) Dylan Jeffers [78dee89] Fix getState undefined when opening reopening app on android (#2123) Sebastian Klingler [ef69b70] [C-1318] Revert "[C-1184] Fetch lineups after coming back online (#2083)" (#2122) Andrew Mendelsohn [42efd1b] [PAY-457] Add Geofilter for Coinbase, Stripe (#2118) Marcus Pasell [e413d9a] Bring back unhealthySlotDiffPlays (#2119) Dylan Jeffers [fb96ea4] Fix favorites page filtering on old tables (#2120) Kyle Shanks [cf73f53] Fix android build (#2113) Sebastian Klingler [ebaa5d8] [C-1040] Remove extraneous mobile logs (#2107) Dylan Jeffers [bc7e7b0] bump libs in web and common (#2117) nicoback2 [dc16dcb] bump libs 1.0.12 (#2116) nicoback2 [c737535] Undo change to prevent cache update when no collectibles (#2114) Sebastian Klingler [b2764ba] Keep screen awake when confirming tip (#2103) nicoback2 [4b39ec1] fix pw clipping on mobile (#2102) nicoback2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Quick updates to allow tracks within new tables to be able to be dragged into playlists in the side nav
Dragons
N/A
How Has This Been Tested?
Manually tested
How will this change be monitored?
N/A
Feature Flags
N/A