This repository was archived by the owner on Oct 4, 2023. It is now read-only.
Fix @audius/common external warnings, model imports, lint#1767
Merged
Conversation
sliptype
approved these changes
Aug 22, 2022
sliptype
left a comment
Contributor
There was a problem hiding this comment.
Cool! Why is the models abs path change possible now? Is the plan to use absolute paths for all the directories
Contributor
Author
I think because we have node module resolve in tsconfig it just works. Basically there were already absolute model imports, so I just kept things consistent! |
Contributor
|
ooh thank you so much! @dylanjeffers did you run typecheck in web and mobile? curious because when i was using absolute imports, it broke a bunch of things there which is why I changed a bunch to relative. |
Contributor
Author
yeah i didnt.. checking it now though, yeah i think youre right. well at very least ill just keep the /index removal? will try to get to bottom though, cause there are existing absolute model imports there too, so not sure why those work :/ |
b2a2557 to
603f92f
Compare
audius-infra
pushed a commit
that referenced
this pull request
Aug 27, 2022
[ccf1ca9] [C-906] Migrate queue sagas and hls-utils to common (#1805) Dylan Jeffers [fe441af] Consume new Text Button in collapsible content (#1790) Marcus Pasell [2ee3b2d] Add error UI to InProgress page of BuyAudio modal (#1802) Marcus Pasell [139e50e] Add TextButton story (#1803) Marcus Pasell [a4d26cf] Add all the pages to the BuyAudioModal (#1800) Marcus Pasell [15dfb72] Update package.json (#1801) Raymond Jacobson [284431d] [C-817] Deep link /settings on mobile (#1796) Raymond Jacobson [2b7ca95] [PAY-44] Rename getAssociatedTokenAccountInfo and getUserBank (#1794) Reed [ff07bb4] [PAY-580] Add Success Page to BuyAudio Modal (#1791) Marcus Pasell [51269bb] [C-901] Move audioPlayer to saga context (#1797) Dylan Jeffers [dfc6f08] [C-900] Move queue, lineup, feed-page sagas to common (#1795) Dylan Jeffers [4f25517] [C-897] Add explore service to saga context (#1793) Dylan Jeffers [8cc3a29] Move sagaHelpers to common (#1792) Sebastian Klingler [8ee3aa8] Add Text Button type to Stems (#1789) Marcus Pasell [ff4f913] [PAY-552] Change playllenge challenge button text (#1787) Reed [60ed26a] Fix bug with renamed component (#1788) Marcus Pasell [718f35a] Dynamically resize ModalContentPages (#1785) Marcus Pasell [4903c9f] [PAY-577] Add "in progress" page to Buy Audio Modal (#1783) Marcus Pasell [72fc4fd] Migrate queue selectors to common (#1786) Dylan Jeffers [5f3e46e] [C-871] Migrate player state to common (#1784) Dylan Jeffers [8d77abf] [PAY-476] Display error when send to wallet fails (#1780) Reed [6adbdda] [PAY-575] [PAY-574] [PAY-573] [PAY-572] [PAY-581] Coinbase Pay Button and Rewards Page Fixes (#1778) Marcus Pasell [56c3f39] [PAY-458] Buy Audio Modal Input Page (#1777) Marcus Pasell [172d6c4] Cleans up code for Challenge Twitter icon fill color (#1781) Reed [bd1a329] Fix order playlist to use updated playlist (#1774) Isaac Solo [1f178bc] [C-887] Host sourcemaps on s3, fixes cloudflare deploy (#1776) Sebastian Klingler [0551dec] [PAY-571] Move Jupiter out of bundle, attach BuyAudio sagas (#1772) Marcus Pasell [db9cd4a] [C-890] Polyfill TextEncoder, fixes builds (#1775) Dylan Jeffers [de8c73a] Update @coinbase/cbpay-js to v1.2.0 and @solana/web3.js to 1.53.0 (#1773) Marcus Pasell [bdec4b7] Add entity manager address to configInternalWeb3 (#1763) nicoback2 [d3fae31] Wire up initial BuyAudioModal (#1770) Marcus Pasell [fc5e484] Add back modal hook functionality (#1769) Marcus Pasell [ae616cc] Fix @audius/common external warnings, model imports, lint (#1767) Dylan Jeffers [2a121e4] Add entity manager address for prod env (#1766) Isaac Solo [b0c00f1] [C-875] Remove blocklist (#1764) Dylan Jeffers [859df1f] [RN Reloaded] Migrate web common/store and common/hooks to @audius/common (#1675) nicoback2 [bdd9e03] [PAY-546] Add memo instruction to final onramp transfer, fix rent min problem (#1731) Marcus Pasell [635a6ed] [PAY-431] Slide in supporters after loading (#1720) Reed [2af212a] [PAY-438] Fix Twitter icon fill color in matrix mode (#1760) Reed [bd925e1] Add pill radio button (#1745) Marcus Pasell [0392854] Remove eager discprov logs (#1762) Dylan Jeffers [b6733ef] Update @audius/sdk to 0.0.38 (#1757) Isaac Solo [a5e941e] [C-862] Add env to saga context, fix eagerDiscprov in native (#1753) Dylan Jeffers [873ed99] Remove /macro usage for typed-redux-saga (#1751) (#1755) Dylan Jeffers [ca202fe] Update playlist actions to use entity manager (#1674) Isaac Solo [48ae001] Fix margin issue (#1752) Raymond Jacobson
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a few random fixes i noticed while integrating with new common!