Update playlist actions to use entity manager by isaacsolo · Pull Request #1674 · AudiusProject/audius-client

isaacsolo · 2022-08-04T18:58:28Z

Description

Use entity manager for playlist actions. This migration will be behind a feature flag. Playlists will also now have metadata uploaded to CNs.

https://www.notion.so/audiusproject/Data-Layer-Migration-EVM-27236549dccb4ed59ec78a1960b00239

Protocol changes:
AudiusProject/apps#3400
AudiusProject/apps#3719

Completes PLAT-272.

Dragons

Is there anything the reviewer should be on the lookout for? Are there any dangerous changes?

How Has This Been Tested?

Tested locally.
Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.

How will this change be monitored?

Will merge after soaking in staging.

For features that are critical or could fail silently please describe the monitoring/alerting being added.

Feature Flags

Are all new features properly feature flagged? Describe added feature flags.

PLAYLIST_ENTITY_MANAGER_ENABLED for enabling playlist updates via entity manager.

audius-infra · 2022-08-12T03:30:20Z

Preview this change https://demo.audius.co/is-entity-manager

gitguardian · 2022-08-17T00:17:35Z

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.

^{_{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!}}

raymondjacobson · 2022-08-18T17:24:17Z

+        if (!playlistEntityManagerIsEnabled) {
+          yield put(
+            cacheActions.update(Kind.COLLECTIONS, [
+              { id: uid, metadata: { _moved: subscribedUid } }


do we need any of this _moved logic?

i think it's still necessary for the entity manager disabled case. just trying to keep it the same as it was before.

nicoback2

Lgtm pending a few comments!

nicoback2 · 2022-08-18T18:57:41Z

-      function* (confirmedPlaylistId) {
+      function* () {
        const { blockHash, blockNumber, error } = yield call(
          audiusBackendInstance.updatePlaylist,
-          confirmedPlaylistId,
+          playlistId,


Should we gate this change behind the feature flag or does it work fine with the old update pattern?

nicoback2 · 2022-08-18T19:00:38Z

      {
        operationId: PlaylistOperations.ADD_TRACK,
-        parallelizable: true,
-        useOnlyLastSuccessCall: true


Should add this back for the non entity manager case:
useOnlyLastSuccessCall: !playlistEntityManagerEnabled

nicoback2 · 2022-08-18T19:05:09Z

-        parallelizable: true,
-        useOnlyLastSuccessCall: true
+        parallelizable: !playlistEntityManagerIsEnabled,
+        squashable: playlistEntityManagerIsEnabled


Ditto re: comment above about adding back useOnlyLastSuccessCall

nicoback2 · 2022-08-18T19:07:31Z

+  playlist.playlist_contents.track_ids =
+    updatedPlaylist.playlist_contents.track_ids



Could you just remove this and pass updatedPlaylist below? (Personally prefer not mutating objects directly, tends to be bug prone)

nicoback2 · 2022-08-18T19:11:15Z

+        const tempPlaylistId = getTempPlaylistId()
        const { blockHash, blockNumber, playlistId, error } = yield call(
          audiusBackendInstance.createPlaylist,
+          tempPlaylistId,


Might be totally misunderstanding this but doesn't this playlist Id become the real id? So maybe we should get rid of the temp prefix everywhere?

yea that's true for the new flow but it's still actually a temp ID for the legacy playlist flow so i wanted to avoid confusion there. i'll add a comment!

audius-infra · 2022-08-19T22:26:21Z

Preview this change https://demo.audius.co/is-entity-manager

[ccf1ca9] [C-906] Migrate queue sagas and hls-utils to common (#1805) Dylan Jeffers [fe441af] Consume new Text Button in collapsible content (#1790) Marcus Pasell [2ee3b2d] Add error UI to InProgress page of BuyAudio modal (#1802) Marcus Pasell [139e50e] Add TextButton story (#1803) Marcus Pasell [a4d26cf] Add all the pages to the BuyAudioModal (#1800) Marcus Pasell [15dfb72] Update package.json (#1801) Raymond Jacobson [284431d] [C-817] Deep link /settings on mobile (#1796) Raymond Jacobson [2b7ca95] [PAY-44] Rename getAssociatedTokenAccountInfo and getUserBank (#1794) Reed [ff07bb4] [PAY-580] Add Success Page to BuyAudio Modal (#1791) Marcus Pasell [51269bb] [C-901] Move audioPlayer to saga context (#1797) Dylan Jeffers [dfc6f08] [C-900] Move queue, lineup, feed-page sagas to common (#1795) Dylan Jeffers [4f25517] [C-897] Add explore service to saga context (#1793) Dylan Jeffers [8cc3a29] Move sagaHelpers to common (#1792) Sebastian Klingler [8ee3aa8] Add Text Button type to Stems (#1789) Marcus Pasell [ff4f913] [PAY-552] Change playllenge challenge button text (#1787) Reed [60ed26a] Fix bug with renamed component (#1788) Marcus Pasell [718f35a] Dynamically resize ModalContentPages (#1785) Marcus Pasell [4903c9f] [PAY-577] Add "in progress" page to Buy Audio Modal (#1783) Marcus Pasell [72fc4fd] Migrate queue selectors to common (#1786) Dylan Jeffers [5f3e46e] [C-871] Migrate player state to common (#1784) Dylan Jeffers [8d77abf] [PAY-476] Display error when send to wallet fails (#1780) Reed [6adbdda] [PAY-575] [PAY-574] [PAY-573] [PAY-572] [PAY-581] Coinbase Pay Button and Rewards Page Fixes (#1778) Marcus Pasell [56c3f39] [PAY-458] Buy Audio Modal Input Page (#1777) Marcus Pasell [172d6c4] Cleans up code for Challenge Twitter icon fill color (#1781) Reed [bd1a329] Fix order playlist to use updated playlist (#1774) Isaac Solo [1f178bc] [C-887] Host sourcemaps on s3, fixes cloudflare deploy (#1776) Sebastian Klingler [0551dec] [PAY-571] Move Jupiter out of bundle, attach BuyAudio sagas (#1772) Marcus Pasell [db9cd4a] [C-890] Polyfill TextEncoder, fixes builds (#1775) Dylan Jeffers [de8c73a] Update @coinbase/cbpay-js to v1.2.0 and @solana/web3.js to 1.53.0 (#1773) Marcus Pasell [bdec4b7] Add entity manager address to configInternalWeb3 (#1763) nicoback2 [d3fae31] Wire up initial BuyAudioModal (#1770) Marcus Pasell [fc5e484] Add back modal hook functionality (#1769) Marcus Pasell [ae616cc] Fix @audius/common external warnings, model imports, lint (#1767) Dylan Jeffers [2a121e4] Add entity manager address for prod env (#1766) Isaac Solo [b0c00f1] [C-875] Remove blocklist (#1764) Dylan Jeffers [859df1f] [RN Reloaded] Migrate web common/store and common/hooks to @audius/common (#1675) nicoback2 [bdd9e03] [PAY-546] Add memo instruction to final onramp transfer, fix rent min problem (#1731) Marcus Pasell [635a6ed] [PAY-431] Slide in supporters after loading (#1720) Reed [2af212a] [PAY-438] Fix Twitter icon fill color in matrix mode (#1760) Reed [bd925e1] Add pill radio button (#1745) Marcus Pasell [0392854] Remove eager discprov logs (#1762) Dylan Jeffers [b6733ef] Update @audius/sdk to 0.0.38 (#1757) Isaac Solo [a5e941e] [C-862] Add env to saga context, fix eagerDiscprov in native (#1753) Dylan Jeffers [873ed99] Remove /macro usage for typed-redux-saga (#1751) (#1755) Dylan Jeffers [ca202fe] Update playlist actions to use entity manager (#1674) Isaac Solo [48ae001] Fix margin issue (#1752) Raymond Jacobson

hareeshnagaraj and others added 8 commits July 5, 2022 22:19

USING NEW API

9ec1880

Working changes for playlist

744d785

Merge branch 'main' into hn_data_write_test_branch

8d258aa

Minor naming fixes

bacfde1

Merge branch 'main' into hn_data_write_test_branch

8f5fa7f

Fix local env entity manager address

4875d25

wip

9a65d2d

add delete playlist via audius data

fccb117

pull-request-size Bot added the size/L label Aug 4, 2022

isaacsolo force-pushed the is-entity-manager branch from 9fbf087 to cec3d1b Compare August 4, 2022 19:01

isaacsolo requested a review from jowlee August 4, 2022 19:06

isaacsolo marked this pull request as ready for review August 4, 2022 19:06

working playlist updates

8e00f50

isaacsolo force-pushed the is-entity-manager branch from cec3d1b to 8e00f50 Compare August 4, 2022 19:07

isaacsolo assigned hareeshnagaraj Aug 4, 2022

isaacsolo mentioned this pull request Aug 5, 2022

Add entity manager for playlist actions AudiusProject/apps#3400

Merged

Isaac added 3 commits August 10, 2022 23:42

wip

9812b1b

optimisitcally use random playlist ID

08be8a6

wip

8f76341

Ubuntu added 2 commits August 12, 2022 21:12

working confirmer

ef5ab52

clean

f57eeec

isaacsolo requested a review from dylanjeffers August 13, 2022 00:08

Isaac Solo added 3 commits August 15, 2022 11:16

feature flag album delete

f1e5ff8

working resolved conflicts

097e6fe

Merge branch 'is-entity-manager' into is-entity-manager-2

16e3c4f

pull-request-size Bot added size/XXL and removed size/L labels Aug 17, 2022

Merge branch 'main' into is-entity-manager

a6b51b0

pull-request-size Bot added size/XL and removed size/XXL labels Aug 17, 2022

isaacsolo requested a review from nicoback2 August 17, 2022 00:21

fix merge again

00e8121

raymondjacobson reviewed Aug 17, 2022

View reviewed changes

Comment thread packages/web/.env/.env.dev Outdated

pass track cover art

d49d38c

isaacsolo commented Aug 17, 2022

View reviewed changes

Comment thread packages/web/src/common/store/cache/collections/sagas.js

squashable updates

e20f34a

isaacsolo requested a review from raymondjacobson August 18, 2022 16:59

raymondjacobson reviewed Aug 18, 2022

View reviewed changes

fix create album

deaf411

isaacsolo mentioned this pull request Aug 18, 2022

Playlist updates from cached playlist state AudiusProject/apps#3719

Merged

nicoback2 approved these changes Aug 18, 2022

View reviewed changes

Isaac Solo added 3 commits August 18, 2022 12:43

move blockheight timestamp

9745eb9

feature flag confirmer stuff and clean up some more

179f02c

Merge branch 'main' into is-entity-manager

0965f88

clean up

e237803

isaacsolo force-pushed the is-entity-manager branch from 9ec32ff to e237803 Compare August 20, 2022 00:24

isaacsolo merged commit ca202fe into main Aug 20, 2022

isaacsolo deleted the is-entity-manager branch August 20, 2022 00:38

AudiusProject deleted a comment from linear Bot Sep 11, 2023

		playlist.playlist_contents.track_ids =
		updatedPlaylist.playlist_contents.track_ids

Conversation

isaacsolo commented Aug 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Dragons

How Has This Been Tested?

How will this change be monitored?

Feature Flags

Uh oh!

audius-infra commented Aug 12, 2022

Uh oh!

gitguardian Bot commented Aug 17, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

️✅ There are no secrets present in this pull request anymore.

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

nicoback2 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

audius-infra commented Aug 19, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

isaacsolo commented Aug 4, 2022 •

edited

Loading

gitguardian Bot commented Aug 17, 2022 •

edited

Loading