This repository was archived by the owner on Oct 4, 2023. It is now read-only.
[C-820] Move apiClient into saga context, Add WalletClient to context#1711
Merged
Conversation
nicoback2
approved these changes
Aug 12, 2022
| limit, | ||
| offset, | ||
| entityId, | ||
| currentUserId |
Contributor
There was a problem hiding this comment.
was the type here deleted intentionally?
| setLocalStorageItem: async (key, value) => AsyncStorage.setItem(key, value), | ||
| remoteConfigInstance, | ||
| audiusBackendInstance, | ||
| apiClient, |
Contributor
There was a problem hiding this comment.
just curious, why are the first two suffixed with Instance and the rest isn't?
Contributor
There was a problem hiding this comment.
We started following that pattern with remoteConfigInstance, but I would be down to remove Instance or add it to the other ones. Either way
Contributor
Author
There was a problem hiding this comment.
yeah its a good call, im just going off existing naming conventions. in the future would be down to rename all this to something more consistent, do you have thoughts? maybe remove the "instance" since that's just a lot of extra chars?
Contributor
Author
There was a problem hiding this comment.
oh clutch ahah we were typing the sameee thing <3
sliptype
approved these changes
Aug 12, 2022
| setLocalStorageItem: async (key, value) => AsyncStorage.setItem(key, value), | ||
| remoteConfigInstance, | ||
| audiusBackendInstance, | ||
| apiClient, |
Contributor
There was a problem hiding this comment.
We started following that pattern with remoteConfigInstance, but I would be down to remove Instance or add it to the other ones. Either way
audius-infra
pushed a commit
that referenced
this pull request
Aug 13, 2022
[0d2f211] [C-826] Move remote-config-instance to saga context (#1713) Dylan Jeffers [bcd68c7] Add sagas for OnRamp to AUDIO (#1666) Marcus Pasell [1ca2af2] Prevent showing file explorer on pressing enter (#1704) Saliou Diallo [0b6f0e4] [PAY-521] Add web dethroned notification (#1712) Michael Piazza [76b1b0e] [C-820] Move apiClient into saga context, Add WalletClient to context (#1711) Dylan Jeffers [2706cef] [C-807] Move audiusBackendInstance into context across all sagas (#1710) Dylan Jeffers [25c9433] [PAY-466] Display AAO emoji errors for failed reward claims (#1693) Reed [c2a79ff] [C-808] Don't show unnecessarily show profile option on overflow menu (#1708) Dylan Jeffers [94e188f] [C-801] Add tag search text to mobile (#1706) Dylan Jeffers [a47c2e2] [C-806] Prevent multiple overflow menus at a time (#1698) Saliou Diallo [dce8a58] [C-797] Fix track-remix-screen text color (#1705) Dylan Jeffers [1325829] Add extends null (#1707) Sebastian Klingler [51e38d6] [C-805] Fix artifact on small card (#1696) Raymond Jacobson [0a521b1] [C-798] Remove owned/created stamp from collectible tile (#1689) Sebastian Klingler [18ae0a0] [C-804] Show playlist count for non-artists in native (#1697) Dylan Jeffers [ffcf0da] Fix associated wallets (#1692) Raymond Jacobson [e287fb1] [PAY-267, C-753] Remove tipping feature flags, Fix mutuals icon (#1695) Dylan Jeffers [118102d] [C-794] Add typecheck to web ci (#1694) Sebastian Klingler [4f60a49] [C-803] Add common state and backend sagas to native (#1691) Dylan Jeffers [96d9cc8] [C-800] Add native saga context and update common sagas (#1690) Dylan Jeffers [12add4a] [C-799] Add saga context, refactor backend state (#1688) Dylan Jeffers [afdbe97] [C-796] Refactor AudiusAPIClient to work in native context (#1687) Dylan Jeffers [a185c09] [C-795] Fix user-list tag imports (#1686) Dylan Jeffers [3a8704c] [C-774] Move audius-backend to common, add native libs-instance (#1685) Dylan Jeffers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description