Fix associated wallets#1692
Conversation
9e2cb06 to
0e0987d
Compare
|
Preview this change https://demo.audius.co/rj-fix-disconnected-wallets |
sliptype
left a comment
There was a problem hiding this comment.
Simple enough! Should we cherry pick onto the current release or the one going out Wednesday?
dylanjeffers
left a comment
There was a problem hiding this comment.
Looks great, do we have some logs around started, already has, completion, missing cid to make sure of anything?
piazzatron
left a comment
There was a problem hiding this comment.
Logic looks totally sound to me – it's a bit weird in that these users can't ever disconnect wallets while this fix is active, but seems like a sane price to pay. Two thoughts
- Maybe worth adding some logs around this to know when we're hitting this behavior
- Could add some metrics on amplitude to get a sense of how many users have hit this, so we know better when to turn it off. Alternatively I guess our sql query would accomplish the same thing
this won't stop users from disconnecting. it uses the fact that the bug caused the field to be null not empty obj |
probably both for web, can wait for mobile! |
I think the sql queries we have are sufficient to track progress, but i could add some new amplitude metrics if you're super into that? wdyt? |
[0d2f211] [C-826] Move remote-config-instance to saga context (#1713) Dylan Jeffers [bcd68c7] Add sagas for OnRamp to AUDIO (#1666) Marcus Pasell [1ca2af2] Prevent showing file explorer on pressing enter (#1704) Saliou Diallo [0b6f0e4] [PAY-521] Add web dethroned notification (#1712) Michael Piazza [76b1b0e] [C-820] Move apiClient into saga context, Add WalletClient to context (#1711) Dylan Jeffers [2706cef] [C-807] Move audiusBackendInstance into context across all sagas (#1710) Dylan Jeffers [25c9433] [PAY-466] Display AAO emoji errors for failed reward claims (#1693) Reed [c2a79ff] [C-808] Don't show unnecessarily show profile option on overflow menu (#1708) Dylan Jeffers [94e188f] [C-801] Add tag search text to mobile (#1706) Dylan Jeffers [a47c2e2] [C-806] Prevent multiple overflow menus at a time (#1698) Saliou Diallo [dce8a58] [C-797] Fix track-remix-screen text color (#1705) Dylan Jeffers [1325829] Add extends null (#1707) Sebastian Klingler [51e38d6] [C-805] Fix artifact on small card (#1696) Raymond Jacobson [0a521b1] [C-798] Remove owned/created stamp from collectible tile (#1689) Sebastian Klingler [18ae0a0] [C-804] Show playlist count for non-artists in native (#1697) Dylan Jeffers [ffcf0da] Fix associated wallets (#1692) Raymond Jacobson [e287fb1] [PAY-267, C-753] Remove tipping feature flags, Fix mutuals icon (#1695) Dylan Jeffers [118102d] [C-794] Add typecheck to web ci (#1694) Sebastian Klingler [4f60a49] [C-803] Add common state and backend sagas to native (#1691) Dylan Jeffers [96d9cc8] [C-800] Add native saga context and update common sagas (#1690) Dylan Jeffers [12add4a] [C-799] Add saga context, refactor backend state (#1688) Dylan Jeffers [afdbe97] [C-796] Refactor AudiusAPIClient to work in native context (#1687) Dylan Jeffers [a185c09] [C-795] Fix user-list tag imports (#1686) Dylan Jeffers [3a8704c] [C-774] Move audius-backend to common, add native libs-instance (#1685) Dylan Jeffers
Description
Add an online helper for users to connect wallets that got disconnected in Flare-101
This PR should be reverted after a sufficient amount of time has passed or all users have re-connected their wallets. (Since we have the user ids, the query is easy to run to check).
Dragons
Is there anything the reviewer should be on the lookout for? Are there any dangerous changes?
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.
Tested on production account
rayjacobsonThe "migration" ran once for the user, fixed the wallets, and is not running again.
How will this change be monitored?
For features that are critical or could fail silently please describe the monitoring/alerting being added.
Feature Flags
Are all new features properly feature flagged? Describe added feature flags.