SDK: Allow updating DN selector config after initializing#4734
Merged
Conversation
sliptype
approved these changes
Feb 8, 2023
15 tasks
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
9bc4ac5 to
f5dfcc3
Compare
audius-infra
pushed a commit
that referenced
this pull request
Feb 10, 2023
## Changelog - 2023-02-09 [71094d6] SDK: Update CI to allow version, preid to be specified (#4750) [Marcus Pasell] - 2023-02-09 [240883c] SDK: Use camelCase in generated API (#4728) [Marcus Pasell] - 2023-02-09 [b89fc9e] SDK: Allow updating DN selector config after initializing (#4734) [Marcus Pasell] - 2023-02-09 [8899266] [SDK] Discovery Node Selector V2 and SDK V2 (#4723) [Marcus Pasell] - 2023-02-09 [67f6a40] Update libs to relay EM to POA and ACDC (#4508) [Isaac Solo] - 2023-02-08 [c7d3dfe] Bump sdk to v1.0.45 [audius-infra]
audius-infra
pushed a commit
that referenced
this pull request
Feb 10, 2023
## Changelog - 2023-02-09 [71094d6] SDK: Update CI to allow version, preid to be specified (#4750) [Marcus Pasell] - 2023-02-09 [240883c] SDK: Use camelCase in generated API (#4728) [Marcus Pasell] - 2023-02-09 [b89fc9e] SDK: Allow updating DN selector config after initializing (#4734) [Marcus Pasell] - 2023-02-09 [8899266] [SDK] Discovery Node Selector V2 and SDK V2 (#4723) [Marcus Pasell] - 2023-02-09 [67f6a40] Update libs to relay EM to POA and ACDC (#4508) [Isaac Solo] - 2023-02-08 [c7d3dfe] Bump sdk to v1.0.45 [audius-infra]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Allows the SDK to have its configuration changed after initialization for a subset of the configuration properties. Useful for eg. setting the allow/blocklists via Optimizely asynchronously, allowing SDK to initialize synchronously with some async config later.
Tests
Monitoring - How will this change be monitored? Are there sufficient logs / alerts?