Skip to content

SDK: Use camelCase in generated API#4728

Merged
rickyrombo merged 2 commits into
mainfrom
mjp-sdk-v2-camelcase
Feb 10, 2023
Merged

SDK: Use camelCase in generated API#4728
rickyrombo merged 2 commits into
mainfrom
mjp-sdk-v2-camelcase

Conversation

@rickyrombo

@rickyrombo rickyrombo commented Feb 7, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Changes SDK Discovery API generation to output camelCase conversions of the endpoint data.

See first commit for config change. The rest is autogenerated.

Depends on:

Tests

Monitoring - How will this change be monitored? Are there sufficient logs / alerts?

@rickyrombo rickyrombo mentioned this pull request Feb 7, 2023
Merged
15 tasks
@rickyrombo rickyrombo requested review from sliptype and removed request for sliptype February 10, 2023 01:52
Base automatically changed from mjp-dn-select-v2 to main February 10, 2023 01:53
@gitguardian

gitguardian Bot commented Feb 10, 2023 •
edited
Loading

Copy link
Copy Markdown

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@rickyrombo rickyrombo requested a review from sliptype February 10, 2023 02:21
sliptype
sliptype approved these changes Feb 10, 2023
View reviewed changes

@sliptype sliptype left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

We should try to upgrade to the new version asap in the client because it will be easy right now, before we have a bunch of things using the sdk

@rickyrombo rickyrombo merged commit 240883c into main Feb 10, 2023
@rickyrombo rickyrombo deleted the mjp-sdk-v2-camelcase branch February 10, 2023 02:25
audius-infra pushed a commit that referenced this pull request Feb 10, 2023
Bump sdk to v2.0.0
2905eab 
## Changelog

- 2023-02-09 [71094d6] SDK: Update CI to allow version, preid to be specified (#4750) [Marcus Pasell]
- 2023-02-09 [240883c] SDK: Use camelCase in generated API (#4728) [Marcus Pasell]
- 2023-02-09 [b89fc9e] SDK: Allow updating DN selector config after initializing (#4734) [Marcus Pasell]
- 2023-02-09 [8899266] [SDK] Discovery Node Selector V2 and SDK V2 (#4723) [Marcus Pasell]
- 2023-02-09 [67f6a40] Update libs to relay EM to POA and ACDC (#4508) [Isaac Solo]
- 2023-02-08 [c7d3dfe] Bump sdk to v1.0.45 [audius-infra]
audius-infra pushed a commit that referenced this pull request Feb 10, 2023
Bump sdk to v2.0.0
3250c16 
## Changelog

- 2023-02-09 [71094d6] SDK: Update CI to allow version, preid to be specified (#4750) [Marcus Pasell]
- 2023-02-09 [240883c] SDK: Use camelCase in generated API (#4728) [Marcus Pasell]
- 2023-02-09 [b89fc9e] SDK: Allow updating DN selector config after initializing (#4734) [Marcus Pasell]
- 2023-02-09 [8899266] [SDK] Discovery Node Selector V2 and SDK V2 (#4723) [Marcus Pasell]
- 2023-02-09 [67f6a40] Update libs to relay EM to POA and ACDC (#4508) [Isaac Solo]
- 2023-02-08 [c7d3dfe] Bump sdk to v1.0.45 [audius-infra]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@sliptype sliptype sliptype approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size/XXL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rickyrombo @sliptype