Skip to content

Add conservative_retrying#71

Merged
kmike merged 24 commits intomainfrom
conservative-retrying
May 29, 2024
Merged

Add conservative_retrying#71
kmike merged 24 commits intomainfrom
conservative-retrying

Conversation

@Gallaecio
Copy link
Contributor

I feel like this alternative retry policy will be more useful to most projects. Since changing the default retry policy to something like this would require some discussion, I think it may be a good idea to implement it as an alternative ready-to-use retry policy, so that fewer users need to implement their own custom retry policy.

@Gallaecio Gallaecio requested review from kmike and wRAR April 26, 2024 10:50
@Gallaecio Gallaecio closed this Apr 30, 2024
@Gallaecio Gallaecio reopened this Apr 30, 2024
@codecov
Copy link

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (9e5bb74) to head (d87c0e6).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #71   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        17           
  Lines          469       558   +89     
  Branches        56        71   +15     
=========================================
+ Hits           469       558   +89     
Files Coverage Δ
zyte_api/__init__.py 100.00% <100.00%> (ø)
zyte_api/_async.py 100.00% <100.00%> (ø)
zyte_api/_retry.py 100.00% <100.00%> (ø)

@Gallaecio
Copy link
Contributor Author

Closing and re-opening to verify a fix for the unrelated issue of Codecov uploads…

@Gallaecio Gallaecio closed this May 2, 2024
@Gallaecio Gallaecio reopened this May 2, 2024
@Gallaecio Gallaecio marked this pull request as draft May 8, 2024 18:46
@Gallaecio Gallaecio marked this pull request as ready for review May 9, 2024 08:14
@Gallaecio Gallaecio requested a review from wRAR May 9, 2024 08:14
@kmike kmike merged commit 221eb5c into main May 29, 2024
@kmike
Copy link
Collaborator

kmike commented May 29, 2024

Thanks @Gallaecio!

@wRAR wRAR deleted the conservative-retrying branch April 5, 2025 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants