Remove ntp_make_packet since it is dead code#681
Merged
Conversation
The function is not called anywhere. The module's make_packet uses `udp_make_packet`. The type of `ntp_make_packet` is also not compatible with `probe_make_packet_cb` any longer. For example the `size_t *buf_len` argument is missing.
dadrian
approved these changes
Nov 10, 2021
Member
|
Thanks, I meant to do this when I cleaned up the probe module interface. |
davideandres95
pushed a commit
to ds-ukassel/zmap-multipath-rtt
that referenced
this pull request
Jun 26, 2026
The function is not called anywhere. The module's make_packet uses `udp_make_packet`. The type of `ntp_make_packet` is also not compatible with `probe_make_packet_cb` any longer. For example the `size_t *buf_len` argument is missing. zmap/zmap#681
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The function is not called anywhere. The module's make_packet uses
udp_make_packet.The type of
ntp_make_packetis also not compatible withprobe_make_packet_cbany longer. For example thesize_t *buf_lenargument is missing.