fix index in TestGenerateSpiloPodEnvVars#1084
Merged
Merged
Conversation
FxKu
requested review from
CyberDem0n,
Jan-M,
RafiaSabih,
avaczi,
erthalion and
sdudoladov
as code owners
July 30, 2020 10:13
Contributor
|
👍 |
1 similar comment
Contributor
Author
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #946 changed the order of Pod env variables to allow overwriting by additional variables coming from ConfigMap or Secret. Thus the
DCS_ENABLE_KUBERNETES_APIorETCD_HOSTvariables now come before the additional variables